Issues in Common.php (master) - Issues in master - rugk/threema-msgapi-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

source/Threema/Console/Common.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author Threema GmbH
 * @copyright Copyright (c) 2015-2016 Threema GmbH
 */


namespace Threema\Console;

use Threema\Core\Exception;
use Threema\MsgApi\Constants;

class Common {
	/**
	 * output a string, wrap at 100 chars
	 *
	 * @param string $string string to output
	 * @param int $indent indent
	 */
	public static function l($string = '', $indent = 0) {
		$pad = str_repeat('  ', $indent);
		echo $pad . wordwrap($string, 100, "\n" . $pad) . "\n";
	}

	/**
	 * output a line
	 *
	 * @param string $string string to output
	 */
	public static function ln($string = '') {
		echo $string . "\n";
	}

	/**
	 * output a error message to the stderr
	 *
	 * @param string $msg
	 */
	public static function e($msg) {
		$STDERR = fopen('php://stderr', 'w+');
		fwrite($STDERR, $msg."\n");

	}

	/**
	 * check arguments for null, throws an exception on null or strlen == 0
	 *
	 * @params ...$things
	 * @throws \Threema\Core\Exception
	 */
	public static function required() {
		$argCount = func_num_args();
		for($n = 0; $n < $argCount; $n++) {
			$o = func_get_arg($n);
			if(null === $o || (is_scalar($o) && strlen($o) == 0)) {
				throw new Exception('invalid data');
			}
		}
	}

	/**
	 * Append the prefix to the the PublicKey @key
	 *
	 * @param string $key PublicKey in hex
	 * @return null|string
	 */
	public static function convertPublicKey($key) {
		if(null !== $key) {
			return Constants::PUBLIC_KEY_PREFIX.$key;
		}
		return null;
	}

	/**
	 * Extract the PublicKey
	 *
	 * @param string $stringWithPrefix PublicKey in hex with the key-prefix
	 * @return null|string
	 */
	public static function getPublicKey($stringWithPrefix = null) {
		if(null !== $stringWithPrefix && substr($stringWithPrefix, 0, strlen(Constants::PUBLIC_KEY_PREFIX)) == Constants::PUBLIC_KEY_PREFIX) {

			return substr($stringWithPrefix, strlen(Constants::PUBLIC_KEY_PREFIX));
		}
		return null;
	}

	/**
	 * Append the prefix to the the PrivateKey @key
	 *
	 * @param string $key PrivateKey in hex
	 * @return null|string
	 */
	public static function convertPrivateKey($key) {
		if(null !== $key) {
			return Constants::PRIVATE_KEY_PREFIX.$key;
		}
		return null;
	}

	/**
	 * Extract the PrivateKey
	 *
	 * @param string $stringWithPrefix PrivateKey in hex with the key-prefix (@Constants::PRIVATE_KEY_PREFIX)
	 * @return null|string
	 */
	public static function getPrivateKey($stringWithPrefix = null) {
		if(null !== $stringWithPrefix && substr($stringWithPrefix, 0, strlen(Constants::PRIVATE_KEY_PREFIX)) == Constants::PRIVATE_KEY_PREFIX) {

			return substr($stringWithPrefix, strlen(Constants::PRIVATE_KEY_PREFIX));
		}
		return null;
	}
}


1		<?php
2		/**
3		* @author Threema GmbH
4		* @copyright Copyright (c) 2015-2016 Threema GmbH
5		*/
6
7
8		namespace Threema\Console;
9
10		use Threema\Core\Exception;
11		use Threema\MsgApi\Constants;
12
13		class Common {
14		/**
15		* output a string, wrap at 100 chars
16		*
17		* @param string $string string to output
18		* @param int $indent indent
19		*/
20		public static function l($string = '', $indent = 0) {
21		$pad = str_repeat(' ', $indent);
22		echo $pad . wordwrap($string, 100, "\n" . $pad) . "\n";
23		}
24
25		/**
26		* output a line
27		*
28		* @param string $string string to output
29		*/
30		public static function ln($string = '') {
31		echo $string . "\n";
32		}
33
34		/**
35		* output a error message to the stderr
36		*
37		* @param string $msg
38		*/
39		public static function e($msg) {
40		$STDERR = fopen('php://stderr', 'w+');
41		fwrite($STDERR, $msg."\n");
42
43		}
44
45		/**
46		* check arguments for null, throws an exception on null or strlen == 0
47		*
48		* @params ...$things
49		* @throws \Threema\Core\Exception
50		*/
51		public static function required() {
52		$argCount = func_num_args();
53		for($n = 0; $n < $argCount; $n++) {
54		$o = func_get_arg($n);
55		if(null === $o \|\| (is_scalar($o) && strlen($o) == 0)) {
56		throw new Exception('invalid data');
57		}
58		}
59		}
60
61		/**
62		* Append the prefix to the the PublicKey @key
63		*
64		* @param string $key PublicKey in hex
65		* @return null\|string
66		*/
67		public static function convertPublicKey($key) {
68		if(null !== $key) {
69		return Constants::PUBLIC_KEY_PREFIX.$key;
70		}
71		return null;
72		}
73
74		/**
75		* Extract the PublicKey
76		*
77		* @param string $stringWithPrefix PublicKey in hex with the key-prefix
78		* @return null\|string
79		*/
80		public static function getPublicKey($stringWithPrefix = null) {
81	View Code Duplication	if(null !== $stringWithPrefix && substr($stringWithPrefix, 0, strlen(Constants::PUBLIC_KEY_PREFIX)) == Constants::PUBLIC_KEY_PREFIX) {
		0 ignored issues – show Duplication introduced 2015-11-21 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		return substr($stringWithPrefix, strlen(Constants::PUBLIC_KEY_PREFIX));
83		}
84		return null;
85		}
86
87		/**
88		* Append the prefix to the the PrivateKey @key
89		*
90		* @param string $key PrivateKey in hex
91		* @return null\|string
92		*/
93		public static function convertPrivateKey($key) {
94		if(null !== $key) {
95		return Constants::PRIVATE_KEY_PREFIX.$key;
96		}
97		return null;
98		}
99
100		/**
101		* Extract the PrivateKey
102		*
103		* @param string $stringWithPrefix PrivateKey in hex with the key-prefix (@Constants::PRIVATE_KEY_PREFIX)
104		* @return null\|string
105		*/
106		public static function getPrivateKey($stringWithPrefix = null) {
107	View Code Duplication	if(null !== $stringWithPrefix && substr($stringWithPrefix, 0, strlen(Constants::PRIVATE_KEY_PREFIX)) == Constants::PRIVATE_KEY_PREFIX) {
		0 ignored issues – show Duplication introduced 2015-11-21 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108		return substr($stringWithPrefix, strlen(Constants::PRIVATE_KEY_PREFIX));
109		}
110		return null;
111		}
112		}
113

rugk / threema-msgapi-sdk-php

Issues (41)

Security Analysis no request data

source/Threema/Console/Common.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like