Completed
Pull Request — master (#36)
by rugk
02:38
created
source/Threema/MsgApi/ConnectionSettings.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,16 +48,16 @@
 block discarded – undo
48 48
 		$this->host = $host;
49 49
 
50 50
 		// TLS options
51
-		if(null !== $tlsOptions && is_array($tlsOptions)) {
52
-			if(true === array_key_exists(self::tlsOptionForceHttps, $tlsOptions)) {
51
+		if (null !== $tlsOptions && is_array($tlsOptions)) {
52
+			if (true === array_key_exists(self::tlsOptionForceHttps, $tlsOptions)) {
53 53
 				$this->tlsOptions[self::tlsOptionForceHttps] = $tlsOptions[self::tlsOptionForceHttps] === true;
54 54
 			}
55 55
 
56
-			if(true === array_key_exists(self::tlsOptionVersion, $tlsOptions)) {
56
+			if (true === array_key_exists(self::tlsOptionVersion, $tlsOptions)) {
57 57
 				$this->tlsOptions[self::tlsOptionVersion] = $tlsOptions[self::tlsOptionVersion];
58 58
 			}
59 59
 
60
-			if(true === array_key_exists(self::tlsOptionCipher, $tlsOptions)) {
60
+			if (true === array_key_exists(self::tlsOptionCipher, $tlsOptions)) {
61 61
 				$this->tlsOptions[self::tlsOptionCipher] = $tlsOptions[self::tlsOptionCipher];
62 62
 			}
63 63
 		}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Helpers/E2EHelper.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 		$this->cryptTool = $cryptTool;
43 43
 		$this->privateKey = $privateKey;
44 44
 
45
-		if(null === $this->cryptTool) {
45
+		if (null === $this->cryptTool) {
46 46
 			$this->cryptTool = CryptTool::getInstance();
47 47
 		}
48 48
 	}
@@ -84,11 +84,11 @@  discard block
 block discarded – undo
84 84
 		//analyse the file
85 85
 		$fileAnalyzeResult = FileAnalysisTool::analyse($imagePath);
86 86
 
87
-		if(null === $fileAnalyzeResult) {
87
+		if (null === $fileAnalyzeResult) {
88 88
 			throw new Exception('could not analyze the file');
89 89
 		}
90 90
 
91
-		if(false === in_array($fileAnalyzeResult->getMimeType(), array(
91
+		if (false === in_array($fileAnalyzeResult->getMimeType(), array(
92 92
 				'image/jpg',
93 93
 				'image/jpeg',
94 94
 				'image/png' ))) {
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
 
103 103
 		//encrypt the image file
104 104
 		$encryptionResult = $this->cryptTool->encryptImage(file_get_contents($imagePath), $this->privateKey, $receiverPublicKey);
105
-		$uploadResult =  $this->connection->uploadFile($encryptionResult->getData());
105
+		$uploadResult = $this->connection->uploadFile($encryptionResult->getData());
106 106
 
107
-		if($uploadResult == null || !$uploadResult->isSuccess()) {
107
+		if ($uploadResult == null || !$uploadResult->isSuccess()) {
108 108
 			throw new Exception('could not upload the image ('.$uploadResult->getErrorCode().' '.$uploadResult->getErrorMessage().') '.$uploadResult->getRawResponse());
109 109
 		}
110 110
 
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 		//analyse the file
135 135
 		$fileAnalyzeResult = FileAnalysisTool::analyse($filePath);
136 136
 
137
-		if(null === $fileAnalyzeResult) {
137
+		if (null === $fileAnalyzeResult) {
138 138
 			throw new Exception('could not analyze the file');
139 139
 		}
140 140
 
@@ -145,21 +145,21 @@  discard block
 block discarded – undo
145 145
 
146 146
 		//encrypt the main file
147 147
 		$encryptionResult = $this->cryptTool->encryptFile(file_get_contents($filePath));
148
-		$uploadResult =  $this->connection->uploadFile($encryptionResult->getData());
148
+		$uploadResult = $this->connection->uploadFile($encryptionResult->getData());
149 149
 
150
-		if($uploadResult == null || !$uploadResult->isSuccess()) {
150
+		if ($uploadResult == null || !$uploadResult->isSuccess()) {
151 151
 			throw new Exception('could not upload the file ('.$uploadResult->getErrorCode().' '.$uploadResult->getErrorMessage().') '.$uploadResult->getRawResponse());
152 152
 		}
153 153
 
154 154
 		$thumbnailUploadResult = null;
155 155
 
156 156
 		//encrypt the thumbnail file (if exists)
157
-		if(strlen($thumbnailPath) > 0 && true === file_exists($thumbnailPath)) {
157
+		if (strlen($thumbnailPath) > 0 && true === file_exists($thumbnailPath)) {
158 158
 			//encrypt the main file
159 159
 			$thumbnailEncryptionResult = $this->cryptTool->encryptFileThumbnail(file_get_contents($thumbnailPath), $encryptionResult->getKey());
160 160
 			$thumbnailUploadResult = $this->connection->uploadFile($thumbnailEncryptionResult->getData());
161 161
 
162
-			if($thumbnailUploadResult == null || !$thumbnailUploadResult->isSuccess()) {
162
+			if ($thumbnailUploadResult == null || !$thumbnailUploadResult->isSuccess()) {
163 163
 				throw new Exception('could not upload the thumbnail file ('.$thumbnailUploadResult->getErrorCode().' '.$thumbnailUploadResult->getErrorMessage().') '.$thumbnailUploadResult->getRawResponse());
164 164
 			}
165 165
 		}
@@ -202,14 +202,14 @@  discard block
 block discarded – undo
202 202
 										 $outputFolder = null,
203 203
 										 \Closure $downloadMessage = null) {
204 204
 
205
-		if($outputFolder == null || strlen($outputFolder) == 0) {
205
+		if ($outputFolder == null || strlen($outputFolder) == 0) {
206 206
 			$outputFolder = '.';
207 207
 		}
208 208
 
209 209
 		//fetch the public key
210 210
 		$receiverPublicKey = $this->connection->fetchPublicKey($threemaId);
211 211
 
212
-		if(null === $receiverPublicKey || !$receiverPublicKey->isSuccess()) {
212
+		if (null === $receiverPublicKey || !$receiverPublicKey->isSuccess()) {
213 213
 			throw new Exception('Invalid threema id');
214 214
 		}
215 215
 
@@ -220,15 +220,15 @@  discard block
 block discarded – undo
220 220
 			$nonce
221 221
 		);
222 222
 
223
-		if(null === $message || false === is_object($message)) {
223
+		if (null === $message || false === is_object($message)) {
224 224
 			throw new Exception('Could not encrypt box');
225 225
 		}
226 226
 
227 227
 		$receiveResult = new ReceiveMessageResult($messageId, $message);
228 228
 
229
-		if($message instanceof ImageMessage) {
229
+		if ($message instanceof ImageMessage) {
230 230
 			$result = $this->downloadFile($message, $message->getBlobId(), $downloadMessage);
231
-			if(null !== $result && true === $result->isSuccess()) {
231
+			if (null !== $result && true === $result->isSuccess()) {
232 232
 				$image = $this->cryptTool->decryptImage(
233 233
 					$result->getData(),
234 234
 					hex2bin($receiverPublicKey->getPublicKey()),
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 					throw new Exception('decryption of image failed');
241 241
 				}
242 242
 				//save file
243
-				$filePath = $outputFolder . '/' . $messageId . '.jpg';
243
+				$filePath = $outputFolder.'/'.$messageId.'.jpg';
244 244
 				$f = fopen($filePath, 'w+');
245 245
 				fwrite($f, $image);
246 246
 				fclose($f);
@@ -248,10 +248,10 @@  discard block
 block discarded – undo
248 248
 				$receiveResult->addFile('image', $filePath);
249 249
 			}
250 250
 		}
251
-		else if($message instanceof FileMessage) {
251
+		else if ($message instanceof FileMessage) {
252 252
 			$result = $this->downloadFile($message, $message->getBlobId(), $downloadMessage);
253 253
 
254
-			if(null !== $result && true === $result->isSuccess()) {
254
+			if (null !== $result && true === $result->isSuccess()) {
255 255
 				$file = $this->cryptTool->decryptFile(
256 256
 					$result->getData(),
257 257
 					hex2bin($message->getEncryptionKey()));
@@ -261,20 +261,20 @@  discard block
 block discarded – undo
261 261
 				}
262 262
 
263 263
 				//save file
264
-				$filePath = $outputFolder . '/' . $messageId . '-' . $message->getFilename();
264
+				$filePath = $outputFolder.'/'.$messageId.'-'.$message->getFilename();
265 265
 				file_put_contents($filePath, $file);
266 266
 
267 267
 				$receiveResult->addFile('file', $filePath);
268 268
 			}
269 269
 
270
-			if(null !== $message->getThumbnailBlobId() && strlen($message->getThumbnailBlobId()) > 0) {
270
+			if (null !== $message->getThumbnailBlobId() && strlen($message->getThumbnailBlobId()) > 0) {
271 271
 				$result = $this->downloadFile($message, $message->getThumbnailBlobId(), $downloadMessage);
272
-				if(null !== $result && true === $result->isSuccess()) {
272
+				if (null !== $result && true === $result->isSuccess()) {
273 273
 					$file = $this->cryptTool->decryptFileThumbnail(
274 274
 						$result->getData(),
275 275
 						hex2bin($message->getEncryptionKey()));
276 276
 
277
-					if(null === $file) {
277
+					if (null === $file) {
278 278
 						throw new Exception('thumbnail decryption failed');
279 279
 					}
280 280
 					//save file
@@ -301,14 +301,14 @@  discard block
 block discarded – undo
301 301
 		//fetch the public key
302 302
 		$receiverPublicKey = $this->connection->fetchPublicKey($threemaId);
303 303
 
304
-		if(null === $receiverPublicKey || !$receiverPublicKey->isSuccess()) {
304
+		if (null === $receiverPublicKey || !$receiverPublicKey->isSuccess()) {
305 305
 			throw new Exception('Invalid threema id');
306 306
 		}
307 307
 
308
-		if(null !== $capabilityCheck) {
308
+		if (null !== $capabilityCheck) {
309 309
 			//check capability
310 310
 			$capability = $this->connection->keyCapability($threemaId);
311
-			if(null === $capability || false === $capabilityCheck->__invoke($capability)) {
311
+			if (null === $capability || false === $capabilityCheck->__invoke($capability)) {
312 312
 				throw new Exception('threema id does not have the capability');
313 313
 			}
314 314
 		}
@@ -324,11 +324,11 @@  discard block
 block discarded – undo
324 324
 	 * @throws Exception
325 325
 	 */
326 326
 	private final function downloadFile(ThreemaMessage $message, $blobId, \Closure $downloadMessage = null) {
327
-		if(null === $downloadMessage
327
+		if (null === $downloadMessage
328 328
 			|| true === $downloadMessage->__invoke($message, $blobId)) {
329 329
 			//make a download
330 330
 			$result = $this->connection->downloadFile($blobId);
331
-			if(null === $result || false === $result->isSuccess()) {
331
+			if (null === $result || false === $result->isSuccess()) {
332 332
 				throw new Exception('could not download the file with blob id '.$blobId);
333 333
 			}
334 334
 
Please login to merge, or discard this patch.
source/Threema/MsgApi/Messages/DeliveryReceipt.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	 * @return string
58 58
 	 */
59 59
 	public function getReceiptTypeName() {
60
-		if(true === array_key_exists($this->receiptType, self::$receiptTypesToNames)) {
60
+		if (true === array_key_exists($this->receiptType, self::$receiptTypesToNames)) {
61 61
 			return self::$receiptTypesToNames[$this->receiptType];
62 62
 		}
63 63
 		return null;
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 * @return string
78 78
 	 */
79 79
 	function __toString() {
80
-		$str = "Delivery receipt (" . $this->getReceiptTypeName() . "): ";
80
+		$str = "Delivery receipt (".$this->getReceiptTypeName()."): ";
81 81
 		$hexMessageIds = array();
82 82
 		foreach ($this->ackedMessageIds as $messageId) {
83 83
 			$hexMessageIds[] = bin2hex($messageId);
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStore.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@
 block discarded – undo
27 27
 	 * @return string|null
28 28
 	 */
29 29
 	public final function getPublicKey($threemaId) {
30
-		if(array_key_exists($threemaId, $this->cache)) {
30
+		if (array_key_exists($threemaId, $this->cache)) {
31 31
 			return $this->cache[$threemaId];
32 32
 		}
33 33
 
34 34
 		$publicKey = $this->findPublicKey($threemaId);
35
-		if(null !== $publicKey) {
35
+		if (null !== $publicKey) {
36 36
 			$this->cache[$threemaId] = $publicKey;
37 37
 		}
38 38
 		return $publicKey;
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStores/File.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @throws Exception if the file does not exist or not writable
26 26
 	 */
27 27
 	public function __construct($file) {
28
-		if(false === is_writable($file)) {
28
+		if (false === is_writable($file)) {
29 29
 			throw new Exception('file '.$file.' does not exist or is not writable');
30 30
 		}
31 31
 		$this->file = $file;
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	function findPublicKey($threemaId) {
41 41
 		$storeHandle = fopen($this->file, 'r');
42
-		if(false === $storeHandle) {
42
+		if (false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44 44
 		}
45 45
 		else {
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 			$publicKey = null;
48 48
 			while (!feof($storeHandle)) {
49 49
 				$buffer = fgets($storeHandle, 4096);
50
-				if(substr($buffer, 0, 8) == $threemaId) {
50
+				if (substr($buffer, 0, 8) == $threemaId) {
51 51
 					$publicKey = str_replace("\n", '', substr($buffer, 8));
52 52
 					continue;
53 53
 				}
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStores/PhpFile.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
43 43
 	public function __construct($file)
44 44
 	{
45 45
 		if (false === is_writable($file)) {
46
-			throw new Exception('file ' . $file . ' does not exist or is not writable');
46
+			throw new Exception('file '.$file.' does not exist or is not writable');
47 47
 		}
48 48
 		if (pathinfo($file, PATHINFO_EXTENSION) != 'php') {
49
-			throw new Exception('file ' . $file . ' is not a valid PHP file');
49
+			throw new Exception('file '.$file.' is not a valid PHP file');
50 50
 		}
51 51
 		$this->file = $file;
52 52
 	}
@@ -104,12 +104,12 @@  discard block
 block discarded – undo
104 104
 
105 105
 		//add key
106 106
 		$this->keystore[$threemaId] = $publicKey;
107
-		$content = '$keystore[\'' . $threemaId . '\'] = \'' . $publicKey . '\';' . PHP_EOL;
107
+		$content = '$keystore[\''.$threemaId.'\'] = \''.$publicKey.'\';'.PHP_EOL;
108 108
 
109 109
 		//write content
110 110
 		$fileadd = file_put_contents($this->file, $content, FILE_APPEND);
111 111
 		if (!$fileadd) {
112
-			throw new Exception('could not write to file ' . $this->file);
112
+			throw new Exception('could not write to file '.$this->file);
113 113
 		}
114 114
 
115 115
 		return true;
@@ -137,28 +137,28 @@  discard block
 block discarded – undo
137 137
 
138 138
 			//check for success
139 139
 			if (null === $fileHandle) {
140
-				throw new Exception('could not open file ' . $this->file);
140
+				throw new Exception('could not open file '.$this->file);
141 141
 			}
142 142
 		}
143 143
 
144 144
 		//create content
145
-		$content = $this->fileBlocker . PHP_EOL;
145
+		$content = $this->fileBlocker.PHP_EOL;
146 146
 		$content .= PHP_EOL;
147
-		$content .= '//Threema MsgApi phpfile keystore' . PHP_EOL;
148
-		$content .= '//DO NOT EDIT THIS FILE!' . PHP_EOL;
147
+		$content .= '//Threema MsgApi phpfile keystore'.PHP_EOL;
148
+		$content .= '//DO NOT EDIT THIS FILE!'.PHP_EOL;
149 149
 		$content .= PHP_EOL;
150 150
 
151 151
 		//write file
152 152
 		$fwrite = fwrite($fileHandle, $content);
153 153
 		if (!$fwrite) {
154
-			throw new Exception('could not write to file ' . $this->file);
154
+			throw new Exception('could not write to file '.$this->file);
155 155
 		}
156 156
 
157 157
 		//close file if necessary
158 158
 		if ($fileopened) {
159 159
 			$fclose = fclose($fileHandle);
160 160
 			if (!$fclose) {
161
-				throw new Exception('error while processing file ' . $this->file);
161
+				throw new Exception('error while processing file '.$this->file);
162 162
 			}
163 163
 		}
164 164
 		return true;
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	 * @return PhpFile
171 171
 	 */
172 172
 	public static function create($path) {
173
-		if(false === file_exists($path)) {
173
+		if (false === file_exists($path)) {
174 174
 			//touch
175 175
 			touch($path);
176 176
 		}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Receiver.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 * @throws \InvalidArgumentException
74 74
 	 */
75 75
 	public function getParams() {
76
-		switch($this->type) {
76
+		switch ($this->type) {
77 77
 			case self::TYPE_ID:
78 78
 				$to = $this->type;
79 79
 				$this->value = strtoupper(trim($this->value));
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tests/CryptToolTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
 			$this->assertNotNull($message);
58 58
 			$this->assertTrue($message instanceof TextMessage);
59
-			if($message instanceof TextMessage) {
59
+			if ($message instanceof TextMessage) {
60 60
 				$this->assertEquals($message->getText(), 'Dies ist eine Testnachricht. äöü');
61 61
 			}
62 62
 		});
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
 
94 94
 	public function testDerivePublicKey() {
95
-		$this->doTest(function(CryptTool $cryptTool, $prefix){
95
+		$this->doTest(function(CryptTool $cryptTool, $prefix) {
96 96
 			$publicKey = $cryptTool->derivePublicKey(hex2bin(Common::getPrivateKey(Constants::myPrivateKey)));
97 97
 			$myPublicKey = hex2bin(Common::getPublicKey(Constants::myPublicKey));
98 98
 
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
 		});
121 121
 	}
122 122
 	private function doTest(\Closure $c) {
123
-		foreach(array(
123
+		foreach (array(
124 124
 					'Salt' => CryptTool::createInstance(CryptTool::TYPE_SALT),
125 125
 					'Sodium' => CryptTool::createInstance(CryptTool::TYPE_SODIUM)
126 126
 				) as $key => $instance) {
127 127
 
128
-			if($instance === null) {
128
+			if ($instance === null) {
129 129
 				echo $key.": could not instance crypt tool\n";
130 130
 				break;
131 131
 			}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSalt.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	 * @return null|string
49 49
 	 */
50 50
 	protected function openBox($box, $recipientPrivateKey, $senderPublicKey, $nonce) {
51
-		$boxPad = str_repeat("\x00", 16) . $box;
51
+		$boxPad = str_repeat("\x00", 16).$box;
52 52
 		try {
53 53
 			$data = Salt::box_open($boxPad, $recipientPrivateKey, $senderPublicKey, $nonce);
54 54
 		} catch (\SaltException $e) {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @return string as binary
72 72
 	 */
73 73
 	protected function openSecretBox($box, $nonce, $key) {
74
-		$boxPad = str_repeat("\x00", 16) . $box;
74
+		$boxPad = str_repeat("\x00", 16).$box;
75 75
 		$data = Salt::secretbox_open($boxPad, $nonce, $key);
76 76
 
77 77
 		if ($data) {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 			Salt::decodeInput($nonce),
131 131
 			$key);
132 132
 
133
-		if($data === false) {
133
+		if ($data === false) {
134 134
 			throw new Exception('encryption failed');
135 135
 		}
136 136
 
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
152 152
 	 * @throws Exception
153 153
 	 */
154 154
 	public function validate() {
155
-		if(false === $this->isSupported()) {
155
+		if (false === $this->isSupported()) {
156 156
 			throw new Exception('SALT implementation not supported');
157 157
 		}
158 158
 
159
-		if(PHP_INT_SIZE < 8) {
159
+		if (PHP_INT_SIZE < 8) {
160 160
 			throw new Exception('Pure PHP Crypto implementation requires 64Bit PHP. Please install the libsodium PHP extension.');
161 161
 		}
162 162
 		return true;
Please login to merge, or discard this patch.