rugk / threema-msgapi-sdk-php

source/Threema/MsgApi/Tests/CryptToolTest.php

Spacing +10 added lines, -10 removed lines

@@ -56,7 +56,7 @@ 
 
 			$this->assertNotNull($message);
 			$this->assertTrue($message instanceof TextMessage);
-			if($message instanceof TextMessage) {
+			if ($message instanceof TextMessage) {
 				$this->assertEquals($message->getText(), 'Dies ist eine Testnachricht. äöü');
 			}
 		});
@@ -92,7 +92,7 @@ 
 
 
 	public function testDerivePublicKey() {
-		$this->doTest(function(CryptTool $cryptTool, $prefix){
+		$this->doTest(function(CryptTool $cryptTool, $prefix) {
 			$publicKey = $cryptTool->derivePublicKey($cryptTool->hex2bin(Common::getPrivateKey(Constants::myPrivateKey)));
 			$myPublicKey = $cryptTool->hex2bin(Common::getPublicKey(Constants::myPublicKey));
 
@@ -165,15 +165,15 @@ 
 
 				// test different strings when comparing and get time needed
 				$result = [];
-				foreach(array(
-					'length' => [$string1, $string1 . 'a'],
+				foreach (array(
+					'length' => [$string1, $string1.'a'],
 					'diff' => [$string1, $string2],
 					'same' => [$string1, $string1]
 				) as $testName => $strings) {
 					$timeStart = microtime(true);
 					$comparisonResult = $cryptTool->stringCompare($strings[0], $strings[1]);
 					$timeEnd = microtime(true);
-					$timeElapsed = $timeEnd - $timeStart;
+					$timeElapsed = $timeEnd-$timeStart;
 
 					// echo $prefix.': '.$humanDescr[$testName].': '.$timeElapsed.'; result: '.$comparisonResult.PHP_EOL;
 					$result[$testName] = [$timeElapsed, $comparisonResult];
@@ -188,8 +188,8 @@ 
 
 				// check timings
 				echo 'Timing test results with '.$prefix.':'.PHP_EOL;
-				$timingRatio = $result['diff'][0] / $result['same'][0];
-				$absoluteDifference = abs($result['diff'][0] - $result['same'][0]);
+				$timingRatio = $result['diff'][0]/$result['same'][0];
+				$absoluteDifference = abs($result['diff'][0]-$result['same'][0]);
 				echo 'timing ratio: '.$timingRatio.PHP_EOL;
 				echo 'absolute difference: '.$absoluteDifference.PHP_EOL;
 
@@ -208,7 +208,7 @@ 
 	 */
 	public function testRemoveVar() {
 		$this->doTest(function(CryptTool $cryptTool, $prefix) {
-			foreach(array(
+			foreach (array(
 						'hex' => Constants::myPrivateKeyExtract,
 						'bin' => $cryptTool->hex2bin(Constants::myPrivateKeyExtract)
 					) as $key => $testVar) {
@@ -222,12 +222,12 @@ 
 	}
 
 	private function doTest(\Closure $c) {
-		foreach(array(
+		foreach (array(
 					'Salt' => CryptTool::createInstance(CryptTool::TYPE_SALT),
 					'Sodium' => CryptTool::createInstance(CryptTool::TYPE_SODIUM)
 				) as $key => $instance) {
 
-			if($instance === null) {
+			if ($instance === null) {
 				echo $key.": could not instance crypt tool\n";
 				break;
 			}

source/Threema/MsgApi/Connection.php

Spacing +6 added lines, -6 removed lines

@@ -202,12 +202,12 @@ 
 			}
 		}
 		if ($tlsCipher = $this->setting->getTlsOption(ConnectionSettings::tlsOptionCipher, null)) {
-			if(true === is_string($tlsCipher)) {
+			if (true === is_string($tlsCipher)) {
 				$options[CURLOPT_SSL_CIPHER_LIST] = $tlsCipher;
 			}
 		}
 		if ($pinnedKey = $this->setting->getTlsOption(ConnectionSettings::tlsOptionPinnedKey, Constants::DEFAULT_PINNED_KEY)) {
-			if(true === is_string($pinnedKey)) {
+			if (true === is_string($pinnedKey)) {
 				$options[CURLOPT_PINNEDPUBLICKEY] = $pinnedKey;
 			}
 		}
@@ -239,7 +239,7 @@ 
 		return $this->call($command->getPath(),
 			$this->createDefaultOptions($progress),
 			$params,
-			function ($httpCode, $response) use ($command) {
+			function($httpCode, $response) use ($command) {
 				return $command->parseResult($httpCode, $response);
 			});
 	}
@@ -257,7 +257,7 @@ 
 		$options[CURLOPT_HTTPHEADER] = array(
 			'Content-Type: application/x-www-form-urlencoded');
 
-		return $this->call($command->getPath(), $options, null, function ($httpCode, $response) use ($command) {
+		return $this->call($command->getPath(), $options, null, function($httpCode, $response) use ($command) {
 			return $command->parseResult($httpCode, $response);
 		});
 	}
@@ -277,7 +277,7 @@ 
 			'blob' => $command->getData()
 		);
 
-		return $this->call($command->getPath(), $options, $params, function ($httpCode, $response) use ($command) {
+		return $this->call($command->getPath(), $options, $params, function($httpCode, $response) use ($command) {
 			return $command->parseResult($httpCode, $response);
 		});
 	}
@@ -304,7 +304,7 @@ 
 
 		$response = curl_exec($session);
 		if (false === $response) {
-			throw new Exception($path . ' ' . curl_error($session));
+			throw new Exception($path.' '.curl_error($session));
 		}
 
 		$httpCode = curl_getinfo($session, CURLINFO_HTTP_CODE);

source/Threema/MsgApi/ConnectionSettings.php

Spacing +5 added lines, -5 removed lines

@@ -49,20 +49,20 @@
 		$this->host = $host;
 
 		// TLS options
-		if(null !== $tlsOptions && is_array($tlsOptions)) {
-			if(true === array_key_exists(self::tlsOptionForceHttps, $tlsOptions)) {
+		if (null !== $tlsOptions && is_array($tlsOptions)) {
+			if (true === array_key_exists(self::tlsOptionForceHttps, $tlsOptions)) {
 				$this->tlsOptions[self::tlsOptionForceHttps] = $tlsOptions[self::tlsOptionForceHttps] === true;
 			}
 
-			if(true === array_key_exists(self::tlsOptionVersion, $tlsOptions)) {
+			if (true === array_key_exists(self::tlsOptionVersion, $tlsOptions)) {
 				$this->tlsOptions[self::tlsOptionVersion] = $tlsOptions[self::tlsOptionVersion];
 			}
 
-			if(true === array_key_exists(self::tlsOptionCipher, $tlsOptions)) {
+			if (true === array_key_exists(self::tlsOptionCipher, $tlsOptions)) {
 				$this->tlsOptions[self::tlsOptionCipher] = $tlsOptions[self::tlsOptionCipher];
 			}
 
-			if(true === array_key_exists(self::tlsOptionPinnedKey, $tlsOptions)) {
+			if (true === array_key_exists(self::tlsOptionPinnedKey, $tlsOptions)) {
 				$this->tlsOptions[self::tlsOptionPinnedKey] = $tlsOptions[self::tlsOptionPinnedKey];
 			}
 		}

source/bootstrap.php

Spacing +10 added lines, -10 removed lines

@@ -2,11 +2,11 @@ 
 require_once("Salt/autoload.php");
 
 //define possibly missing constants
-defined('CURL_SSLVERSION_DEFAULT')  || define('CURL_SSLVERSION_DEFAULT', 0);
-defined('CURL_SSLVERSION_TLSv1')    || define('CURL_SSLVERSION_TLSv1', 1);
-defined('CURL_SSLVERSION_TLSv1_1')  || define('CURL_SSLVERSION_TLSv1_1', 5);
-defined('CURL_SSLVERSION_TLSv1_2')  || define('CURL_SSLVERSION_TLSv1_2', 6);
-defined('CURLOPT_PINNEDPUBLICKEY')  || define('CURLOPT_PINNEDPUBLICKEY', 10230);
+defined('CURL_SSLVERSION_DEFAULT') || define('CURL_SSLVERSION_DEFAULT', 0);
+defined('CURL_SSLVERSION_TLSv1') || define('CURL_SSLVERSION_TLSv1', 1);
+defined('CURL_SSLVERSION_TLSv1_1') || define('CURL_SSLVERSION_TLSv1_1', 5);
+defined('CURL_SSLVERSION_TLSv1_2') || define('CURL_SSLVERSION_TLSv1_2', 6);
+defined('CURLOPT_PINNEDPUBLICKEY') || define('CURLOPT_PINNEDPUBLICKEY', 10230);
 
 //define autoloader
 $d = dirname(__FILE__);
@@ -16,12 +16,12 @@ 
 	$fileName  = '';
 	if ($lastNsPos = strrpos($className, '\\')) {
 		$namespace = substr($className, 0, $lastNsPos);
-		$className = substr($className, $lastNsPos + 1);
-		$fileName  = str_replace('\\', DIRECTORY_SEPARATOR, $namespace) . DIRECTORY_SEPARATOR;
+		$className = substr($className, $lastNsPos+1);
+		$fileName  = str_replace('\\', DIRECTORY_SEPARATOR, $namespace).DIRECTORY_SEPARATOR;
 	}
-	$fileName .= str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
+	$fileName .= str_replace('_', DIRECTORY_SEPARATOR, $className).'.php';
 
-	if(true === file_exists( $d.'/'.$fileName)) {
+	if (true === file_exists($d.'/'.$fileName)) {
 		require $d.'/'.$fileName;
 	}
 });
@@ -30,7 +30,7 @@ 
 define('MSGAPI_SDK_VERSION', $sdkVersion);
 $cryptTool = Threema\MsgApi\Tools\CryptTool::getInstance();
 
-if(null === $cryptTool) {
+if (null === $cryptTool) {
 	throw new \Threema\Core\Exception("no supported crypt-tool");
 }