Completed
Push — master ( 2a7bb1...68cb6f )
by rugk
02:50
created
source/Threema/MsgApi/PublicKeyStore.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@
 block discarded – undo
27 27
 	 * @return string|null
28 28
 	 */
29 29
 	public final function getPublicKey($threemaId) {
30
-		if(array_key_exists($threemaId, $this->cache)) {
30
+		if (array_key_exists($threemaId, $this->cache)) {
31 31
 			return $this->cache[$threemaId];
32 32
 		}
33 33
 
34 34
 		$publicKey = $this->findPublicKey($threemaId);
35
-		if(null !== $publicKey) {
35
+		if (null !== $publicKey) {
36 36
 			$this->cache[$threemaId] = $publicKey;
37 37
 		}
38 38
 		return $publicKey;
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStores/File.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@
 block discarded – undo
41 41
 		$storeHandle = fopen($this->file, 'r');
42 42
 		if(false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44
-		}
45
-		else {
44
+		} else {
46 45
 			$threemaId = strtoupper($threemaId);
47 46
 			$publicKey = null;
48 47
 			while (!feof($storeHandle)) {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @throws Exception if the file does not exist or not writable
26 26
 	 */
27 27
 	public function __construct($file) {
28
-		if(false === is_writable($file)) {
28
+		if (false === is_writable($file)) {
29 29
 			throw new Exception('file '.$file.' does not exist or is not writable');
30 30
 		}
31 31
 		$this->file = $file;
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	function findPublicKey($threemaId) {
41 41
 		$storeHandle = fopen($this->file, 'r');
42
-		if(false === $storeHandle) {
42
+		if (false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44 44
 		}
45 45
 		else {
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 			$publicKey = null;
48 48
 			while (!feof($storeHandle)) {
49 49
 				$buffer = fgets($storeHandle, 4096);
50
-				if(substr($buffer, 0, 8) == $threemaId) {
50
+				if (substr($buffer, 0, 8) == $threemaId) {
51 51
 					$publicKey = str_replace("\n", '', substr($buffer, 8));
52 52
 					continue;
53 53
 				}
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 * @return File
75 75
 	 */
76 76
 	public static function create($path) {
77
-		if(false === file_exists($path)) {
77
+		if (false === file_exists($path)) {
78 78
 			//touch
79 79
 			touch($path);
80 80
 		}
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStores/PhpFile.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
43 43
 	public function __construct($file)
44 44
 	{
45 45
 		if (false === is_writable($file)) {
46
-			throw new Exception('file ' . $file . ' does not exist or is not writable');
46
+			throw new Exception('file '.$file.' does not exist or is not writable');
47 47
 		}
48 48
 		if (pathinfo($file, PATHINFO_EXTENSION) != 'php') {
49
-			throw new Exception('file ' . $file . ' is not a valid PHP file');
49
+			throw new Exception('file '.$file.' is not a valid PHP file');
50 50
 		}
51 51
 		$this->file = $file;
52 52
 	}
@@ -104,12 +104,12 @@  discard block
 block discarded – undo
104 104
 
105 105
 		//add key
106 106
 		$this->keystore[$threemaId] = $publicKey;
107
-		$content = '$keystore[\'' . $threemaId . '\'] = \'' . $publicKey . '\';' . PHP_EOL;
107
+		$content = '$keystore[\''.$threemaId.'\'] = \''.$publicKey.'\';'.PHP_EOL;
108 108
 
109 109
 		//write content
110 110
 		$fileadd = file_put_contents($this->file, $content, FILE_APPEND);
111 111
 		if (!$fileadd) {
112
-			throw new Exception('could not write to file ' . $this->file);
112
+			throw new Exception('could not write to file '.$this->file);
113 113
 		}
114 114
 
115 115
 		return true;
@@ -137,28 +137,28 @@  discard block
 block discarded – undo
137 137
 
138 138
 			//check for success
139 139
 			if (null === $fileHandle) {
140
-				throw new Exception('could not open file ' . $this->file);
140
+				throw new Exception('could not open file '.$this->file);
141 141
 			}
142 142
 		}
143 143
 
144 144
 		//create content
145
-		$content = $this->fileBlocker . PHP_EOL;
145
+		$content = $this->fileBlocker.PHP_EOL;
146 146
 		$content .= PHP_EOL;
147
-		$content .= '//Threema MsgApi phpfile keystore' . PHP_EOL;
148
-		$content .= '//DO NOT EDIT THIS FILE!' . PHP_EOL;
147
+		$content .= '//Threema MsgApi phpfile keystore'.PHP_EOL;
148
+		$content .= '//DO NOT EDIT THIS FILE!'.PHP_EOL;
149 149
 		$content .= PHP_EOL;
150 150
 
151 151
 		//write file
152 152
 		$fwrite = fwrite($fileHandle, $content);
153 153
 		if (!$fwrite) {
154
-			throw new Exception('could not write to file ' . $this->file);
154
+			throw new Exception('could not write to file '.$this->file);
155 155
 		}
156 156
 
157 157
 		//close file if necessary
158 158
 		if ($fileopened) {
159 159
 			$fclose = fclose($fileHandle);
160 160
 			if (!$fclose) {
161
-				throw new Exception('error while processing file ' . $this->file);
161
+				throw new Exception('error while processing file '.$this->file);
162 162
 			}
163 163
 		}
164 164
 		return true;
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	 * @return PhpFile
171 171
 	 */
172 172
 	public static function create($path) {
173
-		if(false === file_exists($path)) {
173
+		if (false === file_exists($path)) {
174 174
 			//touch
175 175
 			touch($path);
176 176
 		}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Receiver.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 * @throws \InvalidArgumentException
74 74
 	 */
75 75
 	public function getParams() {
76
-		switch($this->type) {
76
+		switch ($this->type) {
77 77
 			case self::TYPE_ID:
78 78
 				$to = $this->type;
79 79
 				$this->value = strtoupper(trim($this->value));
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSalt.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	 * @return null|string
49 49
 	 */
50 50
 	protected function openBox($box, $recipientPrivateKey, $senderPublicKey, $nonce) {
51
-		$boxPad = str_repeat("\x00", 16) . $box;
51
+		$boxPad = str_repeat("\x00", 16).$box;
52 52
 		try {
53 53
 			$data = Salt::box_open($boxPad, $recipientPrivateKey, $senderPublicKey, $nonce);
54 54
 		} catch (\SaltException $e) {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @return string as binary
72 72
 	 */
73 73
 	protected function openSecretBox($box, $nonce, $key) {
74
-		$boxPad = str_repeat("\x00", 16) . $box;
74
+		$boxPad = str_repeat("\x00", 16).$box;
75 75
 		$data = Salt::secretbox_open($boxPad, $nonce, $key);
76 76
 
77 77
 		if ($data) {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 			Salt::decodeInput($nonce),
131 131
 			$key);
132 132
 
133
-		if($data === false) {
133
+		if ($data === false) {
134 134
 			throw new Exception('encryption failed');
135 135
 		}
136 136
 
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
152 152
 	 * @throws Exception
153 153
 	 */
154 154
 	public function validate() {
155
-		if(false === $this->isSupported()) {
155
+		if (false === $this->isSupported()) {
156 156
 			throw new Exception('SALT implementation not supported');
157 157
 		}
158 158
 
159
-		if(PHP_INT_SIZE < 8) {
159
+		if (PHP_INT_SIZE < 8) {
160 160
 			throw new Exception('Pure PHP Crypto implementation requires 64Bit PHP. Please install the libsodium PHP extension.');
161 161
 		}
162 162
 		return true;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSodiumDep.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	 * @throws Exception
125 125
 	 */
126 126
 	public function validate() {
127
-		if(false === $this->isSupported()) {
127
+		if (false === $this->isSupported()) {
128 128
 			throw new Exception('Sodium implementation not supported');
129 129
 		}
130 130
 		return true;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/FileAnalysisTool.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -14,12 +14,12 @@  discard block
 block discarded – undo
14 14
 	 */
15 15
 	public static function analyse($file) {
16 16
 		//check if file exists
17
-		if(false === file_exists($file)) {
17
+		if (false === file_exists($file)) {
18 18
 			return null;
19 19
 		}
20 20
 
21 21
 		//is not a file
22
-		if(false === is_file($file)) {
22
+		if (false === is_file($file)) {
23 23
 			return null;
24 24
 		}
25 25
 
@@ -28,16 +28,16 @@  discard block
 block discarded – undo
28 28
 
29 29
 		$mimeType = null;
30 30
 		//mime type getter
31
-		if(function_exists('finfo_open')) {
31
+		if (function_exists('finfo_open')) {
32 32
 			$finfo = finfo_open(FILEINFO_MIME_TYPE);
33 33
 			$mimeType = finfo_file($finfo, $file);
34 34
 		}
35
-		else if(function_exists('mime_content_type')) {
35
+		else if (function_exists('mime_content_type')) {
36 36
 			$mimeType = mime_content_type($file);
37 37
 		}
38 38
 
39 39
 		//default mime type
40
-		if(strlen($mimeType) == 0) {
40
+		if (strlen($mimeType) == 0) {
41 41
 			//default mime type
42 42
 			$mimeType = 'application/octet-stream';
43 43
 		}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,8 +31,7 @@
 block discarded – undo
31 31
 		if(function_exists('finfo_open')) {
32 32
 			$finfo = finfo_open(FILEINFO_MIME_TYPE);
33 33
 			$mimeType = finfo_file($finfo, $file);
34
-		}
35
-		else if(function_exists('mime_content_type')) {
34
+		} else if(function_exists('mime_content_type')) {
36 35
 			$mimeType = mime_content_type($file);
37 36
 		}
38 37
 
Please login to merge, or discard this patch.
threema-msgapi-tool.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
 //disallow using the cli tool in a web project
9 9
 if ('cli' !== php_sapi_name() || null === $argv) {
10 10
 	//file not called from the cli
11
-	die('please run ' . basename(__FILE__) . ' only in a cli. '.
11
+	die('please run '.basename(__FILE__).' only in a cli. '.
12 12
 		'To use the threema msgapi sdk in your web project, include the source/bootstrap.php or the threema_msgapi.phar file.');
13 13
 }
14 14
 try {
@@ -20,6 +20,6 @@  discard block
 block discarded – undo
20 20
 		Threema\MsgApi\PublicKeyStores\PhpFile::create('keystore.php'));
21 21
 	$tool->run();
22 22
 } catch (\Threema\Core\Exception $exception) {
23
-	echo "ERROR: " . $exception->getMessage() . "\n";
23
+	echo "ERROR: ".$exception->getMessage()."\n";
24 24
 	die();
25 25
 }
Please login to merge, or discard this patch.
source/Threema/Console/Command/Credits.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 		$helper = new E2EHelper($privateKey, $connector);
52 52
 		$result = $helper->sendImageMessage($threemaId, $path);
53 53
 
54
-		if($result->isSuccess()) {
54
+		if ($result->isSuccess()) {
55 55
 			Common::l('Message ID: '.$result->getMessageId());
56 56
 		}
57 57
 		else {
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@
 block discarded – undo
41 41
 		$storeHandle = fopen($this->file, 'r');
42 42
 		if(false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44
-		}
45
-		else {
44
+		} else {
46 45
 			$threemaId = strtoupper($threemaId);
47 46
 			$publicKey = null;
48 47
 			while (!feof($storeHandle)) {
Please login to merge, or discard this patch.