View GitHub Repository threema-msgapi-sdk-php

Schedule Inspection
Subscribe
Completed
Pull Request — master (#28)
by rugk
03:18
created
Status
Category
Toggle Patches
source/Threema/Console/Command/Base.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -48,7 +48,7 @@  discard block
 
 block discarded – undo
48 48 
 	 * @param string $subject
49 49 
 	 * @param string[] $requiredArguments
50 50 
 	 * @param string $description
51 
-	 * @param array $optionalArguments
51 
+	 * @param string[] $optionalArguments
52 52 
 	 */
53 53 
 	public function __construct($subject, array $requiredArguments, $description, array $optionalArguments = array()) {
54 54 
 		$this->subject = $subject;
 
@@ -115,7 +115,7 @@  discard block
 
 block discarded – undo
115 115 
 	 * return a valid file path
116 116 
 	 *
117 117 
 	 * @param string $pos
118 
-	 * @return null|string
118 
+	 * @return string
119 119 
 	 * @throws \Threema\Core\Exception
120 120 
 	 */
121 121 
 	public function getArgumentFile($pos) {
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/Core/AssocArray.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,8 +36,8 @@
 
 block discarded – undo
36 36 
 	}
37 37
38 38 
 	/**
39 
-	 * @param $string
40 
-	 * @param array|null $requiredKeys
39 
+	 * @param string $string
40 
+	 * @param string[] $requiredKeys
41 41 
 	 * @return AssocArray
42 42 
 	 * @throws Exception
43 43 
 	 */
Please login to merge, or discard this patch.
source/Threema/MsgApi/Commands/DownloadFile.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -40,7 +40,7 @@
 
 block discarded – undo
40 40 
 	/**
41 41 
 	 * @param int $httpCode
42 42 
 	 * @param object $res
43 
-	 * @return UploadFileResult
43 
+	 * @return DownloadFileResult
44 44 
 	 */
45 45 
 	function parseResult($httpCode, $res){
46 46 
 		return new DownloadFileResult($httpCode, $res);
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Helpers/ReceiveMessageResult.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
 	}
74 74
75 75 
 	/**
76 
-	 * @return \string[]
76 
+	 * @return string[]
77 77 
 	 */
78 78 
 	public function getErrors() {
79 79 
 		return $this->errors;
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
 	}
88 88
89 89 
 	/**
90 
-	 * @return \string[]
90 
+	 * @return string[]
91 91 
 	 */
92 92 
 	public function getFiles() {
93 93 
 		return $this->files;
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Messages/DeliveryReceipt.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -65,7 +65,7 @@
 
 block discarded – undo
65 65
66 66 
 	/**
67 67 
 	 * Get the acknowledged message ids
68 
-	 * @return array
68 
+	 * @return string[]
69 69 
 	 */
70 70 
 	public function getAckedMessageIds() {
71 71 
 		return $this->ackedMessageIds;
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/FileAnalysisTool.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/Console/Command/Capability.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/Console/Command/Credits.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
source/Threema/Console/Command/Decrypt.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,8 +1,8 @@
 
 block discarded – undo
1 1 
 <?php
2 2 
 /**
3 
- * @author Threema GmbH
4 
- * @copyright Copyright (c) 2015 Threema GmbH
5 
- */
3 
+	 * @author Threema GmbH
4 
+	 * @copyright Copyright (c) 2015 Threema GmbH
5 
+	 */
6 6
7 7
8 8 
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.