Completed
Pull Request — official (#17)
by rugk
02:34
created
source/Threema/MsgApi/PublicKeyStores/File.php 3 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 namespace Threema\MsgApi\PublicKeyStores;
8 8
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @throws Exception if the file does not exist or not writable
26 26
 	 */
27 27
 	public function __construct($file) {
28
-		if(false === is_writable($file)) {
28
+		if (false === is_writable($file)) {
29 29
 			throw new Exception('file '.$file.' does not exist or is not writable');
30 30
 		}
31 31
 		$this->file = $file;
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	function findPublicKey($threemaId) {
41 41
 		$storeHandle = fopen($this->file, 'r');
42
-		if(false === $storeHandle) {
42
+		if (false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44 44
 		}
45 45
 		else {
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 			$publicKey = null;
48 48
 			while (!feof($storeHandle)) {
49 49
 				$buffer = fgets($storeHandle, 4096);
50
-				if(substr($buffer, 0, 8) == $threemaId) {
50
+				if (substr($buffer, 0, 8) == $threemaId) {
51 51
 					$publicKey = str_replace("\n", '', substr($buffer, 8));
52 52
 					continue;
53 53
 				}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@
 block discarded – undo
41 41
 		$storeHandle = fopen($this->file, 'r');
42 42
 		if(false === $storeHandle) {
43 43
 			throw new Exception('could not open file '.$this->file);
44
-		}
45
-		else {
44
+		} else {
46 45
 			$threemaId = strtoupper($threemaId);
47 46
 			$publicKey = null;
48 47
 			while (!feof($storeHandle)) {
Please login to merge, or discard this patch.
source/Threema/MsgApi/PublicKeyStores/PhpFile.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi\PublicKeyStores;
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
43 43
 	public function __construct($file)
44 44
 	{
45 45
 		if (false === is_writable($file)) {
46
-			throw new Exception('file ' . $file . ' does not exist or is not writable');
46
+			throw new Exception('file '.$file.' does not exist or is not writable');
47 47
 		}
48 48
 		if (pathinfo($file, PATHINFO_EXTENSION) != 'php') {
49
-			throw new Exception('file ' . $file . ' is not a valid PHP file');
49
+			throw new Exception('file '.$file.' is not a valid PHP file');
50 50
 		}
51 51
 		$this->file = $file;
52 52
 	}
@@ -104,12 +104,12 @@  discard block
 block discarded – undo
104 104
 
105 105
 		//add key
106 106
 		$this->keystore[$threemaId] = $publicKey;
107
-		$content = '$keystore[\'' . $threemaId . '\'] = \'' . $publicKey . '\';' . PHP_EOL;
107
+		$content = '$keystore[\''.$threemaId.'\'] = \''.$publicKey.'\';'.PHP_EOL;
108 108
 
109 109
 		//write content
110 110
 		$fileadd = file_put_contents($this->file, $content, FILE_APPEND);
111 111
 		if (!$fileadd) {
112
-			throw new Exception('could not write to file ' . $this->file);
112
+			throw new Exception('could not write to file '.$this->file);
113 113
 		}
114 114
 
115 115
 		return true;
@@ -137,28 +137,28 @@  discard block
 block discarded – undo
137 137
 
138 138
 			//check for success
139 139
 			if (null === $fileHandle) {
140
-				throw new Exception('could not open file ' . $this->file);
140
+				throw new Exception('could not open file '.$this->file);
141 141
 			}
142 142
 		}
143 143
 
144 144
 		//create content
145
-		$content = $this->fileBlocker . PHP_EOL;
145
+		$content = $this->fileBlocker.PHP_EOL;
146 146
 		$content .= PHP_EOL;
147
-		$content .= '//Threema MsgApi phpfile keystore' . PHP_EOL;
148
-		$content .= '//DO NOT EDIT THIS FILE!' . PHP_EOL;
147
+		$content .= '//Threema MsgApi phpfile keystore'.PHP_EOL;
148
+		$content .= '//DO NOT EDIT THIS FILE!'.PHP_EOL;
149 149
 		$content .= PHP_EOL;
150 150
 
151 151
 		//write file
152 152
 		$fwrite = fwrite($fileHandle, $content);
153 153
 		if (!$fwrite) {
154
-			throw new Exception('could not write to file ' . $this->file);
154
+			throw new Exception('could not write to file '.$this->file);
155 155
 		}
156 156
 
157 157
 		//close file if necessary
158 158
 		if ($fileopened) {
159 159
 			$fclose = fclose($fileHandle);
160 160
 			if (!$fclose) {
161
-				throw new Exception('error while processing file ' . $this->file);
161
+				throw new Exception('error while processing file '.$this->file);
162 162
 			}
163 163
 		}
164 164
 		return true;
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	 * @return PhpFile
171 171
 	 */
172 172
 	public static function create($path) {
173
-		if(false === file_exists($path)) {
173
+		if (false === file_exists($path)) {
174 174
 			//touch
175 175
 			touch($path);
176 176
 		}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Receiver.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 * @throws \InvalidArgumentException
74 74
 	 */
75 75
 	public function getParams() {
76
-		switch($this->type) {
76
+		switch ($this->type) {
77 77
 			case self::TYPE_ID:
78 78
 				$to = $this->type;
79 79
 				$this->value = strtoupper(trim($this->value));
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tests/CommonTests.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tests/Constants.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi\Tests;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tests/CryptToolTest.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
 			$this->assertNotNull($message);
58 58
 			$this->assertTrue($message instanceof TextMessage);
59
-			if($message instanceof TextMessage) {
59
+			if ($message instanceof TextMessage) {
60 60
 				$this->assertEquals($message->getText(), 'Dies ist eine Testnachricht. äöü');
61 61
 			}
62 62
 		});
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
 
94 94
 	public function testDerivePublicKey() {
95
-		$this->doTest(function(CryptTool $cryptTool, $prefix){
95
+		$this->doTest(function(CryptTool $cryptTool, $prefix) {
96 96
 			$publicKey = $cryptTool->derivePublicKey(hex2bin(Common::getPrivateKey(Constants::myPrivateKey)));
97 97
 			$myPublicKey = hex2bin(Common::getPublicKey(Constants::myPublicKey));
98 98
 
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
 		});
121 121
 	}
122 122
 	private function doTest(\Closure $c) {
123
-		foreach(array(
123
+		foreach (array(
124 124
 					'Salt' => CryptTool::createInstance(CryptTool::TYPE_SALT),
125 125
 					'Sodium' => CryptTool::createInstance(CryptTool::TYPE_SODIUM)
126 126
 				) as $key => $instance) {
127 127
 
128
-			if($instance === null) {
128
+			if ($instance === null) {
129 129
 				echo $key.": could not instance crypt tool\n";
130 130
 				break;
131 131
 			}
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSalt.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	 * @return null|string
49 49
 	 */
50 50
 	protected function openBox($box, $recipientPrivateKey, $senderPublicKey, $nonce) {
51
-		$boxPad = str_repeat("\x00", 16) . $box;
51
+		$boxPad = str_repeat("\x00", 16).$box;
52 52
 		try {
53 53
 			$data = Salt::box_open($boxPad, $recipientPrivateKey, $senderPublicKey, $nonce);
54 54
 		} catch (\SaltException $e) {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @return string as binary
72 72
 	 */
73 73
 	protected function openSecretBox($box, $nonce, $key) {
74
-		$boxPad = str_repeat("\x00", 16) . $box;
74
+		$boxPad = str_repeat("\x00", 16).$box;
75 75
 		$data = Salt::secretbox_open($boxPad, $nonce, $key);
76 76
 
77 77
 		if ($data) {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 			Salt::decodeInput($nonce),
131 131
 			$key);
132 132
 
133
-		if($data === false) {
133
+		if ($data === false) {
134 134
 			throw new Exception('encryption failed');
135 135
 		}
136 136
 
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
152 152
 	 * @throws Exception
153 153
 	 */
154 154
 	public function validate() {
155
-		if(false === $this->isSupported()) {
155
+		if (false === $this->isSupported()) {
156 156
 			throw new Exception('SALT implementation not supported');
157 157
 		}
158 158
 
159
-		if(PHP_INT_SIZE < 8) {
159
+		if (PHP_INT_SIZE < 8) {
160 160
 			throw new Exception('Pure PHP Crypto implementation requires 64Bit PHP. Please install the libsodium PHP extension.');
161 161
 		}
162 162
 		return true;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSodium.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
 	 * @throws Exception
122 122
 	 */
123 123
 	public function validate() {
124
-		if(false === $this->isSupported()) {
124
+		if (false === $this->isSupported()) {
125 125
 			throw new Exception('Sodium implementation not supported');
126 126
 		}
127 127
 		return true;
Please login to merge, or discard this patch.
source/Threema/MsgApi/Tools/CryptToolSodiumDep.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Threema GmbH
4
- * @copyright Copyright (c) 2015 Threema GmbH
5
- */
3
+	 * @author Threema GmbH
4
+	 * @copyright Copyright (c) 2015 Threema GmbH
5
+	 */
6 6
 
7 7
 
8 8
 namespace Threema\MsgApi\Tools;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	 * @throws Exception
125 125
 	 */
126 126
 	public function validate() {
127
-		if(false === $this->isSupported()) {
127
+		if (false === $this->isSupported()) {
128 128
 			throw new Exception('Sodium implementation not supported');
129 129
 		}
130 130
 		return true;
Please login to merge, or discard this patch.