Elastica\Query\SpanOr

Complexity

Total Complexity

6

Size/Duplication

Total Lines	39
Duplicated Lines	43.59 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	13	4
A	addClause()	8	8	2

<?php
namespace Elastica\Query;

use Elastica\Exception\InvalidException;

/**
 * SpanOr query.
 *
 * @author Marek Hernik <marek.hernik@gmail.com>
 *
 * @link https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-span-term-query.html
 */
class SpanOr extends AbstractSpanQuery
{
    /**
     * Constructs a SpanOr query object.
     *
     * @param AbstractSpanQuery[] $clauses OPTIONAL
     */
    public function __construct($clauses = [])
    {
        if (!empty($clauses)) {

This code seems to be duplicated across your project.

            foreach ($clauses as $clause) {
                if (!is_subclass_of($clause, AbstractSpanQuery::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Elastica\Query\AbstractSpanQuery::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

                    throw new InvalidException(
                        'Invalid parameter. Has to be array or instance of Elastica\Query\SpanQuery'
                    );
                }
            }
        }
        $this->setParams(['clauses' => $clauses]);
    }

    /**
     * Add clause part to query.
     *
     * @param AbstractSpanQuery $clause
     *
     * @throws InvalidException If not valid query
     *
     * @return $this
     */
    public function addClause($clause)

This method seems to be duplicated in your project.

    {
        if (!is_subclass_of($clause, AbstractSpanQuery::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Elastica\Query\AbstractSpanQuery::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new InvalidException('Invalid parameter. Has to be array or instance of Elastica\Query\SpanQuery');
        }

        return $this->addParam('clauses', $clause);
    }
}