ScriptId::__construct() - Code Metrics - Inspection of "Finalize elasticsearch 5 migration (#1242)" - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96ab8a...466607 )

by Nicolas

created 2017-02-09 12:07 UTC

ScriptId::__construct() A

↳ Parent: ScriptId

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	6
Ratio	100 %

Importance

Changes

Metric	Value
dl	6
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	4

<?php
namespace Elastica\Script;

/**
 * Stored script referenced by ID.
 *
 * @author Tobias Schultze <http://tobion.de>
 * @author Martin Janser <[email protected]>
 *
 * @link https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting.html
 */
class ScriptId extends AbstractScript

{
    /**
     * @var string
     */
    private $_scriptId;

    /**
     * @param string      $scriptId   Script ID
     * @param array|null  $params
     * @param string|null $lang
     * @param string|null $documentId Document ID the script action should be performed on (only relevant in update context)
     */
    public function __construct($scriptId, array $params = null, $lang = null, $documentId = null)
    {
        parent::__construct($params, $lang, $documentId);

        $this->setScriptId($scriptId);
    }

    /**
     * @param string $scriptId
     *
     * @return $this
     */
    public function setScriptId($scriptId)
    {
        $this->_scriptId = $scriptId;

        return $this;
    }

    /**
     * @return string
     */
    public function getScriptId()
    {
        return $this->_scriptId;
    }

    /**
     * {@inheritdoc}
     */
    protected function getScriptTypeArray()
    {
        return ['id' => $this->_scriptId];
    }
}


1		<?php
2		namespace Elastica\Script;
3
4		/**
5		* Stored script referenced by ID.
6		*
7		* @author Tobias Schultze <http://tobion.de>
8		* @author Martin Janser <[email protected]>
9		*
10		* @link https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting.html
11		*/
12	View Code Duplication	class ScriptId extends AbstractScript
		0 ignored issues – show Duplication introduced 2017-02-03 16:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* @var string
16		*/
17		private $_scriptId;
18
19		/**
20		* @param string $scriptId Script ID
21		* @param array\|null $params
22		* @param string\|null $lang
23		* @param string\|null $documentId Document ID the script action should be performed on (only relevant in update context)
24		*/
25		public function __construct($scriptId, array $params = null, $lang = null, $documentId = null)
26		{
27		parent::__construct($params, $lang, $documentId);
28
29		$this->setScriptId($scriptId);
30		}
31
32		/**
33		* @param string $scriptId
34		*
35		* @return $this
36		*/
37		public function setScriptId($scriptId)
38		{
39		$this->_scriptId = $scriptId;
40
41		return $this;
42		}
43
44		/**
45		* @return string
46		*/
47		public function getScriptId()
48		{
49		return $this->_scriptId;
50		}
51
52		/**
53		* {@inheritdoc}
54		*/
55		protected function getScriptTypeArray()
56		{
57		return ['id' => $this->_scriptId];
58		}
59		}
60

ruflin / Elastica

Push — master ( 96ab8a...466607 )

ScriptId::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like