Elastica\Test\Aggregation\DateRangeTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	102
Duplicated Lines	23.53 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testSetTimezone()	0	15	1
A	testDateRangeAggregation()	7	18	4
A	testDateRangeSetFormat()	0	13	1
A	testDateRangeSetFormatAccordingToFormatTargetField()	0	20	2
A	_getIndexForTest()	17	17	1

<?php

namespace Elastica\Test\Aggregation;

use Elastica\Aggregation\DateRange;
use Elastica\Document;
use Elastica\Exception\ResponseException;
use Elastica\Index;
use Elastica\Mapping;
use Elastica\Query;

/**
 * @internal
 */
class DateRangeTest extends BaseAggregationTest
{
    /**
     * @group unit
     */
    public function testSetTimezone(): void
    {
        $agg = (new DateRange('date'))
            ->setTimezone('CET')
        ;

        $expected = [
            'date_range' => [
                'field' => 'date',
                'time_zone' => 'CET',
            ],
        ];

        $this->assertEquals($expected, $agg->toArray());
    }

    /**
     * @group functional
     */
    public function testDateRangeAggregation(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);

        $query = new Query();
        $query->addAggregation($agg);
        $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

        foreach ($results['buckets'] as $bucket) {

This code seems to be duplicated across your project.

            if (\array_key_exists('to', $bucket)) {
                $this->assertEquals(1, $bucket['doc_count']);
            } elseif (\array_key_exists('from', $bucket)) {
                $this->assertEquals(2, $bucket['doc_count']);
            }
        }
    }

    /**
     * @group functional
     */
    public function testDateRangeSetFormat(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);
        $agg->setFormat('epoch_millis');

        $query = new Query();
        $query->addAggregation($agg);
        $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

        $this->assertEquals('1390958535000', $results['buckets'][0]['to_as_string']);
    }

    /**
     * @group functional
     */
    public function testDateRangeSetFormatAccordingToFormatTargetField(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);
        $agg->setFormat('m-d-y');

        $query = new Query();
        $query->addAggregation($agg);

        try {
            $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

$results is not used, you could remove the assignment.

            $this->fail('Should throw exception to and from parameters in date_range aggregation are interpreted according of the target field');
        } catch (ResponseException $e) {
            $error = $e->getResponse()->getFullError();

            $this->assertSame('search_phase_execution_exception', $error['type']);
            $this->assertStringStartsWith('failed to parse date field', $error['root_cause'][0]['reason']);
        }
    }

    protected function _getIndexForTest(): Index

This method seems to be duplicated in your project.

    {
        $index = $this->_createIndex();
        $index->setMapping(new Mapping([
            'created' => ['type' => 'date', 'format' => 'epoch_millis'],
        ]));

        $index->addDocuments([
            new Document(1, ['created' => 1390962135000]),
            new Document(2, ['created' => 1390965735000]),
            new Document(3, ['created' => 1390954935000]),
        ]);

        $index->refresh();

        return $index;
    }
}