DateRangeTest::testDateRangeKeyedAggregation() - Code Metrics - Inspection of "Add "keyed" behavior to some aggregations" - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1876)

by romain

created 2020-11-23 17:00 UTC

DateRangeTest::testDateRangeKeyedAggregation() A

↳ Parent: DateRangeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Elastica\Test\Aggregation;

use Elastica\Aggregation\DateRange;
use Elastica\Document;
use Elastica\Exception\ResponseException;
use Elastica\Index;
use Elastica\Mapping;
use Elastica\Query;

/**
 * @internal
 */
class DateRangeTest extends BaseAggregationTest
{
    /**
     * @group unit
     */
    public function testSetTimezone(): void

    {
        $agg = (new DateRange('name'))
            ->setField('date')
            ->setTimezone('CET')
        ;

        $expected = [
            'date_range' => [
                'field' => 'date',
                'time_zone' => 'CET',
            ],
        ];

        $this->assertEquals($expected, $agg->toArray());
    }

    /**
     * @group functional
     */
    public function testDateRangeAggregation(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);

        $query = new Query();
        $query->addAggregation($agg);
        $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

        foreach ($results['buckets'] as $bucket) {

            if (\array_key_exists('to', $bucket)) {
                $this->assertEquals(1, $bucket['doc_count']);
            } elseif (\array_key_exists('from', $bucket)) {
                $this->assertEquals(2, $bucket['doc_count']);
            }
        }
    }

    /**
     * @group functional
     */
    public function testDateRangeKeyedAggregation(): void

    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->setKeyed();
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);

        $query = new Query();
        $query->addAggregation($agg);
        $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

        $expected = [
        ];
        $this->assertSame($expected, array_keys($results['buckets']));
    }

    /**
     * @group functional
     */
    public function testDateRangeSetFormat(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);
        $agg->setFormat('epoch_millis');

        $query = new Query();
        $query->addAggregation($agg);
        $results = $this->_getIndexForTest()->search($query)->getAggregation('date');

        $this->assertEquals('1390958535000', $results['buckets'][0]['to_as_string']);
    }

    /**
     * @group functional
     */
    public function testDateRangeSetFormatAccordingToFormatTargetField(): void
    {
        $agg = new DateRange('date');
        $agg->setField('created');
        $agg->addRange(1390958535000)->addRange(null, 1390958535000);
        $agg->setFormat('m-d-y');

        $query = new Query();
        $query->addAggregation($agg);

        try {
            $results = $this->_getIndexForTest()->search($query)->getAggregation('date');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->fail('Should throw exception to and from parameters in date_range aggregation are interpreted according of the target field');
        } catch (ResponseException $e) {
            $error = $e->getResponse()->getFullError();

            $this->assertSame('search_phase_execution_exception', $error['type']);
            $this->assertStringStartsWith('failed to parse date field', $error['root_cause'][0]['reason']);
        }
    }

    protected function _getIndexForTest(): Index

    {
        $index = $this->_createIndex();
        $index->setMapping(new Mapping([
            'created' => ['type' => 'date', 'format' => 'epoch_millis'],
        ]));

        $index->addDocuments([
            new Document(1, ['created' => 1390962135000]),
            new Document(2, ['created' => 1390965735000]),
            new Document(3, ['created' => 1390954935000]),
        ]);

        $index->refresh();

        return $index;
    }
}


1		<?php
2
3		namespace Elastica\Test\Aggregation;
4
5		use Elastica\Aggregation\DateRange;
6		use Elastica\Document;
7		use Elastica\Exception\ResponseException;
8		use Elastica\Index;
9		use Elastica\Mapping;
10		use Elastica\Query;
11
12		/**
13		* @internal
14		*/
15		class DateRangeTest extends BaseAggregationTest
16		{
17		/**
18		* @group unit
19		*/
20	View Code Duplication	public function testSetTimezone(): void
		0 ignored issues – show Duplication introduced 2020-11-12 14:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		$agg = (new DateRange('name'))
23		->setField('date')
24		->setTimezone('CET')
25		;
26
27		$expected = [
28		'date_range' => [
29		'field' => 'date',
30		'time_zone' => 'CET',
31		],
32		];
33
34		$this->assertEquals($expected, $agg->toArray());
35		}
36
37		/**
38		* @group functional
39		*/
40		public function testDateRangeAggregation(): void
41		{
42		$agg = new DateRange('date');
43		$agg->setField('created');
44		$agg->addRange(1390958535000)->addRange(null, 1390958535000);
45
46		$query = new Query();
47		$query->addAggregation($agg);
48		$results = $this->_getIndexForTest()->search($query)->getAggregation('date');
49
50	View Code Duplication	foreach ($results['buckets'] as $bucket) {
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		if (\array_key_exists('to', $bucket)) {
52		$this->assertEquals(1, $bucket['doc_count']);
53		} elseif (\array_key_exists('from', $bucket)) {
54		$this->assertEquals(2, $bucket['doc_count']);
55		}
56		}
57		}
58
59		/**
60		* @group functional
61		*/
62	View Code Duplication	public function testDateRangeKeyedAggregation(): void
		0 ignored issues – show Duplication introduced 2020-11-23 16:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$agg = new DateRange('date');
65		$agg->setField('created');
66		$agg->setKeyed();
67		$agg->addRange(1390958535000)->addRange(null, 1390958535000);
68
69		$query = new Query();
70		$query->addAggregation($agg);
71		$results = $this->_getIndexForTest()->search($query)->getAggregation('date');
72
73		$expected = [
74		];
75		$this->assertSame($expected, array_keys($results['buckets']));
76		}
77
78		/**
79		* @group functional
80		*/
81		public function testDateRangeSetFormat(): void
82		{
83		$agg = new DateRange('date');
84		$agg->setField('created');
85		$agg->addRange(1390958535000)->addRange(null, 1390958535000);
86		$agg->setFormat('epoch_millis');
87
88		$query = new Query();
89		$query->addAggregation($agg);
90		$results = $this->_getIndexForTest()->search($query)->getAggregation('date');
91
92		$this->assertEquals('1390958535000', $results['buckets'][0]['to_as_string']);
93		}
94
95		/**
96		* @group functional
97		*/
98		public function testDateRangeSetFormatAccordingToFormatTargetField(): void
99		{
100		$agg = new DateRange('date');
101		$agg->setField('created');
102		$agg->addRange(1390958535000)->addRange(null, 1390958535000);
103		$agg->setFormat('m-d-y');
104
105		$query = new Query();
106		$query->addAggregation($agg);
107
108		try {
109		$results = $this->_getIndexForTest()->search($query)->getAggregation('date');
		0 ignored issues – show Unused Code introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report `$results` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
110		$this->fail('Should throw exception to and from parameters in date_range aggregation are interpreted according of the target field');
111		} catch (ResponseException $e) {
112		$error = $e->getResponse()->getFullError();
113
114		$this->assertSame('search_phase_execution_exception', $error['type']);
115		$this->assertStringStartsWith('failed to parse date field', $error['root_cause'][0]['reason']);
116		}
117		}
118
119	View Code Duplication	protected function _getIndexForTest(): Index
		0 ignored issues – show Duplication introduced 2020-10-27 17:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		{
121		$index = $this->_createIndex();
122		$index->setMapping(new Mapping([
123		'created' => ['type' => 'date', 'format' => 'epoch_millis'],
124		]));
125
126		$index->addDocuments([
127		new Document(1, ['created' => 1390962135000]),
128		new Document(2, ['created' => 1390965735000]),
129		new Document(3, ['created' => 1390954935000]),
130		]);
131
132		$index->refresh();
133
134		return $index;
135		}
136		}
137

ruflin / Elastica

Pull Request — master (#1876)

DateRangeTest::testDateRangeKeyedAggregation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like