TopHitsTest - Code Metrics - Inspection of "Use AWS SDK package version compatible with PHP 8..." - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9146c8...39ecb4 )

by Nicolas

created 2020-09-28 08:54 UTC

TopHitsTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	395
Duplicated Lines	37.22 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

Metric	Value
wmc	41
lcom	1
cbo	12
dl	147
loc	395
c	0
b	0
f	0
rs	9.1199

23 Methods

Rating	Name	Duplication	Size	Complexity
A	limitedSourceProvider()	0	7	1
A	testSetSize()	0	7	1
A	testSetFrom()	7	7	1
A	testSetSort()	0	8	1
A	testSetSource()	8	8	1
A	testSetVersion()	10	10	1
A	testSetExplain()	10	10	1
A	testSetHighlight()	0	12	1
A	testSetFieldDataFields()	8	8	1
A	testSetScriptFields()	0	10	1
A	testAddScriptField()	0	8	1
A	testAggregateUpdatedRecently()	15	15	3
A	testAggregateUpdatedFarAgo()	15	15	3
A	testAggregateTwoDocumentPerTag()	14	14	3
A	testAggregateTwoDocumentPerTagWithOffset()	16	16	3
A	testAggregateWithLimitedSource()	0	15	3
A	testAggregateWithVersion()	13	13	3
A	testAggregateWithExplain()	13	13	3
A	testAggregateWithScriptFields()	6	16	3
A	testAggregateWithHighlight()	0	18	2
A	testAggregateWithFieldData()	0	18	2
A	_getIndexForTest()	0	47	1
A	getOuterAggregationResult()	12	12	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like TopHitsTest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use TopHitsTest, and based on these observations, apply Extract Interface, too.

<?php

namespace Elastica\Test\Aggregation;

use Elastica\Aggregation\Terms;
use Elastica\Aggregation\TopHits;
use Elastica\Document;
use Elastica\Index;
use Elastica\Mapping;
use Elastica\Query;
use Elastica\Query\MatchAll;
use Elastica\Query\SimpleQueryString;
use Elastica\Script\Script;
use Elastica\Script\ScriptFields;

/**
 * @internal
 */
class TopHitsTest extends BaseAggregationTest
{
    /**
     * @group unit
     */
    public function testSetSize(): void
    {
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setSize(12);
        $this->assertEquals(12, $agg->getParam('size'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetFrom(): void

    {
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setFrom(12);
        $this->assertEquals(12, $agg->getParam('from'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetSort(): void
    {
        $sort = ['last_activity_date' => ['order' => 'desc']];
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setSort($sort);
        $this->assertEquals($sort, $agg->getParam('sort'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetSource(): void

    {
        $fields = ['title', 'tags'];
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setSource($fields);
        $this->assertEquals($fields, $agg->getParam('_source'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetVersion(): void

    {
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setVersion(true);
        $this->assertTrue($agg->getParam('version'));
        $this->assertInstanceOf(TopHits::class, $returnValue);

        $agg->setVersion(false);
        $this->assertFalse($agg->getParam('version'));
    }

    /**
     * @group unit
     */
    public function testSetExplain(): void

    {
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setExplain(true);
        $this->assertTrue($agg->getParam('explain'));
        $this->assertInstanceOf(TopHits::class, $returnValue);

        $agg->setExplain(false);
        $this->assertFalse($agg->getParam('explain'));
    }

    /**
     * @group unit
     */
    public function testSetHighlight(): void
    {
        $highlight = [
            'fields' => [
                'title',
            ],
        ];
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setHighlight($highlight);
        $this->assertEquals($highlight, $agg->getParam('highlight'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetFieldDataFields(): void

    {
        $fields = ['title', 'tags'];
        $agg = new TopHits('agg_name');
        $returnValue = $agg->setFieldDataFields($fields);
        $this->assertEquals($fields, $agg->getParam('docvalue_fields'));
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testSetScriptFields(): void
    {
        $script = new Script('1 + 2');
        $scriptFields = new ScriptFields(['three' => $script]);

        $agg = new TopHits('agg_name');
        $returnValue = $agg->setScriptFields($scriptFields);
        $this->assertEquals($scriptFields->toArray(), $agg->getParam('script_fields')->toArray());
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group unit
     */
    public function testAddScriptField(): void
    {
        $script = new Script('2+3');
        $agg = new TopHits('agg_name');
        $returnValue = $agg->addScriptField('five', $script);
        $this->assertEquals(['five' => $script->toArray()], $agg->getParam('script_fields')->toArray());
        $this->assertInstanceOf(TopHits::class, $returnValue);
    }

    /**
     * @group functional
     */
    public function testAggregateUpdatedRecently(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSize(1);
        $aggr->setSort(['last_activity_date' => ['order' => 'desc']]);

        $resultDocs = [];
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $resultDocs[] = $doc['_id'];
            }
        }
        $this->assertEquals([1, 3], $resultDocs);
    }

    /**
     * @group functional
     */
    public function testAggregateUpdatedFarAgo(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSize(1);
        $aggr->setSort(['last_activity_date' => ['order' => 'asc']]);

        $resultDocs = [];
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $resultDocs[] = $doc['_id'];
            }
        }
        $this->assertEquals([2, 4], $resultDocs);
    }

    /**
     * @group functional
     */
    public function testAggregateTwoDocumentPerTag(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSize(2);

        $resultDocs = [];
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $resultDocs[] = $doc['_id'];
            }
        }
        $this->assertEquals([1, 2, 3, 4], $resultDocs);
    }

    /**
     * @group functional
     */
    public function testAggregateTwoDocumentPerTagWithOffset(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSize(2);
        $aggr->setFrom(1);
        $aggr->setSort(['last_activity_date' => ['order' => 'desc']]);

        $resultDocs = [];
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $resultDocs[] = $doc['_id'];
            }
        }
        $this->assertEquals([2, 4], $resultDocs);
    }

    public function limitedSourceProvider()
    {
        return [
            'string source' => ['title'],
            'array source' => [['title']],
        ];
    }

    /**
     * @group functional
     * @dataProvider limitedSourceProvider
     *
     * @param mixed $source
     */
    public function testAggregateWithLimitedSource($source): void
    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSource($source);

        $resultDocs = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $this->assertArrayHasKey('title', $doc['_source']);
                $this->assertArrayNotHasKey('tags', $doc['_source']);
                $this->assertArrayNotHasKey('last_activity_date', $doc['_source']);
            }
        }
    }

    /**
     * @group functional
     */
    public function testAggregateWithVersion(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setVersion(true);

        $resultDocs = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $this->assertArrayHasKey('_version', $doc);
            }
        }
    }

    /**
     * @group functional
     */
    public function testAggregateWithExplain(): void

    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setExplain(true);

        $resultDocs = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {
            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $this->assertArrayHasKey('_explanation', $doc);
            }
        }
    }

    /**
     * @group functional
     */
    public function testAggregateWithScriptFields(): void
    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setSize(1);
        $aggr->setScriptFields(['three' => new Script('1 + 2')]);
        $aggr->addScriptField('five', new Script('3 + 2'));

        $resultDocs = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $outerAggrResult = $this->getOuterAggregationResult($aggr);
        foreach ($outerAggrResult['buckets'] as $bucket) {

            foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
                $this->assertEquals(3, $doc['fields']['three'][0]);
                $this->assertEquals(5, $doc['fields']['five'][0]);
            }
        }
    }

    /**
     * @group functional
     */
    public function testAggregateWithHighlight(): void
    {
        $queryString = new SimpleQueryString('linux', ['title']);

        $aggr = new TopHits('top_tag_hits');
        $aggr->setHighlight(['fields' => ['title' => new \stdClass()]]);

        $query = new Query($queryString);
        $query->addAggregation($aggr);

        $resultSet = $this->_getIndexForTest()->search($query);
        $aggrResult = $resultSet->getAggregation('top_tag_hits');

        foreach ($aggrResult['hits']['hits'] as $doc) {
            $this->assertArrayHasKey('highlight', $doc);
            $this->assertRegExp('#<em>linux</em>#', $doc['highlight']['title'][0]);
        }
    }

    /**
     * @group functional
     */
    public function testAggregateWithFieldData(): void
    {
        $aggr = new TopHits('top_tag_hits');
        $aggr->setFieldDataFields(['title']);

        $query = new Query(new MatchAll());
        $query->addAggregation($aggr);

        $resultSet = $this->_getIndexForTest()->search($query);
        $aggrResult = $resultSet->getAggregation('top_tag_hits');

        foreach ($aggrResult['hits']['hits'] as $doc) {
            $this->assertArrayHasKey('fields', $doc);
            $this->assertArrayHasKey('title', $doc['fields']);
            $this->assertArrayNotHasKey('tags', $doc['fields']);
            $this->assertArrayNotHasKey('last_activity_date', $doc['fields']);
        }
    }

    protected function _getIndexForTest(): Index
    {
        $index = $this->_createIndex();
        $mapping = new Mapping([
            'tags' => ['type' => 'keyword'],
            'title' => ['type' => 'keyword'],
            'my_join_field' => [
                'type' => 'join',
                'relations' => [
                    'question' => 'answer',
                ],
            ],
        ]);
        $index->setMapping($mapping);

        $index->addDocuments([
            new Document(1, [
                'tags' => ['linux'],
                'last_activity_date' => '2015-01-05',
                'title' => 'Question about linux #1',
            ]),
            new Document(2, [
                'tags' => ['linux'],
                'last_activity_date' => '2014-12-23',
                'title' => 'Question about linux #2',
            ]),
            new Document(3, [
                'tags' => ['windows'],
                'last_activity_date' => '2015-01-05',
                'title' => 'Question about windows #1',
            ]),
            new Document(4, [
                'tags' => ['windows'],
                'last_activity_date' => '2014-12-23',
                'title' => 'Question about windows #2',
            ]),
            new Document(5, [
                'tags' => ['osx', 'apple'],
                'last_activity_date' => '2014-12-23',
                'title' => 'Question about osx',
            ]),
        ]);

        $index->refresh();

        return $index;
    }

    protected function getOuterAggregationResult($innerAggr)

    {
        $outerAggr = new Terms('top_tags');
        $outerAggr->setField('tags');
        $outerAggr->setMinimumDocumentCount(2);
        $outerAggr->addAggregation($innerAggr);

        $query = new Query(new MatchAll());
        $query->addAggregation($outerAggr);

        return $this->_getIndexForTest()->search($query)->getAggregation('top_tags');
    }
}


1		<?php
2
3		namespace Elastica\Test\Aggregation;
4
5		use Elastica\Aggregation\Terms;
6		use Elastica\Aggregation\TopHits;
7		use Elastica\Document;
8		use Elastica\Index;
9		use Elastica\Mapping;
10		use Elastica\Query;
11		use Elastica\Query\MatchAll;
12		use Elastica\Query\SimpleQueryString;
13		use Elastica\Script\Script;
14		use Elastica\Script\ScriptFields;
15
16		/**
17		* @internal
18		*/
19		class TopHitsTest extends BaseAggregationTest
20		{
21		/**
22		* @group unit
23		*/
24		public function testSetSize(): void
25		{
26		$agg = new TopHits('agg_name');
27		$returnValue = $agg->setSize(12);
28		$this->assertEquals(12, $agg->getParam('size'));
29		$this->assertInstanceOf(TopHits::class, $returnValue);
30		}
31
32		/**
33		* @group unit
34		*/
35	View Code Duplication	public function testSetFrom(): void
		0 ignored issues – show Duplication introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$agg = new TopHits('agg_name');
38		$returnValue = $agg->setFrom(12);
39		$this->assertEquals(12, $agg->getParam('from'));
40		$this->assertInstanceOf(TopHits::class, $returnValue);
41		}
42
43		/**
44		* @group unit
45		*/
46		public function testSetSort(): void
47		{
48		$sort = ['last_activity_date' => ['order' => 'desc']];
49		$agg = new TopHits('agg_name');
50		$returnValue = $agg->setSort($sort);
51		$this->assertEquals($sort, $agg->getParam('sort'));
52		$this->assertInstanceOf(TopHits::class, $returnValue);
53		}
54
55		/**
56		* @group unit
57		*/
58	View Code Duplication	public function testSetSource(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		$fields = ['title', 'tags'];
61		$agg = new TopHits('agg_name');
62		$returnValue = $agg->setSource($fields);
63		$this->assertEquals($fields, $agg->getParam('_source'));
64		$this->assertInstanceOf(TopHits::class, $returnValue);
65		}
66
67		/**
68		* @group unit
69		*/
70	View Code Duplication	public function testSetVersion(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		$agg = new TopHits('agg_name');
73		$returnValue = $agg->setVersion(true);
74		$this->assertTrue($agg->getParam('version'));
75		$this->assertInstanceOf(TopHits::class, $returnValue);
76
77		$agg->setVersion(false);
78		$this->assertFalse($agg->getParam('version'));
79		}
80
81		/**
82		* @group unit
83		*/
84	View Code Duplication	public function testSetExplain(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		{
86		$agg = new TopHits('agg_name');
87		$returnValue = $agg->setExplain(true);
88		$this->assertTrue($agg->getParam('explain'));
89		$this->assertInstanceOf(TopHits::class, $returnValue);
90
91		$agg->setExplain(false);
92		$this->assertFalse($agg->getParam('explain'));
93		}
94
95		/**
96		* @group unit
97		*/
98		public function testSetHighlight(): void
99		{
100		$highlight = [
101		'fields' => [
102		'title',
103		],
104		];
105		$agg = new TopHits('agg_name');
106		$returnValue = $agg->setHighlight($highlight);
107		$this->assertEquals($highlight, $agg->getParam('highlight'));
108		$this->assertInstanceOf(TopHits::class, $returnValue);
109		}
110
111		/**
112		* @group unit
113		*/
114	View Code Duplication	public function testSetFieldDataFields(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115		{
116		$fields = ['title', 'tags'];
117		$agg = new TopHits('agg_name');
118		$returnValue = $agg->setFieldDataFields($fields);
119		$this->assertEquals($fields, $agg->getParam('docvalue_fields'));
120		$this->assertInstanceOf(TopHits::class, $returnValue);
121		}
122
123		/**
124		* @group unit
125		*/
126		public function testSetScriptFields(): void
127		{
128		$script = new Script('1 + 2');
129		$scriptFields = new ScriptFields(['three' => $script]);
130
131		$agg = new TopHits('agg_name');
132		$returnValue = $agg->setScriptFields($scriptFields);
133		$this->assertEquals($scriptFields->toArray(), $agg->getParam('script_fields')->toArray());
134		$this->assertInstanceOf(TopHits::class, $returnValue);
135		}
136
137		/**
138		* @group unit
139		*/
140		public function testAddScriptField(): void
141		{
142		$script = new Script('2+3');
143		$agg = new TopHits('agg_name');
144		$returnValue = $agg->addScriptField('five', $script);
145		$this->assertEquals(['five' => $script->toArray()], $agg->getParam('script_fields')->toArray());
146		$this->assertInstanceOf(TopHits::class, $returnValue);
147		}
148
149		/**
150		* @group functional
151		*/
152	View Code Duplication	public function testAggregateUpdatedRecently(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153		{
154		$aggr = new TopHits('top_tag_hits');
155		$aggr->setSize(1);
156		$aggr->setSort(['last_activity_date' => ['order' => 'desc']]);
157
158		$resultDocs = [];
159		$outerAggrResult = $this->getOuterAggregationResult($aggr);
160		foreach ($outerAggrResult['buckets'] as $bucket) {
161		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
162		$resultDocs[] = $doc['_id'];
163		}
164		}
165		$this->assertEquals([1, 3], $resultDocs);
166		}
167
168		/**
169		* @group functional
170		*/
171	View Code Duplication	public function testAggregateUpdatedFarAgo(): void
		0 ignored issues – show Duplication introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
172		{
173		$aggr = new TopHits('top_tag_hits');
174		$aggr->setSize(1);
175		$aggr->setSort(['last_activity_date' => ['order' => 'asc']]);
176
177		$resultDocs = [];
178		$outerAggrResult = $this->getOuterAggregationResult($aggr);
179		foreach ($outerAggrResult['buckets'] as $bucket) {
180		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
181		$resultDocs[] = $doc['_id'];
182		}
183		}
184		$this->assertEquals([2, 4], $resultDocs);
185		}
186
187		/**
188		* @group functional
189		*/
190	View Code Duplication	public function testAggregateTwoDocumentPerTag(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
191		{
192		$aggr = new TopHits('top_tag_hits');
193		$aggr->setSize(2);
194
195		$resultDocs = [];
196		$outerAggrResult = $this->getOuterAggregationResult($aggr);
197		foreach ($outerAggrResult['buckets'] as $bucket) {
198		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
199		$resultDocs[] = $doc['_id'];
200		}
201		}
202		$this->assertEquals([1, 2, 3, 4], $resultDocs);
203		}
204
205		/**
206		* @group functional
207		*/
208	View Code Duplication	public function testAggregateTwoDocumentPerTagWithOffset(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
209		{
210		$aggr = new TopHits('top_tag_hits');
211		$aggr->setSize(2);
212		$aggr->setFrom(1);
213		$aggr->setSort(['last_activity_date' => ['order' => 'desc']]);
214
215		$resultDocs = [];
216		$outerAggrResult = $this->getOuterAggregationResult($aggr);
217		foreach ($outerAggrResult['buckets'] as $bucket) {
218		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
219		$resultDocs[] = $doc['_id'];
220		}
221		}
222		$this->assertEquals([2, 4], $resultDocs);
223		}
224
225		public function limitedSourceProvider()
226		{
227		return [
228		'string source' => ['title'],
229		'array source' => [['title']],
230		];
231		}
232
233		/**
234		* @group functional
235		* @dataProvider limitedSourceProvider
236		*
237		* @param mixed $source
238		*/
239		public function testAggregateWithLimitedSource($source): void
240		{
241		$aggr = new TopHits('top_tag_hits');
242		$aggr->setSource($source);
243
244		$resultDocs = [];
		0 ignored issues – show Unused Code introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report `$resultDocs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
245		$outerAggrResult = $this->getOuterAggregationResult($aggr);
246		foreach ($outerAggrResult['buckets'] as $bucket) {
247		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
248		$this->assertArrayHasKey('title', $doc['_source']);
249		$this->assertArrayNotHasKey('tags', $doc['_source']);
250		$this->assertArrayNotHasKey('last_activity_date', $doc['_source']);
251		}
252		}
253		}
254
255		/**
256		* @group functional
257		*/
258	View Code Duplication	public function testAggregateWithVersion(): void
		0 ignored issues – show Duplication introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
259		{
260		$aggr = new TopHits('top_tag_hits');
261		$aggr->setVersion(true);
262
263		$resultDocs = [];
		0 ignored issues – show Unused Code introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report `$resultDocs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
264		$outerAggrResult = $this->getOuterAggregationResult($aggr);
265		foreach ($outerAggrResult['buckets'] as $bucket) {
266		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
267		$this->assertArrayHasKey('_version', $doc);
268		}
269		}
270		}
271
272		/**
273		* @group functional
274		*/
275	View Code Duplication	public function testAggregateWithExplain(): void
		0 ignored issues – show Duplication introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
276		{
277		$aggr = new TopHits('top_tag_hits');
278		$aggr->setExplain(true);
279
280		$resultDocs = [];
		0 ignored issues – show Unused Code introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report `$resultDocs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
281		$outerAggrResult = $this->getOuterAggregationResult($aggr);
282		foreach ($outerAggrResult['buckets'] as $bucket) {
283		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
284		$this->assertArrayHasKey('_explanation', $doc);
285		}
286		}
287		}
288
289		/**
290		* @group functional
291		*/
292		public function testAggregateWithScriptFields(): void
293		{
294		$aggr = new TopHits('top_tag_hits');
295		$aggr->setSize(1);
296		$aggr->setScriptFields(['three' => new Script('1 + 2')]);
297		$aggr->addScriptField('five', new Script('3 + 2'));
298
299		$resultDocs = [];
		0 ignored issues – show Unused Code introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report `$resultDocs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
300		$outerAggrResult = $this->getOuterAggregationResult($aggr);
301	View Code Duplication	foreach ($outerAggrResult['buckets'] as $bucket) {
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
302		foreach ($bucket['top_tag_hits']['hits']['hits'] as $doc) {
303		$this->assertEquals(3, $doc['fields']['three'][0]);
304		$this->assertEquals(5, $doc['fields']['five'][0]);
305		}
306		}
307		}
308
309		/**
310		* @group functional
311		*/
312		public function testAggregateWithHighlight(): void
313		{
314		$queryString = new SimpleQueryString('linux', ['title']);
315
316		$aggr = new TopHits('top_tag_hits');
317		$aggr->setHighlight(['fields' => ['title' => new \stdClass()]]);
318
319		$query = new Query($queryString);
320		$query->addAggregation($aggr);
321
322		$resultSet = $this->_getIndexForTest()->search($query);
323		$aggrResult = $resultSet->getAggregation('top_tag_hits');
324
325		foreach ($aggrResult['hits']['hits'] as $doc) {
326		$this->assertArrayHasKey('highlight', $doc);
327		$this->assertRegExp('#<em>linux</em>#', $doc['highlight']['title'][0]);
328		}
329		}
330
331		/**
332		* @group functional
333		*/
334		public function testAggregateWithFieldData(): void
335		{
336		$aggr = new TopHits('top_tag_hits');
337		$aggr->setFieldDataFields(['title']);
338
339		$query = new Query(new MatchAll());
340		$query->addAggregation($aggr);
341
342		$resultSet = $this->_getIndexForTest()->search($query);
343		$aggrResult = $resultSet->getAggregation('top_tag_hits');
344
345		foreach ($aggrResult['hits']['hits'] as $doc) {
346		$this->assertArrayHasKey('fields', $doc);
347		$this->assertArrayHasKey('title', $doc['fields']);
348		$this->assertArrayNotHasKey('tags', $doc['fields']);
349		$this->assertArrayNotHasKey('last_activity_date', $doc['fields']);
350		}
351		}
352
353		protected function _getIndexForTest(): Index
354		{
355		$index = $this->_createIndex();
356		$mapping = new Mapping([
357		'tags' => ['type' => 'keyword'],
358		'title' => ['type' => 'keyword'],
359		'my_join_field' => [
360		'type' => 'join',
361		'relations' => [
362		'question' => 'answer',
363		],
364		],
365		]);
366		$index->setMapping($mapping);
367
368		$index->addDocuments([
369		new Document(1, [
370		'tags' => ['linux'],
371		'last_activity_date' => '2015-01-05',
372		'title' => 'Question about linux #1',
373		]),
374		new Document(2, [
375		'tags' => ['linux'],
376		'last_activity_date' => '2014-12-23',
377		'title' => 'Question about linux #2',
378		]),
379		new Document(3, [
380		'tags' => ['windows'],
381		'last_activity_date' => '2015-01-05',
382		'title' => 'Question about windows #1',
383		]),
384		new Document(4, [
385		'tags' => ['windows'],
386		'last_activity_date' => '2014-12-23',
387		'title' => 'Question about windows #2',
388		]),
389		new Document(5, [
390		'tags' => ['osx', 'apple'],
391		'last_activity_date' => '2014-12-23',
392		'title' => 'Question about osx',
393		]),
394		]);
395
396		$index->refresh();
397
398		return $index;
399		}
400
401	View Code Duplication	protected function getOuterAggregationResult($innerAggr)
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
402		{
403		$outerAggr = new Terms('top_tags');
404		$outerAggr->setField('tags');
405		$outerAggr->setMinimumDocumentCount(2);
406		$outerAggr->addAggregation($innerAggr);
407
408		$query = new Query(new MatchAll());
409		$query->addAggregation($outerAggr);
410
411		return $this->_getIndexForTest()->search($query)->getAggregation('top_tags');
412		}
413		}
414

ruflin / Elastica