FiltersTest - Code Metrics - Inspection of "Use AWS SDK package version compatible with PHP 8..." - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9146c8...39ecb4 )

by Nicolas

created 2020-09-28 08:54 UTC

FiltersTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	231
Duplicated Lines	62.34 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	8
dl	144
loc	231
c	0
b	0
f	0
rs	10

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testToArrayUsingOtherBucket()	0	23	1
A	testSetOtherBucket()	24	24	1
A	testSetOtherBucketKey()	25	25	1
A	testToArrayUsingNamedFilters()	37	37	1
A	testMixNamedAndAnonymousFilters()	9	9	1
A	testMixAnonymousAndNamedFilters()	10	10	1
A	testToArrayUsingAnonymousFilters()	0	29	1
A	testFilterAggregation()	24	24	1
A	_getIndexForTest()	15	15	1

How to fix Duplicated Code

<?php

namespace Elastica\Test\Aggregation;

use Elastica\Aggregation\Avg;
use Elastica\Aggregation\Filters;
use Elastica\Document;
use Elastica\Index;
use Elastica\Query;
use Elastica\Query\Term;

/**
 * @internal
 */
class FiltersTest extends BaseAggregationTest
{
    /**
     * @group unit
     */
    public function testToArrayUsingNamedFilters(): void

    {
        $expected = [
            'filters' => [
                'filters' => [
                    '' => [
                        'term' => ['color' => ''],
                    ],
                    '0' => [
                        'term' => ['color' => '0'],
                    ],
                    'blue' => [
                        'term' => ['color' => 'blue'],
                    ],
                    'red' => [
                        'term' => ['color' => 'red'],
                    ],
                ],
            ],
            'aggs' => [
                'avg_price' => ['avg' => ['field' => 'price']],
            ],
        ];

        $agg = new Filters('by_color');

        $agg->addFilter(new Term(['color' => '']), '');
        $agg->addFilter(new Term(['color' => '0']), '0');
        $agg->addFilter(new Term(['color' => 'blue']), 'blue');
        $agg->addFilter(new Term(['color' => 'red']), 'red');

        $avg = new Avg('avg_price');
        $avg->setField('price');
        $agg->addAggregation($avg);

        $this->assertEquals($expected, $agg->toArray());
    }

    /**
     * @group unit
     */
    public function testMixNamedAndAnonymousFilters(): void

    {
        $this->expectException(\Elastica\Exception\InvalidException::class);
        $this->expectExceptionMessage('Mix named and anonymous keys are not allowed');

        $agg = new Filters('by_color');
        $agg->addFilter(new Term(['color' => '0']), '0');
        $agg->addFilter(new Term(['color' => '0']));
    }

    /**
     * @group unit
     */
    public function testMixAnonymousAndNamedFilters(): void

    {
        $this->expectException(\Elastica\Exception\InvalidException::class);
        $this->expectExceptionMessage('Mix named and anonymous keys are not allowed');

        $agg = new Filters('by_color');

        $agg->addFilter(new Term(['color' => '0']));
        $agg->addFilter(new Term(['color' => '0']), '0');
    }

    /**
     * @group unit
     */
    public function testToArrayUsingAnonymousFilters(): void
    {
        $expected = [
            'filters' => [
                'filters' => [
                    [
                        'term' => ['color' => 'blue'],
                    ],
                    [
                        'term' => ['color' => 'red'],
                    ],
                ],
            ],
            'aggs' => [
                'avg_price' => ['avg' => ['field' => 'price']],
            ],
        ];

        $agg = new Filters('by_color');

        $agg->addFilter(new Term(['color' => 'blue']));
        $agg->addFilter(new Term(['color' => 'red']));

        $avg = new Avg('avg_price');
        $avg->setField('price');
        $agg->addAggregation($avg);

        $this->assertEquals($expected, $agg->toArray());
    }

    /**
     * @group unit
     */
    public function testToArrayUsingOtherBucket(): void
    {
        $expected = [
            'filters' => [
                'filters' => [
                    [
                        'term' => ['color' => 'blue'],
                    ],
                ],
                'other_bucket' => true,
                'other_bucket_key' => 'other',
            ],
        ];

        $agg = new Filters('by_color');

        $agg->addFilter(new Term(['color' => 'blue']));

        $agg->setOtherBucket(true);
        $agg->setOtherBucketKey('other');

        $this->assertEquals($expected, $agg->toArray());
    }

    /**
     * @group functional
     */
    public function testFilterAggregation(): void

    {
        $agg = new Filters('by_color');
        $agg->addFilter(new Term(['color' => 'blue']), 'blue');
        $agg->addFilter(new Term(['color' => 'red']), 'red');

        $avg = new Avg('avg_price');
        $avg->setField('price');
        $agg->addAggregation($avg);

        $query = new Query();
        $query->addAggregation($agg);

        $results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');

        $resultsForBlue = $results['buckets']['blue'];
        $resultsForRed = $results['buckets']['red'];

        $this->assertEquals(2, $resultsForBlue['doc_count']);
        $this->assertEquals(1, $resultsForRed['doc_count']);

        $this->assertEquals((5 + 8) / 2, $resultsForBlue['avg_price']['value']);
        $this->assertEquals(1, $resultsForRed['avg_price']['value']);
    }

    /**
     * @group functional
     */
    public function testSetOtherBucket(): void

    {
        $agg = new Filters('by_color');
        $agg->addFilter(new Term(['color' => 'red']), 'red');
        $agg->setOtherBucket(true);

        $avg = new Avg('avg_price');
        $avg->setField('price');
        $agg->addAggregation($avg);

        $query = new Query();
        $query->addAggregation($agg);

        $results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');

        $resultsForRed = $results['buckets']['red'];
        $resultsForOtherBucket = $results['buckets']['_other_'];

        $this->assertEquals(1, $resultsForRed['doc_count']);
        $this->assertEquals(3, $resultsForOtherBucket['doc_count']);

        $this->assertEquals(1, $resultsForRed['avg_price']['value']);
        $this->assertEquals((5 + 8 + 3) / 3, $resultsForOtherBucket['avg_price']['value']);
    }

    /**
     * @group functional
     */
    public function testSetOtherBucketKey(): void

    {
        $agg = new Filters('by_color');
        $agg->addFilter(new Term(['color' => 'red']), 'red');
        $agg->setOtherBucket(true);
        $agg->setOtherBucketKey('other_colors');

        $avg = new Avg('avg_price');
        $avg->setField('price');
        $agg->addAggregation($avg);

        $query = new Query();
        $query->addAggregation($agg);

        $results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');

        $resultsForRed = $results['buckets']['red'];
        $resultsForOtherBucket = $results['buckets']['other_colors'];

        $this->assertEquals(1, $resultsForRed['doc_count']);
        $this->assertEquals(3, $resultsForOtherBucket['doc_count']);

        $this->assertEquals(1, $resultsForRed['avg_price']['value']);
        $this->assertEquals((5 + 8 + 3) / 3, $resultsForOtherBucket['avg_price']['value']);
    }

    protected function _getIndexForTest(): Index

    {
        $index = $this->_createIndex('filter');

        $index->addDocuments([
            new Document(1, ['price' => 5, 'color' => 'blue']),
            new Document(2, ['price' => 8, 'color' => 'blue']),
            new Document(3, ['price' => 1, 'color' => 'red']),
            new Document(4, ['price' => 3, 'color' => 'green']),
        ]);

        $index->refresh();

        return $index;
    }
}


1		<?php
2
3		namespace Elastica\Test\Aggregation;
4
5		use Elastica\Aggregation\Avg;
6		use Elastica\Aggregation\Filters;
7		use Elastica\Document;
8		use Elastica\Index;
9		use Elastica\Query;
10		use Elastica\Query\Term;
11
12		/**
13		* @internal
14		*/
15		class FiltersTest extends BaseAggregationTest
16		{
17		/**
18		* @group unit
19		*/
20	View Code Duplication	public function testToArrayUsingNamedFilters(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		$expected = [
23		'filters' => [
24		'filters' => [
25		'' => [
26		'term' => ['color' => ''],
27		],
28		'0' => [
29		'term' => ['color' => '0'],
30		],
31		'blue' => [
32		'term' => ['color' => 'blue'],
33		],
34		'red' => [
35		'term' => ['color' => 'red'],
36		],
37		],
38		],
39		'aggs' => [
40		'avg_price' => ['avg' => ['field' => 'price']],
41		],
42		];
43
44		$agg = new Filters('by_color');
45
46		$agg->addFilter(new Term(['color' => '']), '');
47		$agg->addFilter(new Term(['color' => '0']), '0');
48		$agg->addFilter(new Term(['color' => 'blue']), 'blue');
49		$agg->addFilter(new Term(['color' => 'red']), 'red');
50
51		$avg = new Avg('avg_price');
52		$avg->setField('price');
53		$agg->addAggregation($avg);
54
55		$this->assertEquals($expected, $agg->toArray());
56		}
57
58		/**
59		* @group unit
60		*/
61	View Code Duplication	public function testMixNamedAndAnonymousFilters(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$this->expectException(\Elastica\Exception\InvalidException::class);
64		$this->expectExceptionMessage('Mix named and anonymous keys are not allowed');
65
66		$agg = new Filters('by_color');
67		$agg->addFilter(new Term(['color' => '0']), '0');
68		$agg->addFilter(new Term(['color' => '0']));
69		}
70
71		/**
72		* @group unit
73		*/
74	View Code Duplication	public function testMixAnonymousAndNamedFilters(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		$this->expectException(\Elastica\Exception\InvalidException::class);
77		$this->expectExceptionMessage('Mix named and anonymous keys are not allowed');
78
79		$agg = new Filters('by_color');
80
81		$agg->addFilter(new Term(['color' => '0']));
82		$agg->addFilter(new Term(['color' => '0']), '0');
83		}
84
85		/**
86		* @group unit
87		*/
88		public function testToArrayUsingAnonymousFilters(): void
89		{
90		$expected = [
91		'filters' => [
92		'filters' => [
93		[
94		'term' => ['color' => 'blue'],
95		],
96		[
97		'term' => ['color' => 'red'],
98		],
99		],
100		],
101		'aggs' => [
102		'avg_price' => ['avg' => ['field' => 'price']],
103		],
104		];
105
106		$agg = new Filters('by_color');
107
108		$agg->addFilter(new Term(['color' => 'blue']));
109		$agg->addFilter(new Term(['color' => 'red']));
110
111		$avg = new Avg('avg_price');
112		$avg->setField('price');
113		$agg->addAggregation($avg);
114
115		$this->assertEquals($expected, $agg->toArray());
116		}
117
118		/**
119		* @group unit
120		*/
121		public function testToArrayUsingOtherBucket(): void
122		{
123		$expected = [
124		'filters' => [
125		'filters' => [
126		[
127		'term' => ['color' => 'blue'],
128		],
129		],
130		'other_bucket' => true,
131		'other_bucket_key' => 'other',
132		],
133		];
134
135		$agg = new Filters('by_color');
136
137		$agg->addFilter(new Term(['color' => 'blue']));
138
139		$agg->setOtherBucket(true);
140		$agg->setOtherBucketKey('other');
141
142		$this->assertEquals($expected, $agg->toArray());
143		}
144
145		/**
146		* @group functional
147		*/
148	View Code Duplication	public function testFilterAggregation(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149		{
150		$agg = new Filters('by_color');
151		$agg->addFilter(new Term(['color' => 'blue']), 'blue');
152		$agg->addFilter(new Term(['color' => 'red']), 'red');
153
154		$avg = new Avg('avg_price');
155		$avg->setField('price');
156		$agg->addAggregation($avg);
157
158		$query = new Query();
159		$query->addAggregation($agg);
160
161		$results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');
162
163		$resultsForBlue = $results['buckets']['blue'];
164		$resultsForRed = $results['buckets']['red'];
165
166		$this->assertEquals(2, $resultsForBlue['doc_count']);
167		$this->assertEquals(1, $resultsForRed['doc_count']);
168
169		$this->assertEquals((5 + 8) / 2, $resultsForBlue['avg_price']['value']);
170		$this->assertEquals(1, $resultsForRed['avg_price']['value']);
171		}
172
173		/**
174		* @group functional
175		*/
176	View Code Duplication	public function testSetOtherBucket(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
177		{
178		$agg = new Filters('by_color');
179		$agg->addFilter(new Term(['color' => 'red']), 'red');
180		$agg->setOtherBucket(true);
181
182		$avg = new Avg('avg_price');
183		$avg->setField('price');
184		$agg->addAggregation($avg);
185
186		$query = new Query();
187		$query->addAggregation($agg);
188
189		$results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');
190
191		$resultsForRed = $results['buckets']['red'];
192		$resultsForOtherBucket = $results['buckets']['_other_'];
193
194		$this->assertEquals(1, $resultsForRed['doc_count']);
195		$this->assertEquals(3, $resultsForOtherBucket['doc_count']);
196
197		$this->assertEquals(1, $resultsForRed['avg_price']['value']);
198		$this->assertEquals((5 + 8 + 3) / 3, $resultsForOtherBucket['avg_price']['value']);
199		}
200
201		/**
202		* @group functional
203		*/
204	View Code Duplication	public function testSetOtherBucketKey(): void
		0 ignored issues – show Duplication introduced 2020-02-11 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
205		{
206		$agg = new Filters('by_color');
207		$agg->addFilter(new Term(['color' => 'red']), 'red');
208		$agg->setOtherBucket(true);
209		$agg->setOtherBucketKey('other_colors');
210
211		$avg = new Avg('avg_price');
212		$avg->setField('price');
213		$agg->addAggregation($avg);
214
215		$query = new Query();
216		$query->addAggregation($agg);
217
218		$results = $this->_getIndexForTest()->search($query)->getAggregation('by_color');
219
220		$resultsForRed = $results['buckets']['red'];
221		$resultsForOtherBucket = $results['buckets']['other_colors'];
222
223		$this->assertEquals(1, $resultsForRed['doc_count']);
224		$this->assertEquals(3, $resultsForOtherBucket['doc_count']);
225
226		$this->assertEquals(1, $resultsForRed['avg_price']['value']);
227		$this->assertEquals((5 + 8 + 3) / 3, $resultsForOtherBucket['avg_price']['value']);
228		}
229
230	View Code Duplication	protected function _getIndexForTest(): Index
		0 ignored issues – show Duplication introduced 2020-02-13 18:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
231		{
232		$index = $this->_createIndex('filter');
233
234		$index->addDocuments([
235		new Document(1, ['price' => 5, 'color' => 'blue']),
236		new Document(2, ['price' => 8, 'color' => 'blue']),
237		new Document(3, ['price' => 1, 'color' => 'red']),
238		new Document(4, ['price' => 3, 'color' => 'green']),
239		]);
240
241		$index->refresh();
242
243		return $index;
244		}
245		}
246

ruflin / Elastica

Push — master ( 9146c8...39ecb4 )

FiltersTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like