WildcardTest::testSearchWithAnalyzer() - Code Metrics - Inspection of "Adding new ES7 'case_insensitive' param to Wildcar..." - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1894)

unknown

created 2020-12-28 16:03 UTC

WildcardTest::testSearchWithAnalyzer() B

↳ Parent: WildcardTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
rs	8.9599
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Elastica\Test\Query;

use Elastica\Document;
use Elastica\Mapping;
use Elastica\Query\Wildcard;
use Elastica\Test\Base as BaseTest;

/**
 * @internal
 */
class WildcardTest extends BaseTest
{
    /**
     * @group unit
     */
    public function testConstruct(): void
    {
        $wildcard = new Wildcard('name', 'aaa*');

        $data = $wildcard->getParam('name');
        $this->assertIsArray($data);

        $this->assertSame('aaa*', $data['value']);
        $this->assertSame(1.0, $data['boost']);
    }

    /**
     * @group unit
     */
    public function testToArray(): void
    {
        $wildcard = new Wildcard('name', 'value*', 2.0);
        $wildcard->setRewrite(Wildcard::REWRITE_SCORING_BOOLEAN);

        $expectedArray = [
            'wildcard' => [
                'name' => [
                    'value' => 'value*',
                    'boost' => 2.0,
                    'rewrite' => 'scoring_boolean',
                    'case_insensitive' => false,
                ],
            ],
        ];

        $this->assertEquals($expectedArray, $wildcard->toArray());
    }

    /**
     * @group functional
     */
    public function testSearchWithAnalyzer(): void
    {
        $client = $this->_getClient();
        $index = $client->getIndex('test');

        $indexParams = [
            'settings' => [
                'analysis' => [
                    'analyzer' => [
                        'lw' => [
                            'type' => 'custom',
                            'tokenizer' => 'keyword',
                            'filter' => ['lowercase'],
                        ],
                    ],
                ],
            ],
        ];

        $index->create($indexParams, ['recreate' => true]);

        $mapping = new Mapping([
            'name' => ['type' => 'text', 'analyzer' => 'lw'],
        ]);
        $index->setMapping($mapping);

        $index->addDocuments([
            new Document(1, ['name' => 'Basel-Stadt']),
            new Document(2, ['name' => 'New York']),
            new Document(3, ['name' => 'Baden']),
            new Document(4, ['name' => 'Baden Baden']),
            new Document(5, ['name' => 'New Orleans']),
        ]);

        $index->refresh();

        $query = new Wildcard('name', 'ba*');
        $resultSet = $index->search($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(3, $resultSet->count());

        $query = new Wildcard('name', 'baden*');
        $resultSet = $index->search($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(2, $resultSet->count());

        $query = new Wildcard('name', 'baden b*');
        $resultSet = $index->search($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(1, $resultSet->count());

        $query = new Wildcard('name', 'baden bas*');
        $resultSet = $index->search($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(0, $resultSet->count());
    }

    /**
     * @group functional
     */
    public function testCaseInsensitive(): void
    {
        foreach ([true, false] as $expected) {
            $expectedArray = [
                'wildcard' => [
                    'name' => [
                        'value' => 'exampl*',
                        'boost' => 1.0,
                        'rewrite' => 'scoring_boolean',
                        'case_insensitive' => $expected,
                    ],
                ],
            ];

            $query = new Wildcard('name', 'exampl*', 1.0, true);
            $this->assertEquals($expectedArray, $query->toArray());

            $query->setCaseInsensitive($expected);
            $this->assertEquals($expectedArray, $query->toArray());
        }
    }
}


1			<?php
2
3			namespace Elastica\Test\Query;
4
5			use Elastica\Document;
6			use Elastica\Mapping;
7			use Elastica\Query\Wildcard;
8			use Elastica\Test\Base as BaseTest;
9
10			/**
11			* @internal
12			*/
13			class WildcardTest extends BaseTest
14			{
15			/**
16			* @group unit
17			*/
18			public function testConstruct(): void
19			{
20			$wildcard = new Wildcard('name', 'aaa*');
21
22			$data = $wildcard->getParam('name');
23			$this->assertIsArray($data);
24
25			$this->assertSame('aaa*', $data['value']);
26			$this->assertSame(1.0, $data['boost']);
27			}
28
29			/**
30			* @group unit
31			*/
32			public function testToArray(): void
33			{
34			$wildcard = new Wildcard('name', 'value*', 2.0);
35			$wildcard->setRewrite(Wildcard::REWRITE_SCORING_BOOLEAN);
36
37			$expectedArray = [
38			'wildcard' => [
39			'name' => [
40			'value' => 'value*',
41			'boost' => 2.0,
42			'rewrite' => 'scoring_boolean',
43			'case_insensitive' => false,
44			],
45			],
46			];
47
48			$this->assertEquals($expectedArray, $wildcard->toArray());
49			}
50
51			/**
52			* @group functional
53			*/
54			public function testSearchWithAnalyzer(): void
55			{
56			$client = $this->_getClient();
57			$index = $client->getIndex('test');
58
59			$indexParams = [
60			'settings' => [
61			'analysis' => [
62			'analyzer' => [
63			'lw' => [
64			'type' => 'custom',
65			'tokenizer' => 'keyword',
66			'filter' => ['lowercase'],
67			],
68			],
69			],
70			],
71			];
72
73			$index->create($indexParams, ['recreate' => true]);
74
75			$mapping = new Mapping([
76			'name' => ['type' => 'text', 'analyzer' => 'lw'],
77			]);
78			$index->setMapping($mapping);
79
80			$index->addDocuments([
81			new Document(1, ['name' => 'Basel-Stadt']),
82			new Document(2, ['name' => 'New York']),
83			new Document(3, ['name' => 'Baden']),
84			new Document(4, ['name' => 'Baden Baden']),
85			new Document(5, ['name' => 'New Orleans']),
86			]);
87
88			$index->refresh();
89
90			$query = new Wildcard('name', 'ba*');
91			$resultSet = $index->search($query);
			0 ignored issues – show Documentation introduced 2020-12-28 16:02 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query\Wildcard>`, but the function expects a `string\|array\|object<Elastica\Query>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
92
93			$this->assertEquals(3, $resultSet->count());
94
95			$query = new Wildcard('name', 'baden*');
96			$resultSet = $index->search($query);
			0 ignored issues – show Documentation introduced 2020-12-28 16:02 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query\Wildcard>`, but the function expects a `string\|array\|object<Elastica\Query>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97
98			$this->assertEquals(2, $resultSet->count());
99
100			$query = new Wildcard('name', 'baden b*');
101			$resultSet = $index->search($query);
			0 ignored issues – show Documentation introduced 2020-12-28 16:02 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query\Wildcard>`, but the function expects a `string\|array\|object<Elastica\Query>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
102
103			$this->assertEquals(1, $resultSet->count());
104
105			$query = new Wildcard('name', 'baden bas*');
106			$resultSet = $index->search($query);
			0 ignored issues – show Documentation introduced 2020-12-28 16:02 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query\Wildcard>`, but the function expects a `string\|array\|object<Elastica\Query>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107
108			$this->assertEquals(0, $resultSet->count());
109			}
110
111			/**
112			* @group functional
113			*/
114			public function testCaseInsensitive(): void
115			{
116			foreach ([true, false] as $expected) {
117			$expectedArray = [
118			'wildcard' => [
119			'name' => [
120			'value' => 'exampl*',
121			'boost' => 1.0,
122			'rewrite' => 'scoring_boolean',
123			'case_insensitive' => $expected,
124			],
125			],
126			];
127
128			$query = new Wildcard('name', 'exampl*', 1.0, true);
129			$this->assertEquals($expectedArray, $query->toArray());
130
131			$query->setCaseInsensitive($expected);
132			$this->assertEquals($expectedArray, $query->toArray());
133			}
134			}
135			}
136

ruflin / Elastica

Pull Request — master (#1894)

WildcardTest::testSearchWithAnalyzer() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like