Issues in KeyedTrait.php - Fixed Issues - Inspection of "Allow psr/log 2.0 + 3.0 (#1971)" - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbc962...e137d9 )

by Nicolas

created 2021-08-05 10:32 UTC

src/Aggregation/Traits/KeyedTrait.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Elastica\Aggregation\Traits;

trait KeyedTrait
{
    /**
     * Setting the keyed flag to true associates a unique string key
     * with each bucket and returns the result as a hash rather than an array.
     *
     * @return $this
     */
    public function setKeyed(bool $keyed = true): self
    {
        return $this->setParam('keyed', $keyed);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Elastica\Aggregation\Traits;
4
5			trait KeyedTrait
6			{
7			/**
8			* Setting the keyed flag to true associates a unique string key
9			* with each bucket and returns the result as a hash rather than an array.
10			*
11			* @return $this
12			*/
13			public function setKeyed(bool $keyed = true): self
14			{
15			return $this->setParam('keyed', $keyed);
			0 ignored issues – show Bug introduced 2020-11-23 17:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `setParam()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17			}
18

ruflin / Elastica

Push — master ( cbc962...e137d9 )

src/Aggregation/Traits/KeyedTrait.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like