SplitProcessorTest::testSplitWithNonDefaultOptions() - Code Metrics - Inspection of "Deprecate unsuffixed processor classes" - ruflin/Elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1893)

unknown

created 2020-12-07 17:35 UTC

testSplitWithNonDefaultOptions() A

↳ Parent: SplitProcessorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Elastica\Test\Processor;

use Elastica\Bulk;
use Elastica\Document;
use Elastica\Processor\SplitProcessor;
use Elastica\Test\BasePipeline as BasePipelineTest;

/**
 * @internal
 */
class SplitProcessorTest extends BasePipelineTest

{
    /**
     * @group unit
     */
    public function testSplit(): void
    {
        $processor = new SplitProcessor('joined_array_field', '-');

        $expected = [
            'split' => [
                'field' => 'joined_array_field',
                'separator' => '-',
            ],
        ];

        $this->assertEquals($expected, $processor->toArray());
    }

    /**
     * @group unit
     */
    public function testSplitWithNonDefaultOptions(): void
    {
        $processor = new SplitProcessor('joined_array_field', '-');
        $processor->setIgnoreMissing(true);

        $expected = [
            'split' => [
                'field' => 'joined_array_field',
                'separator' => '-',
                'ignore_missing' => true,
            ],
        ];

        $this->assertEquals($expected, $processor->toArray());
    }

    /**
     * @group functional
     */
    public function testSplitField(): void
    {
        $split = new SplitProcessor('name', '&');

        $pipeline = $this->_createPipeline('my_custom_pipeline', 'pipeline for Split');
        $pipeline->addProcessor($split)->create();

        $index = $this->_createIndex();
        $bulk = new Bulk($index->getClient());
        $bulk->setIndex($index);

        $bulk->addDocuments([
            new Document(null, ['name' => 'nicolas&ruflin']),
        ]);
        $bulk->setRequestParam('pipeline', 'my_custom_pipeline');

        $bulk->send();
        $index->refresh();

        $result = $index->search('*');

        $this->assertCount(1, $result->getResults());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $results = $result->getResults();
        $this->assertSame(['nicolas', 'ruflin'], ($results[0]->getHit())['_source']['name']);
    }
}


1		<?php
2
3		namespace Elastica\Test\Processor;
4
5		use Elastica\Bulk;
6		use Elastica\Document;
7		use Elastica\Processor\SplitProcessor;
8		use Elastica\Test\BasePipeline as BasePipelineTest;
9
10		/**
11		* @internal
12		*/
13	View Code Duplication	class SplitProcessorTest extends BasePipelineTest
		0 ignored issues – show Duplication introduced 2020-12-07 15:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		/**
16		* @group unit
17		*/
18		public function testSplit(): void
19		{
20		$processor = new SplitProcessor('joined_array_field', '-');
21
22		$expected = [
23		'split' => [
24		'field' => 'joined_array_field',
25		'separator' => '-',
26		],
27		];
28
29		$this->assertEquals($expected, $processor->toArray());
30		}
31
32		/**
33		* @group unit
34		*/
35		public function testSplitWithNonDefaultOptions(): void
36		{
37		$processor = new SplitProcessor('joined_array_field', '-');
38		$processor->setIgnoreMissing(true);
39
40		$expected = [
41		'split' => [
42		'field' => 'joined_array_field',
43		'separator' => '-',
44		'ignore_missing' => true,
45		],
46		];
47
48		$this->assertEquals($expected, $processor->toArray());
49		}
50
51		/**
52		* @group functional
53		*/
54		public function testSplitField(): void
55		{
56		$split = new SplitProcessor('name', '&');
57
58		$pipeline = $this->_createPipeline('my_custom_pipeline', 'pipeline for Split');
59		$pipeline->addProcessor($split)->create();
60
61		$index = $this->_createIndex();
62		$bulk = new Bulk($index->getClient());
63		$bulk->setIndex($index);
64
65		$bulk->addDocuments([
66		new Document(null, ['name' => 'nicolas&ruflin']),
67		]);
68		$bulk->setRequestParam('pipeline', 'my_custom_pipeline');
69
70		$bulk->send();
71		$index->refresh();
72
73		$result = $index->search('*');
74
75		$this->assertCount(1, $result->getResults());
		0 ignored issues – show Documentation introduced 2020-10-15 17:08 UTC by Report Bug Copy Issue Report `$result->getResults()` is of type `array<integer,object<Elastica\Result>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76
77		$results = $result->getResults();
78		$this->assertSame(['nicolas', 'ruflin'], ($results[0]->getHit())['_source']['name']);
79		}
80		}
81

ruflin / Elastica

Pull Request — master (#1893)

testSplitWithNonDefaultOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like