The expression $scripts of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
23
$this->setScripts($scripts);
24
}
25
}
26
27
/**
28
* @param string $name Name of the Script field
29
* @param \Elastica\Script\AbstractScript $script
30
*
31
* @throws \Elastica\Exception\InvalidException
32
*
33
* @return $this
34
*/
35
public function addScript($name, AbstractScript $script)
36
{
37
if (!is_string($name) || !strlen($name)) {
38
throw new InvalidException('The name of a Script is required and must be a string');
39
}
40
$this->setParam($name, $script);
41
42
return $this;
43
}
44
45
/**
46
* @param \Elastica\Script\Script[]|array $scripts Associative array of string => Elastica\Script\Script
ruflin /
Elastica
Morten Hauberg
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.