EditController - Code Metrics - Inspection of "Edit and delete users" - rudolfcms/rudolf - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cceadc...3df73a )

by Mikołaj

created 2018-08-07 01:04 UTC

EditController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
dl	0
loc	52
rs	10
c	0
b	0
f	0
wmc	6
lcom	0
cbo	5

1 Method

Rating	Name	Duplication	Size	Complexity
B	edit()	0	44	6

<?php

namespace Rudolf\Modules\Users\One\Admin\Profile;

use Rudolf\Component\Alerts\Alert;
use Rudolf\Component\Alerts\AlertsCollection;
use Rudolf\Framework\Controller\AdminController;

class EditController extends AdminController
{
    /**
     * @param $id
     *
     * @throws \Exception
     */
    public function edit($id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model = new EditModel();

        if (!empty($_POST)) {
            if (!empty($_POST['password'])) {
                if (trim($_POST['password']) === $_POST['password_again'] && $model->updatePassword($id, $_POST['password'])) {
                    AlertsCollection::add(
                        new Alert(
                            'success',
                            'Zaktualizowano hasło'
                        )
                    );
                } else {
                    AlertsCollection::add(
                        new Alert(
                            'error',
                            'Podane hasła nie są identyczne!'
                        )
                    );
                }
            }

            if ($model->edit($id, $_POST)) {
                AlertsCollection::add(
                    new Alert(
                        'success',
                        'Zaktualizowano profil (bez zmiany hasła)'
                    )
                );
                $this->redirect(DIR.'/admin/users/edit/'.$id);
            }
            AlertsCollection::add(
                new Alert(
                    'error',
                    'Wystąpił nieoczekiwany błąd'
                )
            );
        }

        $view = new EditView();
        $view->display($model->getUserInfoById($id));
        $view->render();
    }
}


1			<?php
2
3			namespace Rudolf\Modules\Users\One\Admin\Profile;
4
5			use Rudolf\Component\Alerts\Alert;
6			use Rudolf\Component\Alerts\AlertsCollection;
7			use Rudolf\Framework\Controller\AdminController;
8
9			class EditController extends AdminController
10			{
11			/**
12			* @param $id
13			*
14			* @throws \Exception
15			*/
16			public function edit($id)
			0 ignored issues – show Coding Style introduced 2018-08-07 01:08 UTC by Report Bug Copy Issue Report `edit` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17			{
18			$model = new EditModel();
19
20			if (!empty($_POST)) {
21			if (!empty($_POST['password'])) {
22			if (trim($_POST['password']) === $_POST['password_again'] && $model->updatePassword($id, $_POST['password'])) {
23			AlertsCollection::add(
24			new Alert(
25			'success',
26			'Zaktualizowano hasło'
27			)
28			);
29			} else {
30			AlertsCollection::add(
31			new Alert(
32			'error',
33			'Podane hasła nie są identyczne!'
34			)
35			);
36			}
37			}
38
39			if ($model->edit($id, $_POST)) {
40			AlertsCollection::add(
41			new Alert(
42			'success',
43			'Zaktualizowano profil (bez zmiany hasła)'
44			)
45			);
46			$this->redirect(DIR.'/admin/users/edit/'.$id);
47			}
48			AlertsCollection::add(
49			new Alert(
50			'error',
51			'Wystąpił nieoczekiwany błąd'
52			)
53			);
54			}
55
56			$view = new EditView();
57			$view->display($model->getUserInfoById($id));
58			$view->render();
59			}
60			}
61

rudolfcms / rudolf

Push — master ( cceadc...3df73a )

EditController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like