View GitHub Repository rudolf

Schedule Inspection
Subscribe
Completed
Push — master ( d015d4...c50906 )
by Mikołaj
02:42
created

AddController::add()   B

↳ Parent: AddController

Complexity

Conditions 3
Paths 3

Size

Total Lines 32
Code Lines 25

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 3
eloc 25
c 0
b 0
f 0
nc 3
nop 0
dl 0
loc 32
rs 8.8571
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Rudolf\Modules\Appearance\Menu;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Rudolf\Component\Alerts\Alert;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Rudolf\Component\Alerts\AlertsCollection;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
use Rudolf\Framework\Controller\AdminController;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
use Rudolf\Framework\Model\FrontModel;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
class AddController extends AdminController

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
     * @throws \Exception

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
     */

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    public function add()

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
add uses the super-global variable $_POST which is generally not recommended.
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Instead of super-globals, we recommend to explicitly inject the dependencies
of your class. This makes your code less dependent on global state and it
becomes generally more testable:


// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
        if (isset($_POST['add'])) {

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
            $model = new AddModel();

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
            $id = $model->add($_POST);

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
            if ($id) {

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
                AlertsCollection::add(new Alert(

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
                    'success',

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
                    'Poprawnie dodano!'

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
                ));

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
                $this->redirectTo(DIR.'/admin/appearance/menu/edit/'.$id);

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
                return;

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
            AlertsCollection::add(new Alert(

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
                'error',

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
                'Coś się zepsuło!'

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
            ));

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
        $view = new AddView();

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
        $view->display(new MenuItem([

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                
            'id' => -1,

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                                                    
                
                
                
            'parent_id' => 0,

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
            'title' => '',

            


            
                                                        
            
                                    
            
            

                
                    39
                

                                    
                                                    
                
                
                
            'slug' => '',

            


            
                                                        
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
            'caption' => '',

            


            
                                                        
            
                                    
            
            

                
                    41
                

                                    
                                                    
                
                
                
            'menu_type' => 'main',

            


            
                                                        
            
                                    
            
            

                
                    42
                

                                    
                                                    
                
                
                
            'item_type' => '',

            


            
                                                        
            
                                    
            
            

                
                    43
                

                                    
                                                    
                
                
                
            'position' => 0,

            


            
                                                        
            
                                    
            
            

                
                    44
                

                                    
                                                    
                
                
                
        ]), (new Model())->getTypes(), (new FrontModel())->getMenuItems());

            


            
                                                        
            
                                    
            
            

                
                    45
                

                                    
                                                    
                
                
                
        $view->render('admin');

            


            
                                                        
            
                                    
            
            

                
                    46
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    47
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    48