TypeEditController::edit() - Code Metrics - Inspection of "Add menu types manage feature" - rudolfcms/rudolf - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d7cd82...c94b19 )

by Mikołaj

created 2018-08-04 14:49 UTC

TypeEditController::edit() A

↳ Parent: TypeEditController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	14
Ratio	60.87 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	1
dl	14
loc	23
rs	9.552
c	0
b	0
f	0

<?php

namespace Rudolf\Modules\Appearance\Menu\Type;

use Rudolf\Component\Alerts\Alert;
use Rudolf\Component\Alerts\AlertsCollection;
use Rudolf\Framework\Controller\AdminController;

class TypeEditController extends AdminController
{
    /**
     * @param $id
     *
     * @throws \Exception
     */
    public function edit($id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model = new TypeEditModel();
        $view = new TypeEditView();

        if (isset($_POST['update'])) {

            if ($model->edit($id, $_POST)) {
                AlertsCollection::add(new Alert(
                    'success',
                    'Zaktualizowano!'
                ));
                $this->redirectTo(DIR.'/admin/appearance/menu/edit-type/'.$id);
                return;
            }
            AlertsCollection::add(new Alert(
                'error',
                'Coś się zepsuło!'
            ));
        }

        $view->display($model->getMenuTypeById($id));
        $view->render('admin');
    }
}


1		<?php
2
3		namespace Rudolf\Modules\Appearance\Menu\Type;
4
5		use Rudolf\Component\Alerts\Alert;
6		use Rudolf\Component\Alerts\AlertsCollection;
7		use Rudolf\Framework\Controller\AdminController;
8
9		class TypeEditController extends AdminController
10		{
11		/**
12		* @param $id
13		*
14		* @throws \Exception
15		*/
16		public function edit($id)
		0 ignored issues – show Coding Style introduced 2018-08-04 14:54 UTC by Report Bug Copy Issue Report `edit` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17		{
18		$model = new TypeEditModel();
19		$view = new TypeEditView();
20
21	View Code Duplication	if (isset($_POST['update'])) {
		0 ignored issues – show Duplication introduced 2018-08-04 14:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		if ($model->edit($id, $_POST)) {
23		AlertsCollection::add(new Alert(
24		'success',
25		'Zaktualizowano!'
26		));
27		$this->redirectTo(DIR.'/admin/appearance/menu/edit-type/'.$id);
28		return;
29		}
30		AlertsCollection::add(new Alert(
31		'error',
32		'Coś się zepsuło!'
33		));
34		}
35
36		$view->display($model->getMenuTypeById($id));
37		$view->render('admin');
38		}
39		}
40

rudolfcms / rudolf

Push — master ( d7cd82...c94b19 )

TypeEditController::edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like