AddView::addGallery() - Code Metrics - Inspection of "Delete cookie test" - rudolfcms/rudolf - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (b4ab83)

by Mikołaj

created 2017-01-15 23:54 UTC

AddView::addGallery() A

↳ Parent: AddView

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	13
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	1
dl	13
loc	13
rs	9.4285
c	0
b	0
f	0

<?php

namespace Rudolf\Modules\Galleries\One\Admin;

use Rudolf\Framework\View\AdminView;

class AddView extends AdminView

{
    /**
     * Set data to add gallery.
     *
     * @param array $gallery
     */
    public function addGallery($gallery)
    {
        $this->gallery = new Gallery($gallery);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->pageTitle = _('Add gallery');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->head->setTitle($this->pageTitle);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->path = DIR.'/admin/galleries/add';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->templateType = 'add';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->template = 'gallery-one';

    }
}


1		<?php
2
3		namespace Rudolf\Modules\Galleries\One\Admin;
4
5		use Rudolf\Framework\View\AdminView;
6
7	View Code Duplication	class AddView extends AdminView
		0 ignored issues – show Duplication introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* Set data to add gallery.
11		*
12		* @param array $gallery
13		*/
14		public function addGallery($gallery)
15		{
16		$this->gallery = new Gallery($gallery);
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `gallery` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17
18		$this->pageTitle = _('Add gallery');
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `pageTitle` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19		$this->head->setTitle($this->pageTitle);
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `head` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20
21		$this->path = DIR.'/admin/galleries/add';
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `path` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22
23		$this->templateType = 'add';
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `templateType` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24
25		$this->template = 'gallery-one';
		0 ignored issues – show Bug introduced 2017-01-15 23:57 UTC by Report Bug Copy Issue Report The property `template` does not seem to exist. Did you mean `templateType`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
26		}
27		}
28

rudolfcms / rudolf

Branch — master (b4ab83)

AddView::addGallery() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like