add uses the super-global variable $_POST which is generally not recommended.
Instead of super-globals, we recommend to explicitly inject the dependencies
of your class. This makes your code less dependent on global state and it
becomes generally more testable:
// BadclassRouter{publicfunctiongenerate($path){return$_SERVER['HOST'].$path;}}// BetterclassRouter{private$host;publicfunction__construct($host){$this->host=$host;}publicfunctiongenerate($path){return$this->host.$path;}}classController{publicfunctionmyAction(Request$request){// Instead of$page=isset($_GET['page'])?intval($_GET['page']):1;// Better (assuming you use the Symfony2 request)$page=$request->query->get('page',1);}}
Loading history...
10
{
11
$model = new AddModel();
12
13
$form = new AddForm();
14
$form->setModel($model);
15
16
// if data was send
17
if (!empty($_POST)) {
18
$form->handle($_POST);
19
20
if ($form->isValid() and $id = $form->add($_POST)) {
The call to AddForm::add() has too many arguments starting with $_POST.
This check compares calls to functions or methods with their respective definitions.
If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the
check may pick up the wrong definition and report false positives. One codebase
where this has been known to happen is Wordpress.
In this case you can add the @ignorePhpDoc
annotation to the duplicate definition and it will be ignored.
Using logical operators such as and instead of && is generally not recommended.
PHP has two types of connecting operators (logical operators, and boolean operators):
Logical Operators
Boolean Operator
AND - meaning
and
&&
OR - meaning
or
||
The difference between these is the order in which they are executed. In most cases,
you would want to use a boolean operator like &&, or ||.
Let’s take a look at a few examples:
// Logical operators have lower precedence:$f=falseortrue;// is executed like this:($f=false)ortrue;// Boolean operators have higher precedence:$f=false||true;// is executed like this:$f=(false||true);
Logical Operators are used for Control-Flow
One case where you explicitly want to use logical operators is for control-flow
such as this:
$x===5ordie('$x must be 5.');// Instead ofif($x!==5){die('$x must be 5.');}
Since die introduces problems of its own, f.e. it makes our code hardly
testable, and prevents any kind of more sophisticated error handling; you probably
do not want to use this in real-world code. Unfortunately, logical operators
cannot be combined with throw at this point:
// The following is currently a parse error.$x===5orthrownewRuntimeException('$x must be 5.');
These limitations lead to logical operators rarely being of use in current
PHP code.
rudolfcms /
rudolf
Loading history...
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: