Issues in test.class.php - Fixed Issues - Inspection of "Complete refactor I" - rudiedirkx/imap-reader - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7ad33...cd335b )

by Rudie

created 2016-04-02 18:51 UTC

test.class.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<pre><?php

require 'env.php';
require 'IMAP.php';

$mbox = new IMAPMailbox(IMAP_TEST_HOST, IMAP_TEST_USER, IMAP_TEST_PASS, 'INBOX', ['novalidate-cert']);
print_r($mbox);

$messages = $mbox->messages(array('seen' => false, 'offset' => 0, 'limit' => 3, 'newestFirst' => true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
#print_r($messages);

foreach ( $messages AS $message ) {

	echo "------------------------------------------------------------------------\n";

	echo "Subject: ".$message->subject()."\n";

	$parts = $message->parts();
//	print_r($parts);

	print_r($message);

	foreach ( $message->attachments AS $attachment ) {
		var_dump($attachment->save(__DIR__.'/attachments/'));
	}

	exit;

}



1			<pre><?php
2
3			require 'env.php';
4			require 'IMAP.php';
5
6			$mbox = new IMAPMailbox(IMAP_TEST_HOST, IMAP_TEST_USER, IMAP_TEST_PASS, 'INBOX', ['novalidate-cert']);
7			print_r($mbox);
8
9			$messages = $mbox->messages(array('seen' => false, 'offset' => 0, 'limit' => 3, 'newestFirst' => true));
			0 ignored issues – show Documentation introduced 2016-03-31 22:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('seen' => false, '... 'newestFirst' => true)` is of type `array<string,integer\|boo...ewestFirst":"boolean"}>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
10			#print_r($messages);
11
12			foreach ( $messages AS $message ) {
13
14			echo "------------------------------------------------------------------------\n";
15
16			echo "Subject: ".$message->subject()."\n";
17
18			$parts = $message->parts();
19			// print_r($parts);
20
21			print_r($message);
22
23			foreach ( $message->attachments AS $attachment ) {
24			var_dump($attachment->save(__DIR__.'/attachments/'));
25			}
26
27			exit;
28
29			}
30
31

rudiedirkx / imap-reader

Push — master ( f7ad33...cd335b )

test.class.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like