IMAPMailbox::messages() - Code Metrics - Inspection of "Complete refactor I" - rudiedirkx/imap-reader - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7ad33...cd335b )

by Rudie

created 2016-04-02 18:51 UTC

IMAPMailbox::messages() C

↳ Parent: IMAPMailbox

Complexity

Conditions	8
Paths	14

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	34
rs	5.3846
cc	8
eloc	21
nc	14
nop	1

<?php

namespace rdx\imap;

class IMAPMailbox {

	public $server = '';
	public $username = '';
	public $password = '';
	public $mailbox = '';

	protected $imap; // IMAP resource

	public function __construct( $server, $username, $password, $mailbox = 'INBOX', $flags = array() ) {
		$this->server = $server;
		$this->username = $username;
		$this->password = $password;
		$this->mailbox = $mailbox;
		$this->flags = $flags;
class MyClass { }

$x = new MyClass();
$x->foo = true;

		// $this->connect();

	}

	public function connect() {
		if ( !$this->imap ) {
			$server = $this->server;
			if ( $this->flags ) {
				$server .= '/' . implode('/', $this->flags);
			}

			$mailbox = '{'.$server.'}'.$this->mailbox;
			$this->imap = imap_open($mailbox, $this->username, $this->password);
		}

		return $this->imap;
	}

	public function imap() {
		return $this->imap;
	}

	public function headers( $newestFirst = true ) {
		$this->connect();

		$headers = imap_headers($this->imap());

		if ( $newestFirst ) {
			$headers = array_reverse($headers);
		}

		return $headers;
	}

	public function messages( array $options = [] ) {
		$options += array(
			'offset' => 0,
			'limit' => 0,
			'seen' => null,
			'newestFirst' => true,
		);

		$headers = $this->headers($options['newestFirst']);

		$messages = array();
		$eligibles = 0;
		foreach ( $headers AS $n => $header ) {
			if ( preg_match('/(U?)\s+(\d+)\)/', $header, $match) ) {
				$unseen = (bool)trim($match[1]);
				$msgNum = (int)$match[2];

				$eligible = $options['seen'] === null || $unseen != $options['seen'];
				if ( $eligible ) {
					$eligibles++;

					if ( $eligibles > $options['offset'] ) {
						$messages[] = new IMAPMessage($this, $msgNum, $header, $unseen);
					}
				}

				if ( $options['limit'] && isset($messages[$options['limit']-1]) ) {
					break;
				}
			}
		}

		return $messages;
	}

}


1			<?php
2
3			namespace rdx\imap;
4
5			class IMAPMailbox {
6
7			public $server = '';
8			public $username = '';
9			public $password = '';
10			public $mailbox = '';
11
12			protected $imap; // IMAP resource
13
14			public function __construct( $server, $username, $password, $mailbox = 'INBOX', $flags = array() ) {
15			$this->server = $server;
16			$this->username = $username;
17			$this->password = $password;
18			$this->mailbox = $mailbox;
19			$this->flags = $flags;
			0 ignored issues – show Bug introduced 2016-04-02 18:53 UTC by Report Bug Copy Issue Report The property `flags` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20
21			// $this->connect();
			1 ignored issue – show Unused Code Comprehensibility introduced 2016-04-02 18:53 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
22			}
23
24			public function connect() {
25			if ( !$this->imap ) {
26			$server = $this->server;
27			if ( $this->flags ) {
28			$server .= '/' . implode('/', $this->flags);
29			}
30
31			$mailbox = '{'.$server.'}'.$this->mailbox;
32			$this->imap = imap_open($mailbox, $this->username, $this->password);
33			}
34
35			return $this->imap;
36			}
37
38			public function imap() {
39			return $this->imap;
40			}
41
42			public function headers( $newestFirst = true ) {
43			$this->connect();
44
45			$headers = imap_headers($this->imap());
46
47			if ( $newestFirst ) {
48			$headers = array_reverse($headers);
49			}
50
51			return $headers;
52			}
53
54			public function messages( array $options = [] ) {
55			$options += array(
56			'offset' => 0,
57			'limit' => 0,
58			'seen' => null,
59			'newestFirst' => true,
60			);
61
62			$headers = $this->headers($options['newestFirst']);
63
64			$messages = array();
65			$eligibles = 0;
66			foreach ( $headers AS $n => $header ) {
67			if ( preg_match('/(U?)\s+(\d+)\)/', $header, $match) ) {
68			$unseen = (bool)trim($match[1]);
69			$msgNum = (int)$match[2];
70
71			$eligible = $options['seen'] === null \|\| $unseen != $options['seen'];
72			if ( $eligible ) {
73			$eligibles++;
74
75			if ( $eligibles > $options['offset'] ) {
76			$messages[] = new IMAPMessage($this, $msgNum, $header, $unseen);
77			}
78			}
79
80			if ( $options['limit'] && isset($messages[$options['limit']-1]) ) {
81			break;
82			}
83			}
84			}
85
86			return $messages;
87			}
88
89			}
90

rudiedirkx / imap-reader

Push — master ( f7ad33...cd335b )

IMAPMailbox::messages() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like