rudiedirkx / fuelly

lib/fuelly/src/Client.php

Doc Comments +1 added lines

@@ -328,6 +328,7 @@
 
 	/**
 	 * HTTP POST
+	 * @param string $uri
 	 */
 	public function _post( $uri, $options = array() ) {
 		return $this->_http($uri, $options + array('method' => 'POST'));

Spacing +52 added lines, -52 removed lines

@@ -27,7 +27,7 @@ 
 	/**
 	 * Dependency constructor
 	 */
-	public function __construct( WebAuth $auth, InputConversion $input ) {
+	public function __construct(WebAuth $auth, InputConversion $input) {
 		$this->auth = $auth;
 		$this->input = $input;
 	}
@@ -43,16 +43,16 @@ 
 	/**
 	 *
 	 */
-	public function getFuelUp( $id ) {
+	public function getFuelUp($id) {
 		$fuelup = compact('id');
 
-		$response = $this->_get('fuelups/' . $id . '/edit');
+		$response = $this->_get('fuelups/'.$id.'/edit');
 
 		preg_match_all('#<input[\s\S]+?name="([^"]+)"[\s\S]+?>#', $response->body, $matches, PREG_SET_ORDER);
 		foreach ($matches as $match) {
-			if ( in_array($match[1], array('_token', 'miles_last_fuelup', 'price_per_unit', 'amount', 'fuelup_date')) ) {
+			if (in_array($match[1], array('_token', 'miles_last_fuelup', 'price_per_unit', 'amount', 'fuelup_date'))) {
 				preg_match('#value="([^"]+)"#', $match[0], $match2);
-				$fuelup[ $match[1] ] = $match2[1];
+				$fuelup[$match[1]] = $match2[1];
 			}
 		}
 
@@ -65,17 +65,17 @@ 
 	/**
 	 *
 	 */
-	public function updateFuelUp( $id, $data ) {
+	public function updateFuelUp($id, $data) {
 		$data = $this->_validateFuelUpData($data);
 		unset($data['id']);
 
-		if ( !isset($data['_token']) ) {
-			$response = $this->_get('fuelups/' . $id . '/edit');
+		if (!isset($data['_token'])) {
+			$response = $this->_get('fuelups/'.$id.'/edit');
 			$token = $this->extractFormToken($response->body);
 		}
 
 		$data['_method'] = 'PUT';
-		$response = $this->_post('fuelups/' . $id, array(
+		$response = $this->_post('fuelups/'.$id, array(
 			'data' => $data,
 		));
 		return $response->code == 302;
@@ -84,7 +84,7 @@ 
 	/**
 	 *
 	 */
-	public function _validateFuelUpData( $data ) {
+	public function _validateFuelUpData($data) {
 		$data += array(
 			'errorlevel' => 2,
 			'price_per_unit' => '',
@@ -101,8 +101,8 @@ 
 
 		$required = array('usercar_id', 'miles_last_fuelup', 'amount');
 		$missing = array_diff($required, array_keys(array_filter($data)));
-		if ( $missing ) {
-			throw new InvalidArgumentException('Missing params: ' . implode(', ', $missing));
+		if ($missing) {
+			throw new InvalidArgumentException('Missing params: '.implode(', ', $missing));
 		}
 
 		return $data;
@@ -111,19 +111,19 @@ 
 	/**
 	 *
 	 */
-	public function getFuelUpsWithIds( Vehicle $vehicle, $limit = 15 ) {
+	public function getFuelUpsWithIds(Vehicle $vehicle, $limit = 15) {
 		$query = http_build_query(array(
 			'iDisplayStart' => 0,
 			'iDisplayLength' => $limit,
 			'sSortDir_0' => 'desc',
 			'usercar_id' => $vehicle->id,
 		));
-		$response = $this->_get('ajax/fuelup-log?' . $query);
-		if ( $response->code == 200 ) {
-			if ( $response->response ) {
+		$response = $this->_get('ajax/fuelup-log?'.$query);
+		if ($response->code == 200) {
+			if ($response->response) {
 				$fuelups = array();
-				foreach ( $response->response['aaData'] as $fuelup ) {
-					if ( preg_match('#fuelups/(\d+)/edit#', $fuelup[0], $match) ) {
+				foreach ($response->response['aaData'] as $fuelup) {
+					if (preg_match('#fuelups/(\d+)/edit#', $fuelup[0], $match)) {
 						$fuelup = array(
 							'id' => $match[1],
 							'usercar_id' => $vehicle->id,
@@ -132,7 +132,7 @@ 
 							'amount' => $fuelup[4][0],
 						);
 
-						$fuelups[ $fuelup['id'] ] = FuelUp::createFromDetail($vehicle, $fuelup);
+						$fuelups[$fuelup['id']] = FuelUp::createFromDetail($vehicle, $fuelup);
 					}
 				}
 
@@ -149,21 +149,21 @@ 
 	/**
 	 *
 	 */
-	public function getAllFuelups( Vehicle $vehicle ) {
-		$response = $this->_get('car/make/model/2001/username/' . $vehicle->id . '/export');
-		if ( $token = $this->extractFormToken($response->body) ) {
+	public function getAllFuelups(Vehicle $vehicle) {
+		$response = $this->_get('car/make/model/2001/username/'.$vehicle->id.'/export');
+		if ($token = $this->extractFormToken($response->body)) {
 			$response = $this->_post('exportfuelups', array(
 				'data' => array(
 					'_token' => $token,
 					'usercar_id' => $vehicle->id,
 				),
 			));
-			if ( $response->code == 200 ) {
+			if ($response->code == 200) {
 				$lines = array_filter(preg_split('#[\r\n]+#', $response->body));
 				$header = $rows = array();
 				foreach ($lines as $line) {
 					$row = array_map('trim', str_getcsv($line));
-					if ( !$header ) {
+					if (!$header) {
 						$header = $row;
 					}
 					else {
@@ -179,26 +179,26 @@ 
 	/**
 	 *
 	 */
-	public function addFuelUp( $data ) {
+	public function addFuelUp($data) {
 		$data = $this->_validateFuelUpData($data);
 
 		// GET /fuelups/create
 		$response = $this->_get('fuelups/create');
 
-		if ( $token = $this->extractFormToken($response->body) ) {
+		if ($token = $this->extractFormToken($response->body)) {
 			$data['_token'] = $token;
 
 			// POST /fuelups/create
 			$response = $this->_post('fuelups', array(
 				'data' => $data,
 			));
-			if ( $response->code == 302 ) {
+			if ($response->code == 302) {
 				$response = $this->_get($response->headers['location'][0]);
 
 				// Take new fuelup ID from response and add it
-				if ( $response->code == 200 ) {
-					$regex = '#' . preg_quote($this->base, '#') . 'fuelups/(\d+)/edit#';
-					if ( preg_match($regex, $response->body, $match) ) {
+				if ($response->code == 200) {
+					$regex = '#'.preg_quote($this->base, '#').'fuelups/(\d+)/edit#';
+					if (preg_match($regex, $response->body, $match)) {
 						$response->fuelup_id = $match[1];
 					}
 				}
@@ -211,7 +211,7 @@ 
 	/**
 	 *
 	 */
-	public function getVehicle( $id ) {
+	public function getVehicle($id) {
 		$vehicles = $this->getVehicles();
 		return @$vehicles[$id];
 	}
@@ -227,11 +227,11 @@ 
 	/**
 	 *
 	 */
-	protected function extractVehicles( $html ) {
+	protected function extractVehicles($html) {
 		$regex = '#<ul class="dashboard-vehicle" data-clickable="([^"]+)">[\w\W]+?</ul>#';
 		$vehicles = array();
-		if ( preg_match_all($regex, $html, $matches) ) {
-			foreach ( $matches[0] as $i => $html ) {
+		if (preg_match_all($regex, $html, $matches)) {
+			foreach ($matches[0] as $i => $html) {
 				$url = $matches[1][$i];
 
 				preg_match('#/(\d+)$#', $url, $match);
@@ -241,7 +241,7 @@ 
 				$name = htmlspecialchars_decode($match[1]);
 
 				preg_match("#:\s*url\('/([^']+)'\)#", $html, $match);
-				$image = $this->base . $match[1];
+				$image = $this->base.$match[1];
 
 				preg_match("#data-trend='([^']+)'#", $html, $match);
 				$trend = @json_decode($match[1], true) ?: false;
@@ -257,14 +257,14 @@ 
 	 *
 	 */
 	public function logIn() {
-		if ( !$this->auth->mail || !$this->auth->pass ) {
+		if (!$this->auth->mail || !$this->auth->pass) {
 			return false;
 		}
 
 		// GET /login
 		$response = $this->_get('login', array('login' => true));
 
-		if ( $token = $this->extractFormToken($response->body) ) {
+		if ($token = $this->extractFormToken($response->body)) {
 			// POST /login
 			$response = $this->_post('login', array(
 				'login' => true,
@@ -286,14 +286,14 @@ 
 	 *
 	 */
 	public function checkSession() {
-		if ( !$this->auth->session ) {
+		if (!$this->auth->session) {
 			return false;
 		}
 
 		$response = $this->_get('dashboard');
-		if ( $response->code == 200 ) {
-			$regex = '#<a href="' . preg_quote($this->base, '#') . 'driver/([\w\d]+)/edit">Settings</a>#';
-			if ( preg_match($regex, $response->body, $match) ) {
+		if ($response->code == 200) {
+			$regex = '#<a href="'.preg_quote($this->base, '#').'driver/([\w\d]+)/edit">Settings</a>#';
+			if (preg_match($regex, $response->body, $match)) {
 				$this->username = $match[1];
 
 				// Since we're downloading /dashboard anyway, let's extract our vehicles from it
@@ -310,7 +310,7 @@ 
 	 *
 	 */
 	public function ensureSession() {
-		if ( !$this->checkSession() ) {
+		if (!$this->checkSession()) {
 			return $this->logIn();
 		}
 
@@ -320,9 +320,9 @@ 
 	/**
 	 *
 	 */
-	protected function extractFormToken( $html ) {
-		if ( preg_match('#<input.+?name="_token".+?>#i', $html, $match) ) {
-			if ( preg_match('#value="([^"]+)"#', $match[0], $match) ) {
+	protected function extractFormToken($html) {
+		if (preg_match('#<input.+?name="_token".+?>#i', $html, $match)) {
+			if (preg_match('#value="([^"]+)"#', $match[0], $match)) {
 				return $match[1];
 			}
 		}
@@ -333,37 +333,37 @@ 
 	/**
 	 * HTTP GET
 	 */
-	public function _get( $uri, $options = array() ) {
+	public function _get($uri, $options = array()) {
 		return $this->_http($uri, $options + array('method' => 'GET'));
 	}
 
 	/**
 	 * HTTP POST
 	 */
-	public function _post( $uri, $options = array() ) {
+	public function _post($uri, $options = array()) {
 		return $this->_http($uri, $options + array('method' => 'POST'));
 	}
 
 	/**
 	 * HTTP URL
 	 */
-	public function _url( $uri, $options = array() ) {
+	public function _url($uri, $options = array()) {
 		$base = !empty($options['login']) ? $this->loginBase : $this->base;
-		$url = strpos($uri, '://') ? $uri : $base . $uri;
+		$url = strpos($uri, '://') ? $uri : $base.$uri;
 		return $url;
 	}
 
 	/**
 	 * HTTP REQUEST
 	 */
-	public function _http( $uri, $options = array() ) {
+	public function _http($uri, $options = array()) {
 		if ($this->auth->session) {
 			$options['cookies'][] = array('fuelly_session', $this->auth->session);
 		}
 
 		$url = $this->_url($uri, $options);
 
-		$log['req'] = $options['method'] . ' ' . $url;
+		$log['req'] = $options['method'].' '.$url;
 		$this->log[] = &$log;
 
 		$_start = microtime(1);
@@ -372,7 +372,7 @@ 
 		$response = $request->request();
 		$_time = microtime(1) - $_start;
 
-		$log['rsp'] = $response->code . ' ' . $response->status;
+		$log['rsp'] = $response->code.' '.$response->status;
 		$log['time'] = $_time;
 
 		return $response;

lib/fuelly/src/WebAuth.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 	/**
 	 * Dependency constructor
 	 */
-	public function __construct( $mail, $pass, $session = '' ) {
+	public function __construct($mail, $pass, $session = '') {
 		$this->mail = $mail;
 		$this->pass = $pass;
 		$this->session = $session;

test.session.php

Spacing +1 added lines, -1 removed lines

@@ -17,4 +17,4 @@
 echo "\n\n";
 
 echo "\n\n";
-echo "To save this session, go to\n\n" . basename(__FILE__) . '?session=' . $client->auth->session;
+echo "To save this session, go to\n\n".basename(__FILE__).'?session='.$client->auth->session;

bootstrap.php

Spacing +2 added lines, -2 removed lines

@@ -1,8 +1,8 @@
 <?php
 
-require __DIR__ . '/env.php';
+require __DIR__.'/env.php';
 
-require __DIR__ . '/vendor/autoload.php';
+require __DIR__.'/vendor/autoload.php';
 
 header('Content-type: text/plain; charset=utf-8');
 

test.fuelup.php

Spacing +3 added lines, -3 removed lines

@@ -5,11 +5,11 @@ 
 $client = getTestClient(FUELLY_TEST_MAIL, FUELLY_TEST_PASS, @$_GET['session']);
 
 $client->ensureSession();
-echo $client->auth->session . "\n\n\n";
+echo $client->auth->session."\n\n\n";
 
 echo "Vehicle:\n";
 $vehicles = $client->vehicles;
-$vehicle = $vehicles[ array_rand($vehicles) ];
+$vehicle = $vehicles[array_rand($vehicles)];
 print_r($vehicle);
 echo "\n\n";
 
@@ -20,7 +20,7 @@ 
 	'amount' => 10,
 	'note' => 'TEST TEST TEST',
 ));
-if ( !empty($response->fuelup_id) ) {
+if (!empty($response->fuelup_id)) {
 	var_dump($response->fuelup_id);
 }
 else {

test.edit.php

Spacing +2 added lines, -2 removed lines

@@ -5,11 +5,11 @@
 $client = getTestClient(FUELLY_TEST_MAIL, FUELLY_TEST_PASS, @$_GET['session']);
 
 $client->ensureSession();
-echo $client->auth->session . "\n\n\n";
+echo $client->auth->session."\n\n\n";
 
 echo "Vehicle:\n";
 $vehicles = $client->vehicles;
-$vehicle = $vehicles[ array_rand($vehicles) ];
+$vehicle = $vehicles[array_rand($vehicles)];
 print_r($vehicle);
 echo "\n\n";
 

test.fuelups.php

Spacing +2 added lines, -2 removed lines

@@ -5,11 +5,11 @@
 $client = getTestClient(FUELLY_TEST_MAIL, FUELLY_TEST_PASS, @$_GET['session']);
 
 $client->ensureSession();
-echo $client->auth->session . "\n\n\n";
+echo $client->auth->session."\n\n\n";
 
 echo "Vehicle:\n";
 $vehicles = $client->vehicles;
-$vehicle = $vehicles[ array_rand($vehicles) ];
+$vehicle = $vehicles[array_rand($vehicles)];
 print_r($vehicle);
 echo "\n\n";
 

test.vehicles.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 $client = getTestClient(FUELLY_TEST_MAIL, FUELLY_TEST_PASS, @$_GET['session']);
 
 $client->ensureSession();
-echo $client->auth->session . "\n\n\n";
+echo $client->auth->session."\n\n\n";
 
 echo "Vehicles:\n";
 $vehicles = $client->vehicles;

lib/fuelly/src/FuelUp.php

Spacing +5 added lines, -5 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	 *
 	 */
-	public static function createFromTrend( Vehicle $vehicle, array $fuelup, InputConversion $input = null ) {
+	public static function createFromTrend(Vehicle $vehicle, array $fuelup, InputConversion $input = null) {
 		// Trend is always in real numbers, and only its natives are reliable so use those
 		$input or $input = $client->createTrendInputConversion();
 
@@ -29,7 +29,7 @@ 
 	/**
 	 *
 	 */
-	public static function createFromDetail( Vehicle $vehicle, array $fuelup, InputConversion $input = null ) {
+	public static function createFromDetail(Vehicle $vehicle, array $fuelup, InputConversion $input = null) {
 		// @todo Parse date correctly
 		$date = DateTime::createFromFormat('d-m-y', $fuelup['fuelup_date']);
 		return new static($vehicle, $date, $fuelup['miles_last_fuelup'], $fuelup['amount']);
@@ -38,7 +38,7 @@ 
 	/**
 	 *
 	 */
-	protected function __construct( Vehicle $vehicle, DateTime $date, $raw_distance, $raw_amount, InputConversion $input = null ) {
+	protected function __construct(Vehicle $vehicle, DateTime $date, $raw_distance, $raw_amount, InputConversion $input = null) {
 		$this->vehicle = $vehicle;
 
 		$input or $input = $vehicle->client->input;
@@ -59,7 +59,7 @@ 
 	/**
 	 *
 	 */
-	public static function createMileage( Length $distance, Volume $amount ) {
+	public static function createMileage(Length $distance, Volume $amount) {
 		// Since we don't know the original mileage from here, we'll construct a known unit from known values
 		return new Mileage($distance->to('km') / $amount->to('l'), 'kmpl');
 	}
@@ -67,7 +67,7 @@ 
 	/**
 	 *
 	 */
-	public static function dateCmp( FuelUp $a, FuelUp $b ) {
+	public static function dateCmp(FuelUp $a, FuelUp $b) {
 		return $b->date->getTimestamp() - $a->date->getTimestamp();
 	}