rudiedirkx / behat-variables

src/BehatVariablesContext.php

<?php

namespace rdx\behatvars;

use Behat\Behat\Context\Context;
use Behat\Behat\Context\SnippetAcceptingContext;
use Behat\Behat\Hook\Scope\AfterFeatureScope;
use Behat\Behat\Hook\Scope\AfterStepScope;
use Behat\Behat\Tester\Result\ExecutedStepResult;
use rdx\behatvars\BehatVariablesArgumentTransformer;
use rdx\behatvars\BehatVariablesDatabase;

class BehatVariablesContext implements Context, SnippetAcceptingContext {

	protected $lastResult = [];



	/**
	 * @AfterStep
	 */
	public function afterStep(AfterStepScope $scope) {
		$this->lastResult = [];

		$result = $scope->getTestResult();
		if ($result instanceof ExecutedStepResult) {
			$result = $result->getCallResult()->getReturn();
			if ($result !== null) {
				$this->lastResult = is_array($result) && isset($result[0]) ? array_values($result) : [$result];
			}
		}
	}

	/**
	 * @AfterFeature
	 */
	static public function afterFeature(AfterFeatureScope $scope) {

The parameter $scope is not used and could be removed.

As per PSR2, the static declaration should come after the visibility declaration.

		BehatVariablesDatabase::clear();

The method clear() does not exist on rdx\behatvars\BehatVariablesDatabase. Did you maybe mean _clear()?

	}



	/**
	 * @When /^(?:I|we) save (?:it|that|those|them) into "([^"]+)"$/
	 */
	public function saveItInto($slot) {
		if (!$this->lastResult) {

The expression $this->lastResult of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			throw new \Exception("Can't store empty return value. Have a step method return a value.");
		}

		$slots = explode(',', $slot);
		if (count($slots) != count($this->lastResult)) {
			$slots = count($slots);
			$results = count($this->lastResult);
			throw new \Exception("Number of slots ($slots) does not match number of last results ($results).");
		}

		$valids = array_filter($slots, [BehatVariablesArgumentTransformer::class, 'validSlotName']);
		if ($valids !== $slots) {
			throw new \Exception("Invalid slot name(s) in '$slot'. Beware the white space!");
		}

		foreach ($slots as $index => $slot) {
			if ($slot) {
				$value = $this->lastResult[$index];
				BehatVariablesDatabase::set($slot, $value);
			}
		}

		$this->lastResult = [];
	}

}