rdx\behatvars\BehatVariablesContext

Complexity

Total Complexity

18

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	afterStep()	0	14	6
A	afterFeature()	0	3	1
A	storageSet()	0	8	2
A	storageGet()	0	7	2
A	storageClear()	0	3	1
B	saveItInto()	0	24	5

<?php

namespace rdx\behatvars;

use Behat\Behat\Context\Context;
use Behat\Behat\Context\SnippetAcceptingContext;
use Behat\Behat\Hook\Scope\AfterFeatureScope;
use Behat\Behat\Hook\Scope\AfterStepScope;
use rdx\behatvars\BehatVariablesArgumentTransformer;

class BehatVariablesContext implements Context, SnippetAcceptingContext {

	protected $lastResult = [];

	static protected $storage = array();

	/**
	 * Initializes context.
	 */
	public function __construct() {

	}



	/**
	 * @AfterStep
	 */
	public function afterStep(AfterStepScope $scope) {
		$this->lastResult = [];

		$result = $scope->getTestResult();
		if (is_callable(array($result, 'getCallResult'))) {
			$result = $result->getCallResult();
			if (is_callable(array($result, 'getReturn'))) {
				$result = $result->getReturn();
				if ($result !== null) {
					$this->lastResult = is_array($result) && isset($result[0]) ? array_values($result) : [$result];
				}
			}
		}
	}

	/**
	 * @AfterFeature
	 */
	static public function afterFeature(AfterFeatureScope $scope) {

The parameter $scope is not used and could be removed.

As per PSR2, the static declaration should come after the visibility declaration.

		self::storageClear();
	}



	/**
	 * @When /^(?:I|we) save (?:it|that|those|them) into "([\w,]+)"$/
	 */
	public function saveItInto($slot) {
		if (!$this->lastResult) {

The expression $this->lastResult of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			throw new \Exception("Can't store empty return value. Have a step method return a value.");
		}

		$slots = explode(',', $slot);
		if (count($slots) != count($this->lastResult)) {
			$slots = count($slots);
			$results = count($this->lastResult);
			throw new \Exception("Number of slots ($slots) does not match number of last results ($results).");
		}

		$valids = array_filter($slots, [BehatVariablesArgumentTransformer::class, 'validSlotName']);
		if ($valids !== $slots) {
			throw new \Exception("Invalid slot name(s) in '$slot'");
		}

		foreach ($slots as $index => $slot) {
			$value = $this->lastResult[$index];
			$this->storageSet($slot, $value);
		}

		$this->lastResult = [];
	}



	/**
	 *
	 */
	protected function storageSet($name, $value) {
		if (!is_scalar($value)) {
			$type = gettype($value);
			throw new \Exception("Storing value must be scalar, but it's a '$type'.");
		}

		self::$storage[$name] = $value;
	}

	/**
	 *
	 */
	public function storageGet($name) {
		if (!isset(self::$storage[$name])) {
			throw new \Exception("Value for '$name' does not exist.");
		}

		return self::$storage[$name];
	}

	/**
	 *
	 */
	static protected function storageClear() {

As per PSR2, the static declaration should come after the visibility declaration.

		self::$storage = array();
	}

}