Teebot\Entity\Command

Complexity

Total Complexity

12

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	4
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	16	3
A	getName()	0	4	1
A	getArgs()	0	4	1
B	getCommandDataFromText()	0	21	7

<?php

namespace Teebot\Entity;

use Teebot\Command\Executor;

class Command extends AbstractEntity
{
    const ENTITY_TYPE             = 'Command';

    const PREFIX          = '/';

    const ARGS_SEPARATOR  = ' ';

    const PARTS_DELIMITER = '_';

    const PATTERN_COMMAND_ON_FIRST = '/^\/[a-zA-Z_]+.*$/';

    const PATTERN_COMMAND_ON_ANY = '/\/[a-zA-Z_]+.*$/';

    const PATTERN_COMMAND_DATA = '/.*\/(?P<name>\w+)\b(?P<args>.*)$/';

    protected $text;

    protected $name;

    protected $args;

    public function __construct(array $data)
    {
        if (isset($data['text'])) {
            $args    = null;

$args is not used, you could remove the assignment.

            $command = $this->getCommandDataFromText($data['text']);

            if ($command) {
                $data = [
                    'name' => $command['name'],
                    'args' => $command['args']
                ];
            }
        }

        parent::__construct($data);
    }

    /**
     * @return mixed
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return mixed
     */
    public function getArgs()
    {
        return $this->args;
    }

    protected function getCommandDataFromText($text)
    {
        $commandOnFirst = Executor::getInstance()->getConfig()->getCommandOnFirst();
        $command        = null;

        if (!is_string($text) ||
            !strlen($text) ||
            ($commandOnFirst === true && $text[0] != self::PREFIX) ||
            strpos($text, self::PREFIX) === false
        ) {
            return $command;
        }

        preg_match(self::PATTERN_COMMAND_DATA, $text, $matches);

        if ($matches) {

The expression $matches of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $matches = array_map('trim', $matches);
        }

        return $matches;
    }
}