File::download() - Code Metrics - Inspection of "Removed unused USE statement" - rudestan/Teebot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64a210...2d6991 )

by Stan

created 2016-04-05 08:01 UTC

File::download() B

↳ Parent: File

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	1

Metric	Value
c	3
b	2
f	1
dl	0
loc	22
rs	8.6737
cc	5
eloc	12
nc	5
nop	1

<?php

namespace Teebot\Entity;

use Teebot\Command\Executor;
use Teebot\Exception\Critical;
use Teebot\Exception\Output;

class File extends AbstractEntity
{
    const ENTITY_TYPE = 'File';

    protected $file_id;

    protected $file_size;

    protected $file_path;

    /**
     * @return mixed
     */
    public function getFileId()
    {
        return $this->file_id;
    }

    /**
     * @param mixed $file_id
     *
     * @return $this
     */
    public function setFileId($file_id)
    {
        $this->file_id = $file_id;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getFileSize()
    {
        return $this->file_size;
    }

    /**
     * @param mixed $file_size
     *
     * @return $this
     */
    public function setFileSize($file_size)
    {
        $this->file_size = $file_size;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getFilePath()
    {
        return $this->file_path;
    }

    /**
     * @param mixed $file_path
     *
     * @return $this
     */
    public function setFilePath($file_path)
    {
        $this->file_path = $file_path;

        return $this;
    }

    public function getFullPath()
    {
        if (!$this->file_path) {
            return null;
        }

        $basePath = Executor::getInstance()
            ->getConfig()
            ->getFileBasePath();

        if (!$basePath) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return null;
        }

        return $basePath . $this->file_path;
    }

    public function download($storePath)
    {
        if (file_exists($storePath) && !is_writable($storePath)) {
            throw new Critical('File "' . $storePath . '" is already exist!"');
        }

        $filePath = $this->getFullPath();

        if (!$filePath) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            throw new Critical('Unable to get download path to file!');
        }

        try {
            $contents = file_get_contents($filePath);

            file_put_contents($storePath, $contents);
        } catch (\Exception $e) {
            Output::log(new Critical($e->getMessage()));
        }

        return is_readable($storePath);
    }
}

1			<?php
2
3			namespace Teebot\Entity;
4
5			use Teebot\Command\Executor;
6			use Teebot\Exception\Critical;
7			use Teebot\Exception\Output;
8
9			class File extends AbstractEntity
10			{
11			const ENTITY_TYPE = 'File';
12
13			protected $file_id;
14
15			protected $file_size;
16
17			protected $file_path;
18
19			/**
20			* @return mixed
21			*/
22			public function getFileId()
23			{
24			return $this->file_id;
25			}
26
27			/**
28			* @param mixed $file_id
29			*
30			* @return $this
31			*/
32			public function setFileId($file_id)
33			{
34			$this->file_id = $file_id;
35
36			return $this;
37			}
38
39			/**
40			* @return mixed
41			*/
42			public function getFileSize()
43			{
44			return $this->file_size;
45			}
46
47			/**
48			* @param mixed $file_size
49			*
50			* @return $this
51			*/
52			public function setFileSize($file_size)
53			{
54			$this->file_size = $file_size;
55
56			return $this;
57			}
58
59			/**
60			* @return mixed
61			*/
62			public function getFilePath()
63			{
64			return $this->file_path;
65			}
66
67			/**
68			* @param mixed $file_path
69			*
70			* @return $this
71			*/
72			public function setFilePath($file_path)
73			{
74			$this->file_path = $file_path;
75
76			return $this;
77			}
78
79			public function getFullPath()
80			{
81			if (!$this->file_path) {
82			return null;
83			}
84
85			$basePath = Executor::getInstance()
86			->getConfig()
87			->getFileBasePath();
88
89			if (!$basePath) {
			0 ignored issues – show Bug Best Practice introduced 2016-04-05 08:04 UTC by Report Bug Copy Issue Report The expression `$basePath` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
90			return null;
91			}
92
93			return $basePath . $this->file_path;
94			}
95
96			public function download($storePath)
97			{
98			if (file_exists($storePath) && !is_writable($storePath)) {
99			throw new Critical('File "' . $storePath . '" is already exist!"');
100			}
101
102			$filePath = $this->getFullPath();
103
104			if (!$filePath) {
			0 ignored issues – show Bug Best Practice introduced 2016-04-05 08:04 UTC by Report Bug Copy Issue Report The expression `$filePath` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
105			throw new Critical('Unable to get download path to file!');
106			}
107
108			try {
109			$contents = file_get_contents($filePath);
110
111			file_put_contents($storePath, $contents);
112			} catch (\Exception $e) {
113			Output::log(new Critical($e->getMessage()));
114			}
115
116			return is_readable($storePath);
117			}
118			}

rudestan / Teebot

GitHub Access Token became invalid

Push — master ( 64a210...2d6991 )

File::download() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like