Command::__construct() - Code Metrics - Inspection of "Removed unused USE statement" - rudestan/Teebot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64a210...2d6991 )

by Stan

created 2016-04-05 08:01 UTC

Command::__construct() A

↳ Parent: Command

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
rs	9.4285
cc	3
eloc	11
nc	3
nop	1

<?php

namespace Teebot\Entity;

class Command extends AbstractEntity
{
    const ENTITY_TYPE             = 'Command';

    const PREFIX          = '/';

    const ARGS_SEPARATOR  = ' ';

    const PARTS_DELIMITER = '_';

    const PATTERN = '/^\/[a-zA-Z_]+.*$/';

    protected $text;

    protected $name;

    protected $args;

    public function __construct(array $data)
    {
        $command = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $args    = null;

        if (isset($data['text'])) {
            $command = $this->getCommandFromText($data['text']);

            if ($command) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $args = $this->getArgsFromText($command, $data['text']);
            }

            $data = [
                'name' => $command,
                'args' => $args
            ];
        }

        parent::__construct($data);
    }

    /**
     * @return mixed
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return mixed
     */
    public function getArgs()
    {
        return $this->args;
    }

    protected function getCommandFromText($text)
    {
        $command = null;

        if (!is_string($text) || !strlen($text) || $text[0] !== static::PREFIX) {
            return $command;
        }

        if (strpos($text, static::ARGS_SEPARATOR) !== false) {
            $parts = explode(static::ARGS_SEPARATOR, $text);

            $text = trim($parts[0]);
        }

        $command = trim(substr($text, 1, strlen($text) - 1));

        return $command;
    }

    protected function getArgsFromText($command, $text)
    {
        $length = strlen(static::PREFIX . $command);

        $argString = trim(substr($text, $length));

        if (strlen($argString)) {
            return $argString;
        }

        return null;
    }
}


1			<?php
2
3			namespace Teebot\Entity;
4
5			class Command extends AbstractEntity
6			{
7			const ENTITY_TYPE = 'Command';
8
9			const PREFIX = '/';
10
11			const ARGS_SEPARATOR = ' ';
12
13			const PARTS_DELIMITER = '_';
14
15			const PATTERN = '/^\/[a-zA-Z_]+.*$/';
16
17			protected $text;
18
19			protected $name;
20
21			protected $args;
22
23			public function __construct(array $data)
24			{
25			$command = null;
			0 ignored issues – show Unused Code introduced 2016-04-05 08:04 UTC by Report Bug Copy Issue Report `$command` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
26			$args = null;
27
28			if (isset($data['text'])) {
29			$command = $this->getCommandFromText($data['text']);
30
31			if ($command) {
			0 ignored issues – show Bug Best Practice introduced 2016-04-05 08:04 UTC by Report Bug Copy Issue Report The expression `$command` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
32			$args = $this->getArgsFromText($command, $data['text']);
33			}
34
35			$data = [
36			'name' => $command,
37			'args' => $args
38			];
39			}
40
41			parent::__construct($data);
42			}
43
44			/**
45			* @return mixed
46			*/
47			public function getName()
48			{
49			return $this->name;
50			}
51
52			/**
53			* @return mixed
54			*/
55			public function getArgs()
56			{
57			return $this->args;
58			}
59
60			protected function getCommandFromText($text)
61			{
62			$command = null;
63
64			if (!is_string($text) \|\| !strlen($text) \|\| $text[0] !== static::PREFIX) {
65			return $command;
66			}
67
68			if (strpos($text, static::ARGS_SEPARATOR) !== false) {
69			$parts = explode(static::ARGS_SEPARATOR, $text);
70
71			$text = trim($parts[0]);
72			}
73
74			$command = trim(substr($text, 1, strlen($text) - 1));
75
76			return $command;
77			}
78
79			protected function getArgsFromText($command, $text)
80			{
81			$length = strlen(static::PREFIX . $command);
82
83			$argString = trim(substr($text, $length));
84
85			if (strlen($argString)) {
86			return $argString;
87			}
88
89			return null;
90			}
91			}
92

rudestan / Teebot

GitHub Access Token became invalid

Push — master ( 64a210...2d6991 )

Command::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like