Issues in Server.php (master) - Issues in master - rtfmcorp/asylamba-game - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3128)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

system/Classes/Daemon/Server.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Asylamba\Classes\Daemon;

use Asylamba\Classes\Router\Router;
use Asylamba\Classes\Library\Http\RequestFactory;
use Asylamba\Classes\Library\Http\ResponseFactory;
use Asylamba\Classes\Daemon\ClientManager;

use Asylamba\Classes\Scheduler\RealTimeActionScheduler;
use Asylamba\Classes\Scheduler\CyclicActionScheduler;

use Asylamba\Classes\Event\ExceptionEvent;
use Asylamba\Classes\Event\ErrorEvent;

use Asylamba\Classes\DependencyInjection\Container;

use Asylamba\Classes\Exception\ErrorException;

use Asylamba\Classes\Process\ProcessManager;
use Asylamba\Classes\Task\TaskManager;

class Server
{
	/** @var Container **/
	protected $container;
    /** @var Router **/
    protected $router;
    /** @var RequestFactory **/
    protected $requestFactory;
    /** @var ResponseFactory **/
    protected $responseFactory;
    /** @var ClientManager **/
    protected $clientManager;
	/** @var RealTimeActionScheduler **/
	protected $realTimeActionScheduler;
	/** @var CyclicActionScheduler **/
	protected $cyclicActionScheduler;
	/** @var ProcessManager **/
	protected $processManager;
	/** @var TaskManager **/
	protected $taskManager;
    /** @var int **/
    protected $serverCycleTimeout;
    /** @var int **/
    protected $port;
    /** @var boolean **/
    protected $shutdown = false;
    /** @var array **/
    protected $connections;
    /** @var array **/
    protected $inputs = [];
    /** @var array **/
    protected $outputs = [];
    /** @var int **/
    protected $nbUncollectedCycles = 0;
    /** @var int **/
    protected $collectionCyclesNumber;

    /**
     * @param Container $container
     * @param int $serverCycleTimeout
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param int $port
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(Container $container)
    {
        $this->container = $container;
        $this->router = $container->get('router');
        $this->requestFactory = $container->get('request_factory');
        $this->responseFactory = $container->get('response_factory');
        $this->clientManager = $container->get('client_manager');
		$this->realTimeActionScheduler = $container->get('realtime_action_scheduler');
		$this->cyclicActionScheduler = $container->get('cyclic_action_scheduler');
        $this->serverCycleTimeout = $container->getParameter('server_cycle_timeout');
        $this->port = $container->getParameter('server_port');
        $this->collectionCyclesNumber = $container->getParameter('server_collection_cycles_number');
    }
	
    public function shutdown()
    {
        $this->shutdown = true;
        foreach($this->inputs as $input) {

            fclose($input);
        }
        foreach($this->outputs as $output) {

            fclose($output);
        }
    }

    public function createHttpServer()
    {
        $stream = stream_socket_server("tcp://0.0.0.0:{$this->port}", $errno, $errstr);
        if (!$stream) {
            throw new ErrorException("$errstr ($errno)");
        }
        $this->inputs['http_server'] = $stream;
    }

    public function listen()
    {
		$this->processManager = $this->container->get('process_manager');
		$this->taskManager = $this->container->get('task_manager');
        $inputs = $this->inputs;
        $outputs = $this->outputs;
        $errors = null;
        gc_disable();
        while ($this->shutdown === false && ($nbUpgradedStreams = stream_select($inputs, $outputs, $errors, $this->serverCycleTimeout)) !== false) {
            if ($nbUpgradedStreams === 0) {
                $this->prepareStreamsState($inputs, $outputs, $errors);
                continue;
            }
            foreach ($inputs as $stream) {
				$name = array_search($stream, $this->inputs);
				if ($name === 'http_server') {
					$this->treatHttpInput(stream_socket_accept($stream));
				} else {
					$this->treatProcessInput($name);
				}
            }
            $this->prepareStreamsState($inputs, $outputs, $errors);
        }
    }
	
	protected function treatHttpInput($input)
	{
		$client = $request = $response = null;
		try {
			$data = fread($input, 8192);
			if (empty($data)) {
				fclose($input);
				return;
			}
			$request = $this->requestFactory->createRequestFromInput($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$this->container->set('app.request', $request);
			if (($client = $this->clientManager->getClient($request)) === null) {
				$client = $this->clientManager->createClient($request);
			}
			$response = $this->router->processRequest($request);
			$this->container->set('app.response', $response);
			$this->responseFactory->processResponse($request, $response, $client);
		} catch (\Exception $ex) {
			$this->container->get('event_dispatcher')->dispatch($event = new ExceptionEvent($request, $ex));
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			$response = $event->getResponse();
			$this->responseFactory->processResponse($request, $response, $client);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		} catch (\Error $err) {
			$this->container->get('event_dispatcher')->dispatch($event = new ErrorEvent($request, $err));
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			$response = $event->getResponse();
			$this->responseFactory->processResponse($request, $response, $client);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		} finally {
			// @TODO Needs further investigation
			if ($response !== null) {
				fputs ($input, $response->send());

				fclose($input);
			}
			$this->nbUncollectedCycles++;
			$this->container->get('session_wrapper')->clearWrapper();
		}
	}
	
	protected function treatProcessInput($name)
	{
		$process = $this->processManager->getByName($name);
		$content = fgets($process->getInput(), 1024);
		if ($content === false) {
			$this->processManager->removeProcess($name, 'The process failed');
			return;
		}
		if (empty($content)) {
			return;
		}
		$data = json_decode($content, true);
		if (isset($data['technical'])) {
			$this->processManager->updateTechnicalData($process, $data['technical']);
		}
		if (isset($data['command'])) {
			return $this->treatCommand($data);
		}
		if (isset($data['task'])) {
			return $this->taskManager->validateTask($process, $data);
		}
	}
	
	/**
	 * @param array $data
	 */
	public function treatCommand($data)
	{
		switch ($data['command']) {
			case 'schedule':
				$this->realTimeActionScheduler->scheduleFromProcess(
					$data['data']['manager'],
					$data['data']['method'],
					$data['data']['object_class'],
					$data['data']['object_id'],
					$data['data']['date']
				);
				break;
			case 'cancel':
				$this->realTimeActionScheduler->cancelFromProcess(
					$data['data']['object_class'],
					$data['data']['object_id'],
					$data['data']['date']
				);
				break;
		}
	}
    
	/**
	 * @param array $inputs
	 * @param array $outputs
	 * @param array $errors
	 */
    protected function prepareStreamsState(&$inputs, &$outputs, &$errors)
    {
		$this->container->cleanApplication();
		
        $inputs = $this->inputs;
        $outputs = $this->outputs;
        $errors = null;
		
		$this->realTimeActionScheduler->execute();
		$this->cyclicActionScheduler->execute();
		
        if ($this->nbUncollectedCycles > $this->collectionCyclesNumber) {
			$this->container->get('database')->refresh();
			$this->clientManager->clear();
            gc_collect_cycles();
            $this->nbUncollectedCycles = 0;
        }
    }
    
	/**
	 * @param string $name
	 * @param resource $input
	 */
    public function addInput($name, $input)
    {
        $this->inputs[$name] = $input;
    }
    
	/**
	 * @param string $name
	 * @param resource $output
	 */
    public function addOutput($name, $output)
    {
        $this->outputs[$name] = $output;
    }
    
	/**
	 * @param string $name
	 */
    public function removeInput($name)
    {
		unset($this->inputs[$name]);
    }
    
	/**
	 * @param string $name
	 */
    public function removeOutput($name)
    {
		unset($this->outputs[$name]);
    }
    
    public static function debug($debug)
    {
        ob_start();
        var_dump($debug);

        file_put_contents('/srv/logs/php/test.log', PROCESS_NAME . ': ' . ob_get_clean() . "\n\n", FILE_APPEND);
    }
}

GitHub Access Token became invalid

Issues (3128)

Security Analysis no request data

system/Classes/Daemon/Server.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace Asylamba\Classes\Daemon;
4
5			use Asylamba\Classes\Router\Router;
6			use Asylamba\Classes\Library\Http\RequestFactory;
7			use Asylamba\Classes\Library\Http\ResponseFactory;
8			use Asylamba\Classes\Daemon\ClientManager;
9
10			use Asylamba\Classes\Scheduler\RealTimeActionScheduler;
11			use Asylamba\Classes\Scheduler\CyclicActionScheduler;
12
13			use Asylamba\Classes\Event\ExceptionEvent;
14			use Asylamba\Classes\Event\ErrorEvent;
15
16			use Asylamba\Classes\DependencyInjection\Container;
17
18			use Asylamba\Classes\Exception\ErrorException;
19
20			use Asylamba\Classes\Process\ProcessManager;
21			use Asylamba\Classes\Task\TaskManager;
22
23			class Server
24			{
25			/ @var Container /
26			protected $container;
27			/ @var Router /
28			protected $router;
29			/ @var RequestFactory /
30			protected $requestFactory;
31			/ @var ResponseFactory /
32			protected $responseFactory;
33			/ @var ClientManager /
34			protected $clientManager;
35			/ @var RealTimeActionScheduler /
36			protected $realTimeActionScheduler;
37			/ @var CyclicActionScheduler /
38			protected $cyclicActionScheduler;
39			/ @var ProcessManager /
40			protected $processManager;
41			/ @var TaskManager /
42			protected $taskManager;
43			/ @var int /
44			protected $serverCycleTimeout;
45			/ @var int /
46			protected $port;
47			/ @var boolean /
48			protected $shutdown = false;
49			/ @var array /
50			protected $connections;
51			/ @var array /
52			protected $inputs = [];
53			/ @var array /
54			protected $outputs = [];
55			/ @var int /
56			protected $nbUncollectedCycles = 0;
57			/ @var int /
58			protected $collectionCyclesNumber;
59
60			/**
61			* @param Container $container
62			* @param int $serverCycleTimeout
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$serverCycleTimeout`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
63			* @param int $port
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$port`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
64			*/
65			public function __construct(Container $container)
66			{
67			$this->container = $container;
68			$this->router = $container->get('router');
69			$this->requestFactory = $container->get('request_factory');
70			$this->responseFactory = $container->get('response_factory');
71			$this->clientManager = $container->get('client_manager');
72			$this->realTimeActionScheduler = $container->get('realtime_action_scheduler');
73			$this->cyclicActionScheduler = $container->get('cyclic_action_scheduler');
74			$this->serverCycleTimeout = $container->getParameter('server_cycle_timeout');
75			$this->port = $container->getParameter('server_port');
76			$this->collectionCyclesNumber = $container->getParameter('server_collection_cycles_number');
77			}
78
79			public function shutdown()
80			{
81			$this->shutdown = true;
82			foreach($this->inputs as $input) {
			0 ignored issues – show Coding Style introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 space after FOREACH keyword; 0 found Loading history...
83			fclose($input);
84			}
85			foreach($this->outputs as $output) {
			0 ignored issues – show Coding Style introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 space after FOREACH keyword; 0 found Loading history...
86			fclose($output);
87			}
88			}
89
90			public function createHttpServer()
91			{
92			$stream = stream_socket_server("tcp://0.0.0.0:{$this->port}", $errno, $errstr);
93			if (!$stream) {
94			throw new ErrorException("$errstr ($errno)");
95			}
96			$this->inputs['http_server'] = $stream;
97			}
98
99			public function listen()
100			{
101			$this->processManager = $this->container->get('process_manager');
102			$this->taskManager = $this->container->get('task_manager');
103			$inputs = $this->inputs;
104			$outputs = $this->outputs;
105			$errors = null;
106			gc_disable();
107			while ($this->shutdown === false && ($nbUpgradedStreams = stream_select($inputs, $outputs, $errors, $this->serverCycleTimeout)) !== false) {
108			if ($nbUpgradedStreams === 0) {
109			$this->prepareStreamsState($inputs, $outputs, $errors);
110			continue;
111			}
112			foreach ($inputs as $stream) {
113			$name = array_search($stream, $this->inputs);
114			if ($name === 'http_server') {
115			$this->treatHttpInput(stream_socket_accept($stream));
116			} else {
117			$this->treatProcessInput($name);
118			}
119			}
120			$this->prepareStreamsState($inputs, $outputs, $errors);
121			}
122			}
123
124			protected function treatHttpInput($input)
125			{
126			$client = $request = $response = null;
127			try {
128			$data = fread($input, 8192);
129			if (empty($data)) {
130			fclose($input);
131			return;
132			}
133			$request = $this->requestFactory->createRequestFromInput($data);
			0 ignored issues – show Documentation introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` is of type `string`, but the function expects a `resource`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
134			$this->container->set('app.request', $request);
135			if (($client = $this->clientManager->getClient($request)) === null) {
136			$client = $this->clientManager->createClient($request);
137			}
138			$response = $this->router->processRequest($request);
139			$this->container->set('app.response', $response);
140			$this->responseFactory->processResponse($request, $response, $client);
141			} catch (\Exception $ex) {
142			$this->container->get('event_dispatcher')->dispatch($event = new ExceptionEvent($request, $ex));
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request` defined by `$response = null` on line `126` can be `null`; however, `Asylamba\Classes\Event\E...ionEvent::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
143			$response = $event->getResponse();
144			$this->responseFactory->processResponse($request, $response, $client);
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request` defined by `$response = null` on line `126` can be `null`; however, `Asylamba\Classes\Library...tory::processResponse()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null / function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history... Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$client` defined by `$request = $response = null` on line `126` can be `null`; however, `Asylamba\Classes\Library...tory::processResponse()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /* @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
145			} catch (\Error $err) {
146			$this->container->get('event_dispatcher')->dispatch($event = new ErrorEvent($request, $err));
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request` defined by `$response = null` on line `126` can be `null`; however, `Asylamba\Classes\Event\ErrorEvent::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
147			$response = $event->getResponse();
148			$this->responseFactory->processResponse($request, $response, $client);
			0 ignored issues – show Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request` defined by `$response = null` on line `126` can be `null`; however, `Asylamba\Classes\Library...tory::processResponse()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null / function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history... Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$client` defined by `$request = $response = null` on line `126` can be `null`; however, `Asylamba\Classes\Library...tory::processResponse()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /* @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
149			} finally {
150			// @TODO Needs further investigation
151			if ($response !== null) {
152			fputs ($input, $response->send());
			0 ignored issues – show Coding Style introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Space before opening parenthesis of function call prohibited Loading history...
153			fclose($input);
154			}
155			$this->nbUncollectedCycles++;
156			$this->container->get('session_wrapper')->clearWrapper();
157			}
158			}
159
160			protected function treatProcessInput($name)
161			{
162			$process = $this->processManager->getByName($name);
163			$content = fgets($process->getInput(), 1024);
164			if ($content === false) {
165			$this->processManager->removeProcess($name, 'The process failed');
166			return;
167			}
168			if (empty($content)) {
169			return;
170			}
171			$data = json_decode($content, true);
172			if (isset($data['technical'])) {
173			$this->processManager->updateTechnicalData($process, $data['technical']);
174			}
175			if (isset($data['command'])) {
176			return $this->treatCommand($data);
177			}
178			if (isset($data['task'])) {
179			return $this->taskManager->validateTask($process, $data);
180			}
181			}
182
183			/**
184			* @param array $data
185			*/
186			public function treatCommand($data)
187			{
188			switch ($data['command']) {
189			case 'schedule':
190			$this->realTimeActionScheduler->scheduleFromProcess(
191			$data['data']['manager'],
192			$data['data']['method'],
193			$data['data']['object_class'],
194			$data['data']['object_id'],
195			$data['data']['date']
196			);
197			break;
198			case 'cancel':
199			$this->realTimeActionScheduler->cancelFromProcess(
200			$data['data']['object_class'],
201			$data['data']['object_id'],
202			$data['data']['date']
203			);
204			break;
205			}
206			}
207
208			/**
209			* @param array $inputs
210			* @param array $outputs
211			* @param array $errors
212			*/
213			protected function prepareStreamsState(&$inputs, &$outputs, &$errors)
214			{
215			$this->container->cleanApplication();
216
217			$inputs = $this->inputs;
218			$outputs = $this->outputs;
219			$errors = null;
220
221			$this->realTimeActionScheduler->execute();
222			$this->cyclicActionScheduler->execute();
223
224			if ($this->nbUncollectedCycles > $this->collectionCyclesNumber) {
225			$this->container->get('database')->refresh();
226			$this->clientManager->clear();
227			gc_collect_cycles();
228			$this->nbUncollectedCycles = 0;
229			}
230			}
231
232			/**
233			* @param string $name
234			* @param resource $input
235			*/
236			public function addInput($name, $input)
237			{
238			$this->inputs[$name] = $input;
239			}
240
241			/**
242			* @param string $name
243			* @param resource $output
244			*/
245			public function addOutput($name, $output)
246			{
247			$this->outputs[$name] = $output;
248			}
249
250			/**
251			* @param string $name
252			*/
253			public function removeInput($name)
254			{
255			unset($this->inputs[$name]);
256			}
257
258			/**
259			* @param string $name
260			*/
261			public function removeOutput($name)
262			{
263			unset($this->outputs[$name]);
264			}
265
266			public static function debug($debug)
267			{
268			ob_start();
269			var_dump($debug);
			0 ignored issues – show Security Debugging Code introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `var_dump($debug);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
270			file_put_contents('/srv/logs/php/test.log', PROCESS_NAME . ': ' . ob_get_clean() . "\n\n", FILE_APPEND);
271			}
272			}

rtfmcorp / asylamba-game

GitHub Access Token became invalid

Issues (3128)

Security Analysis no request data

system/Classes/Daemon/Server.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like