Asylamba\Modules\Hephaistos\Routine\DailyRoutine

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	execute()	0	32	6

<?php

namespace Asylamba\Modules\Hephaistos\Routine;

use Asylamba\Classes\Entity\EntityManager;

use Asylamba\Modules\Zeus\Manager\PlayerManager;

use Asylamba\Classes\Worker\API;

use Asylamba\Modules\Hermes\Model\Notification;
use Asylamba\Modules\Zeus\Model\Player;

use Asylamba\Classes\Library\Utils;

class DailyRoutine
{
	/**
	 * @param EntityManager $entityManager
	 * @param API $api
	 * @param string $apimode
	 * @param PlayerManager $playerManager
	 * @param int $playerInactiveTimeLimit
	 * @param int $playerGlobalInactiveTime
	 * @param int $readTimeout
	 * @param int $unreadTimeout
	 */
	public function execute(
		EntityManager $entityManager,
		API $api,
		$apimode,
		PlayerManager $playerManager,
		$playerInactiveTimeLimit,
		$playerGlobalInactiveTime,
		$readTimeout,
		$unreadTimeout
	)
	{

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line

		$entityManager->getRepository(Notification::class)->cleanNotifications($readTimeout, $unreadTimeout);

It seems like you code against a specific sub-type and not the parent class Asylamba\Classes\Entity\AbstractRepository as the method cleanNotifications() does only exist in the following sub-classes of Asylamba\Classes\Entity\AbstractRepository: Asylamba\Modules\Hermes\Repository\NotificationRepository. Maybe you want to instanceof check for one of these explicitly?

		
		$players = $playerManager->getByStatements([Player::ACTIVE, Player::INACTIVE]);
		$nbPlayers = count($players);
		// @TODO understand this strange loop condition
		for ($i = $nbPlayers - 1; $i >= 0; $i--) {
			$player = $players[$i];
			if (Utils::interval(Utils::now(), $player->getDLastConnection()) >= $playerInactiveTimeLimit) {

Blank line found at start of control structure

				$playerManager->kill($player->id);
			} elseif (Utils::interval(Utils::now(), $player->getDLastConnection()) >= $playerGlobalInactiveTime AND $player->statement == Player::ACTIVE) {

As per coding-style, PHP keywords should be in lowercase; expected and, but found AND.

				$player->statement = Player::INACTIVE;

				if ($apimode === 'enabled') {
					# sending email API call
					$api->sendMail($player->bind, API::TEMPLATE_INACTIVE_PLAYER);
				}
			}
		}
		$entityManager->flush(Player::class);
	}
}