RankingManager::processFactionsRanking() - Code Metrics - Inspection of "Feature/new tu" - rtfmcorp/asylamba-game - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#123)

unknown

created 2017-06-29 10:56 UTC

RankingManager::processFactionsRanking() B

↳ Parent: RankingManager

Complexity

Conditions	4
Paths	5

Size

Total Lines	33
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	20
nc	5
nop	0
dl	0
loc	33
rs	8.5806
c	1
b	0
f	0

<?php

namespace Asylamba\Modules\Atlas\Manager;

use Asylamba\Classes\Entity\EntityManager;

use Asylamba\Modules\Demeter\Manager\ColorManager;
use Asylamba\Modules\Hermes\Manager\ConversationManager;
use Asylamba\Modules\Hermes\Manager\ConversationMessageManager;

use Asylamba\Modules\Atlas\Routine\DailyRoutine;
use Asylamba\Modules\Atlas\Routine\PlayerRoutine;
use Asylamba\Modules\Atlas\Routine\FactionRoutine;

use Asylamba\Modules\Hermes\Model\ConversationUser;
use Asylamba\Modules\Hermes\Model\ConversationMessage;
use Asylamba\Modules\Demeter\Resource\ColorResource;
use Asylamba\Modules\Athena\Helper\OrbitalBaseHelper;
use Asylamba\Modules\Zeus\Manager\PlayerManager;

use Asylamba\Modules\Zeus\Model\Player;
use Asylamba\Modules\Atlas\Model\PlayerRanking;
use Asylamba\Modules\Atlas\Model\FactionRanking;
use Asylamba\Modules\Atlas\Model\Ranking;
use Asylamba\Modules\Gaia\Model\Sector;

use Asylamba\Classes\Exception\ErrorException;

use Asylamba\Classes\Library\Utils;

class RankingManager
{
	/** @var EntityManager **/
	protected $entityManager;
	/** @var PlayerRankingManager **/
	protected $playerRankingManager;
	/** @var FactionRankingManager **/
	protected $factionRankingManager;
	/** @var ColorManager **/
	protected $colorManager;
	/** @var ConversationManager **/
	protected $conversationManager;
	/** @var ConversationMessageManager **/
	protected $conversationMessageManager;
	/** @var PlayerManager **/
	protected $playerManager;
	/** @var OrbitalBaseHelper **/
	protected $orbitalBaseHelper;
	/** @var FactionRoutine **/
	protected $factionRoutine;
	/** @var PlayerRoutine **/
	protected $playerRoutine;
	/** @var DailyRoutine **/
	protected $dailyRoutine;
	
	/**
	 * @param EntityManager $entityManager
	 * @param PlayerRankingManager $playerRankingManager
	 * @param FactionRankingManager $factionRankingManager
	 * @param ColorManager $colorManager
	 * @param ConversationManager $conversationManager
	 * @param ConversationMessageManager $conversationMessageManager
	 * @param PlayerManager $playerManager
	 * @param OrbitalBaseHelper $orbitalBaseHelper
	 */
	public function __construct(
		EntityManager $entityManager,
		PlayerRankingManager $playerRankingManager,
		FactionRankingManager $factionRankingManager,
		ColorManager $colorManager,
		ConversationManager $conversationManager,
		ConversationMessageManager $conversationMessageManager,
		PlayerManager $playerManager,
		OrbitalBaseHelper $orbitalBaseHelper
	)
	{

		$this->entityManager = $entityManager;
		$this->playerRankingManager = $playerRankingManager;
		$this->factionRankingManager = $factionRankingManager;
		$this->colorManager = $colorManager;
		$this->conversationManager = $conversationManager;
		$this->conversationMessageManager = $conversationMessageManager;
		$this->playerManager = $playerManager;
		$this->orbitalBaseHelper = $orbitalBaseHelper;
		
		$this->dailyRoutine = new DailyRoutine();
		$this->playerRoutine = new PlayerRoutine();
		$this->factionRoutine = new FactionRoutine();
	}
	
	public function processPlayersRanking()
	{
		if ($this->entityManager->getRepository(Ranking::class)->hasBeenAlreadyProcessed(true, false) === true) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			return;
		}
		
		$players = $this->playerManager->getByStatements([Player::ACTIVE, Player::INACTIVE, Player::HOLIDAY]);
		
		$playerRankingRepository = $this->entityManager->getRepository(PlayerRanking::class);
		
		$ranking = $this->createRanking(true, false);
		
		$this->playerRoutine->execute(
			$players,
			$playerRankingRepository->getPlayersResources(),
			$playerRankingRepository->getPlayersResourcesData(),
			$playerRankingRepository->getPlayersGeneralData(),
			$playerRankingRepository->getPlayersArmiesData(),
			$playerRankingRepository->getPlayersPlanetData(),
			$playerRankingRepository->getPlayersTradeRoutes(),
			$playerRankingRepository->getPlayersLinkedTradeRoutes(),
			$playerRankingRepository->getAttackersButcherRanking(),
			$playerRankingRepository->getDefendersButcherRanking(),
			$this->orbitalBaseHelper
		);
		
		$S_PRM1 = $this->playerRankingManager->getCurrentSession();
		$this->playerRankingManager->newSession();
		$this->playerRankingManager->loadLastContext();

		$this->playerRoutine->processResults($ranking, $players, $this->playerRankingManager, $playerRankingRepository);

		
		$this->playerRankingManager->changeSession($S_PRM1);
		
		$this->entityManager->flush();
	}
	
	public function processFactionsRanking()
	{
		if ($this->entityManager->getRepository(Ranking::class)->hasBeenAlreadyProcessed(false, true) === true) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			return;
		}
		
		$factions = $this->colorManager->getInGameFactions();
		$playerRankingRepository = $this->entityManager->getRepository(PlayerRanking::class);
		$factionRankingRepository = $this->entityManager->getRepository(FactionRanking::class);
		$sectors = $this->entityManager->getRepository(Sector::class)->getAll();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		
		$ranking = $this->createRanking(false, true);
		
		foreach ($factions as $faction) {
			$routesIncome = $factionRankingRepository->getRoutesIncome($faction);
			$playerRankings = $playerRankingRepository->getFactionPlayerRankings($faction);
			
			$this->factionRoutine->execute($faction, $playerRankings, $routesIncome, $sectors);
		}
		
		$S_FRM1 = $this->factionRankingManager->getCurrentSession();
		$this->factionRankingManager->newSession();
		$this->factionRankingManager->loadLastContext();
		
		$winningFactionId = $this->factionRoutine->processResults($ranking, $factions, $this->factionRankingManager);

		$this->factionRankingManager->changeSession($S_FRM1);
		
		if ($winningFactionId !== null) {
			$this->processWinningFaction($winningFactionId);
		}
		$this->entityManager->flush();
	}
	
	protected function processWinningFaction($factionId)
	{
		$faction = $this->colorManager->get($factionId);
		$faction->isWinner = Color::WIN;

		# envoyer un message de Jean-Mi
		$winnerName = ColorResource::getInfo($faction->id, 'officialName');
		$content = 'Salut,<br /><br />La victoire vient d\'être remportée par : <br /><strong>' . $winnerName . '</strong><br />';
		$content .= 'Cette faction a atteint les ' . POINTS_TO_WIN . ' points, la partie est donc terminée.<br /><br />Bravo et un grand merci à tous les participants !';

		$S_CVM1 = $this->conversationManager->getCurrentSession();
		$this->conversationManager->newSession();
		$this->conversationManager->load(
			['cu.rPlayer' => ID_JEANMI]
		);

		if ($this->conversationManager->size() == 1) {
			$conv = $this->conversationManager->get();

			$conv->messages++;
			$conv->dLastMessage = Utils::now();

			# désarchiver tous les users
			$users = $conv->players;
			foreach ($users as $user) {
				$user->convStatement = ConversationUser::CS_DISPLAY;
			}

			# création du message
			$message = new ConversationMessage();

			$message->rConversation = $conv->id;
			$message->rPlayer = ID_JEANMI;
			$message->type = ConversationMessage::TY_STD;
			$message->content = $content;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
			$message->dCreation = Utils::now();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
			$message->dLastModification = NULL;

			$this->conversationMessageManager->add($message);
		} else {
			throw new ErrorException('La conversation n\'existe pas ou ne vous appartient pas.');
		}
		$this->conversationManager->changeSession($S_CVM1);
	}
	
	protected function createRanking($isPlayer, $isFaction)
	{
		$ranking =
			(new Ranking())
			->setIsPlayer($isPlayer)
			->setIsFaction($isFaction)
			->setCreatedAt(Utils::now())
		;
		$this->entityManager->persist($ranking);
		$this->entityManager->flush($ranking);
		return $ranking;
	}
}

GitHub Access Token became invalid

Pull Request — master (#123)

RankingManager::processFactionsRanking() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Asylamba\Modules\Atlas\Manager;
4
5			use Asylamba\Classes\Entity\EntityManager;
6
7			use Asylamba\Modules\Demeter\Manager\ColorManager;
8			use Asylamba\Modules\Hermes\Manager\ConversationManager;
9			use Asylamba\Modules\Hermes\Manager\ConversationMessageManager;
10
11			use Asylamba\Modules\Atlas\Routine\DailyRoutine;
12			use Asylamba\Modules\Atlas\Routine\PlayerRoutine;
13			use Asylamba\Modules\Atlas\Routine\FactionRoutine;
14
15			use Asylamba\Modules\Hermes\Model\ConversationUser;
16			use Asylamba\Modules\Hermes\Model\ConversationMessage;
17			use Asylamba\Modules\Demeter\Resource\ColorResource;
18			use Asylamba\Modules\Athena\Helper\OrbitalBaseHelper;
19			use Asylamba\Modules\Zeus\Manager\PlayerManager;
20
21			use Asylamba\Modules\Zeus\Model\Player;
22			use Asylamba\Modules\Atlas\Model\PlayerRanking;
23			use Asylamba\Modules\Atlas\Model\FactionRanking;
24			use Asylamba\Modules\Atlas\Model\Ranking;
25			use Asylamba\Modules\Gaia\Model\Sector;
26
27			use Asylamba\Classes\Exception\ErrorException;
28
29			use Asylamba\Classes\Library\Utils;
30
31			class RankingManager
32			{
33			/ @var EntityManager /
34			protected $entityManager;
35			/ @var PlayerRankingManager /
36			protected $playerRankingManager;
37			/ @var FactionRankingManager /
38			protected $factionRankingManager;
39			/ @var ColorManager /
40			protected $colorManager;
41			/ @var ConversationManager /
42			protected $conversationManager;
43			/ @var ConversationMessageManager /
44			protected $conversationMessageManager;
45			/ @var PlayerManager /
46			protected $playerManager;
47			/ @var OrbitalBaseHelper /
48			protected $orbitalBaseHelper;
49			/ @var FactionRoutine /
50			protected $factionRoutine;
51			/ @var PlayerRoutine /
52			protected $playerRoutine;
53			/ @var DailyRoutine /
54			protected $dailyRoutine;
55
56			/**
57			* @param EntityManager $entityManager
58			* @param PlayerRankingManager $playerRankingManager
59			* @param FactionRankingManager $factionRankingManager
60			* @param ColorManager $colorManager
61			* @param ConversationManager $conversationManager
62			* @param ConversationMessageManager $conversationMessageManager
63			* @param PlayerManager $playerManager
64			* @param OrbitalBaseHelper $orbitalBaseHelper
65			*/
66			public function __construct(
67			EntityManager $entityManager,
68			PlayerRankingManager $playerRankingManager,
69			FactionRankingManager $factionRankingManager,
70			ColorManager $colorManager,
71			ConversationManager $conversationManager,
72			ConversationMessageManager $conversationMessageManager,
73			PlayerManager $playerManager,
74			OrbitalBaseHelper $orbitalBaseHelper
75			)
76			{
			0 ignored issues – show Coding Style introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Loading history...
77			$this->entityManager = $entityManager;
78			$this->playerRankingManager = $playerRankingManager;
79			$this->factionRankingManager = $factionRankingManager;
80			$this->colorManager = $colorManager;
81			$this->conversationManager = $conversationManager;
82			$this->conversationMessageManager = $conversationMessageManager;
83			$this->playerManager = $playerManager;
84			$this->orbitalBaseHelper = $orbitalBaseHelper;
85
86			$this->dailyRoutine = new DailyRoutine();
87			$this->playerRoutine = new PlayerRoutine();
88			$this->factionRoutine = new FactionRoutine();
89			}
90
91			public function processPlayersRanking()
92			{
93			if ($this->entityManager->getRepository(Ranking::class)->hasBeenAlreadyProcessed(true, false) === true) {
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `hasBeenAlreadyProcessed()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Atlas\R...itory\RankingRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
94			return;
95			}
96
97			$players = $this->playerManager->getByStatements([Player::ACTIVE, Player::INACTIVE, Player::HOLIDAY]);
98
99			$playerRankingRepository = $this->entityManager->getRepository(PlayerRanking::class);
100
101			$ranking = $this->createRanking(true, false);
102
103			$this->playerRoutine->execute(
104			$players,
105			$playerRankingRepository->getPlayersResources(),
106			$playerRankingRepository->getPlayersResourcesData(),
107			$playerRankingRepository->getPlayersGeneralData(),
108			$playerRankingRepository->getPlayersArmiesData(),
109			$playerRankingRepository->getPlayersPlanetData(),
110			$playerRankingRepository->getPlayersTradeRoutes(),
111			$playerRankingRepository->getPlayersLinkedTradeRoutes(),
112			$playerRankingRepository->getAttackersButcherRanking(),
113			$playerRankingRepository->getDefendersButcherRanking(),
114			$this->orbitalBaseHelper
115			);
116
117			$S_PRM1 = $this->playerRankingManager->getCurrentSession();
118			$this->playerRankingManager->newSession();
119			$this->playerRankingManager->loadLastContext();
120
121			$this->playerRoutine->processResults($ranking, $players, $this->playerRankingManager, $playerRankingRepository);
			0 ignored issues – show Compatibility introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report `$playerRankingRepository` of type `object<Asylamba\Classes\...ity\AbstractRepository>` is not a sub-type of `object<Asylamba\Modules\...layerRankingRepository>`. It seems like you assume a child class of the class `Asylamba\Classes\Entity\AbstractRepository` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
122
123			$this->playerRankingManager->changeSession($S_PRM1);
124
125			$this->entityManager->flush();
126			}
127
128			public function processFactionsRanking()
129			{
130			if ($this->entityManager->getRepository(Ranking::class)->hasBeenAlreadyProcessed(false, true) === true) {
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `hasBeenAlreadyProcessed()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Atlas\R...itory\RankingRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
131			return;
132			}
133
134			$factions = $this->colorManager->getInGameFactions();
135			$playerRankingRepository = $this->entityManager->getRepository(PlayerRanking::class);
136			$factionRankingRepository = $this->entityManager->getRepository(FactionRanking::class);
137			$sectors = $this->entityManager->getRepository(Sector::class)->getAll();
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getAll()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Athena\...BuildingQueueRepository`, `Asylamba\Modules\Athena\...rcialShippingRepository`, `Asylamba\Modules\Athena\...y\OrbitalBaseRepository`, `Asylamba\Modules\Athena\...ory\ShipQueueRepository`, `Asylamba\Modules\Demeter...ository\ColorRepository`, `Asylamba\Modules\Gaia\Repository\SectorRepository`, `Asylamba\Modules\Gaia\Repository\SystemRepository`, `Asylamba\Modules\Prometh...chnologyQueueRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
138
139			$ranking = $this->createRanking(false, true);
140
141			foreach ($factions as $faction) {
142			$routesIncome = $factionRankingRepository->getRoutesIncome($faction);
143			$playerRankings = $playerRankingRepository->getFactionPlayerRankings($faction);
144
145			$this->factionRoutine->execute($faction, $playerRankings, $routesIncome, $sectors);
146			}
147
148			$S_FRM1 = $this->factionRankingManager->getCurrentSession();
149			$this->factionRankingManager->newSession();
150			$this->factionRankingManager->loadLastContext();
151
152			$winningFactionId = $this->factionRoutine->processResults($ranking, $factions, $this->factionRankingManager);
153
154			$this->factionRankingManager->changeSession($S_FRM1);
155
156			if ($winningFactionId !== null) {
157			$this->processWinningFaction($winningFactionId);
158			}
159			$this->entityManager->flush();
160			}
161
162			protected function processWinningFaction($factionId)
163			{
164			$faction = $this->colorManager->get($factionId);
165			$faction->isWinner = Color::WIN;
166
167			# envoyer un message de Jean-Mi
168			$winnerName = ColorResource::getInfo($faction->id, 'officialName');
169			$content = 'Salut,<br /><br />La victoire vient d\'être remportée par : <br /><strong>' . $winnerName . '</strong><br />';
170			$content .= 'Cette faction a atteint les ' . POINTS_TO_WIN . ' points, la partie est donc terminée.<br /><br />Bravo et un grand merci à tous les participants !';
171
172			$S_CVM1 = $this->conversationManager->getCurrentSession();
173			$this->conversationManager->newSession();
174			$this->conversationManager->load(
175			['cu.rPlayer' => ID_JEANMI]
176			);
177
178			if ($this->conversationManager->size() == 1) {
179			$conv = $this->conversationManager->get();
180
181			$conv->messages++;
182			$conv->dLastMessage = Utils::now();
183
184			# désarchiver tous les users
185			$users = $conv->players;
186			foreach ($users as $user) {
187			$user->convStatement = ConversationUser::CS_DISPLAY;
188			}
189
190			# création du message
191			$message = new ConversationMessage();
192
193			$message->rConversation = $conv->id;
194			$message->rPlayer = ID_JEANMI;
195			$message->type = ConversationMessage::TY_STD;
196			$message->content = $content;
			0 ignored issues – show Documentation Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report The property `$content` was declared of type `integer`, but `$content` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
197			$message->dCreation = Utils::now();
			0 ignored issues – show Documentation Bug introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report The property `$dCreation` was declared of type `integer`, but `\Asylamba\Classes\Library\Utils::now()` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
198			$message->dLastModification = NULL;
199
200			$this->conversationMessageManager->add($message);
201			} else {
202			throw new ErrorException('La conversation n\'existe pas ou ne vous appartient pas.');
203			}
204			$this->conversationManager->changeSession($S_CVM1);
205			}
206
207			protected function createRanking($isPlayer, $isFaction)
208			{
209			$ranking =
210			(new Ranking())
211			->setIsPlayer($isPlayer)
212			->setIsFaction($isFaction)
213			->setCreatedAt(Utils::now())
214			;
215			$this->entityManager->persist($ranking);
216			$this->entityManager->flush($ranking);
217			return $ranking;
218			}
219			}

rtfmcorp / asylamba-game

GitHub Access Token became invalid

Pull Request — master (#123)

RankingManager::processFactionsRanking() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like