RecyclingLogManager - Code Metrics - Inspection of "Fix logs directory for travis" - rtfmcorp/asylamba-game - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 856a6b...b18c19 )

by Jacky

created 2017-07-01 11:57 UTC

RecyclingLogManager A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	29
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	add()	5	1
A	getBaseActiveMissionsLogs()	4	1

<?php

/**
 * RecyclingLogManager
 *
 * @author Jacky Casas
 * @copyright Asylamba
 *
 * @package Zeus
 * @version 09.02.15
 **/
namespace Asylamba\Modules\Athena\Manager;

use Asylamba\Classes\Entity\EntityManager;

use Asylamba\Modules\Athena\Model\RecyclingLog;

class RecyclingLogManager {
	/** @var EntityManager **/
	protected $entityManager;

	/**
	 * @param EntityManager $entityManager
	 */
	public function __construct(EntityManager $entityManager) {
		$this->entityManager = $entityManager;
	}

	/**
	 * @param RecyclingLog $recyclingLog
	 */
	public function add(RecyclingLog $recyclingLog)
	{
		$this->entityManager->persist($recyclingLog);
		$this->entityManager->flush($recyclingLog);
	}
	
	/**
	 * @param int $baseId
	 * @return array
	 */
	public function getBaseActiveMissionsLogs($baseId)
	{
		return $this->entityManager->getRepository(RecyclingLog::class)->getBaseActiveMissionsLogs($baseId);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
}

GitHub Access Token became invalid

Push — master ( 856a6b...b18c19 )

RecyclingLogManager A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

1			<?php
2
3			/**
4			* RecyclingLogManager
5			*
6			* @author Jacky Casas
7			* @copyright Asylamba
8			*
9			* @package Zeus
10			* @version 09.02.15
11			**/
12			namespace Asylamba\Modules\Athena\Manager;
13
14			use Asylamba\Classes\Entity\EntityManager;
15
16			use Asylamba\Modules\Athena\Model\RecyclingLog;
17
18			class RecyclingLogManager {
19			/ @var EntityManager /
20			protected $entityManager;
21
22			/**
23			* @param EntityManager $entityManager
24			*/
25			public function __construct(EntityManager $entityManager) {
26			$this->entityManager = $entityManager;
27			}
28
29			/**
30			* @param RecyclingLog $recyclingLog
31			*/
32			public function add(RecyclingLog $recyclingLog)
33			{
34			$this->entityManager->persist($recyclingLog);
35			$this->entityManager->flush($recyclingLog);
36			}
37
38			/**
39			* @param int $baseId
40			* @return array
41			*/
42			public function getBaseActiveMissionsLogs($baseId)
43			{
44			return $this->entityManager->getRepository(RecyclingLog::class)->getBaseActiveMissionsLogs($baseId);
			0 ignored issues – show Bug introduced 2017-07-01 12:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getBaseActiveMissionsLogs()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Athena\...\RecyclingLogRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
45			}
46			}

rtfmcorp / asylamba-game

GitHub Access Token became invalid

Push — master ( 856a6b...b18c19 )

RecyclingLogManager A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like