TechnologyQueueManager::save() - Code Metrics - Inspection of "Merge pull request #123 from Liador/feature/NewTU" - rtfmcorp/asylamba-game - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11c0a1...856a6b )

by Jacky

created 2017-06-30 10:05 UTC

TechnologyQueueManager::save() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	13
nc	2
nop	0
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0

<?php
/**
 * Technology Queue Manager
 *
 * @author Jacky Casas
 * @copyright Expansion - le jeu
 *
 * @package Prométhée
 * @update 10.02.14
*/
namespace Asylamba\Modules\Promethee\Manager;

use Asylamba\Classes\Entity\EntityManager;
use Asylamba\Modules\Promethee\Model\TechnologyQueue;
use Asylamba\Classes\Scheduler\RealTimeActionScheduler;

class TechnologyQueueManager
{
	/** @var EntityManager **/
	protected $entityManager;
	/** @var RealTimeActionScheduler **/
	protected $realtimeActionScheduler;

	/**
	 * @param EntityManager $entityManager
	 * @param RealTimeActionScheduler $realtimeActionScheduler
	 */
	public function __construct(EntityManager $entityManager, RealTimeActionScheduler $realtimeActionScheduler)
	{
		$this->entityManager = $entityManager;
		$this->realtimeActionScheduler = $realtimeActionScheduler;
	}
	
	public function scheduleQueues()
	{
		$queues = $this->entityManager->getRepository(TechnologyQueue::class)->getAll();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		
		foreach ($queues as $queue) {
			$this->realtimeActionScheduler->schedule('athena.orbital_base_manager', 'uTechnologyQueue', $queue, $queue->getEndedAt());
		}
	}
	
	/**
	 * @param int $id
	 * @return TechnologyQueue
	 */
	public function get($id)
	{
		return $this->entityManager->getRepository(TechnologyQueue::class)->get($id);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
	
	/**
	 * @param int $playerId
	 * @param int $technology
	 * @return TechnologyQueue
	 */
	public function getPlayerTechnologyQueue($playerId, $technology)
	{
		return $this->entityManager->getRepository(TechnologyQueue::class)->getPlayerTechnologyQueue($playerId, $technology);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
	
	/**
	 * @param int $placeId
	 * @return array
	 */
	public function getPlaceQueues($placeId)
	{
		return $this->entityManager->getRepository(TechnologyQueue::class)->getPlaceQueues($placeId);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
	
	/**
	 * @param int $playerId
	 * @return array
	 */
	public function getPlayerQueues($playerId)
	{
		return $this->entityManager->getRepository(TechnologyQueue::class)->getPlayerQueues($playerId);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	/**
	 * @param TechnologyQueue $technologyQueue
	 */
	public function add(TechnologyQueue $technologyQueue) {
		$this->entityManager->persist($technologyQueue);
		$this->entityManager->flush($technologyQueue);
		
		$this->realtimeActionScheduler->schedule('athena.orbital_base_manager', 'uTechnologyQueue', $technologyQueue, $technologyQueue->getEndedAt());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}
}

GitHub Access Token became invalid

Push — master ( 11c0a1...856a6b )

TechnologyQueueManager::save() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Technology Queue Manager
4			*
5			* @author Jacky Casas
6			* @copyright Expansion - le jeu
7			*
8			* @package Prométhée
9			* @update 10.02.14
10			*/
11			namespace Asylamba\Modules\Promethee\Manager;
12
13			use Asylamba\Classes\Entity\EntityManager;
14			use Asylamba\Modules\Promethee\Model\TechnologyQueue;
15			use Asylamba\Classes\Scheduler\RealTimeActionScheduler;
16
17			class TechnologyQueueManager
18			{
19			/ @var EntityManager /
20			protected $entityManager;
21			/ @var RealTimeActionScheduler /
22			protected $realtimeActionScheduler;
23
24			/**
25			* @param EntityManager $entityManager
26			* @param RealTimeActionScheduler $realtimeActionScheduler
27			*/
28			public function __construct(EntityManager $entityManager, RealTimeActionScheduler $realtimeActionScheduler)
29			{
30			$this->entityManager = $entityManager;
31			$this->realtimeActionScheduler = $realtimeActionScheduler;
32			}
33
34			public function scheduleQueues()
35			{
36			$queues = $this->entityManager->getRepository(TechnologyQueue::class)->getAll();
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getAll()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Athena\...BuildingQueueRepository`, `Asylamba\Modules\Athena\...rcialShippingRepository`, `Asylamba\Modules\Athena\...y\OrbitalBaseRepository`, `Asylamba\Modules\Athena\...ory\ShipQueueRepository`, `Asylamba\Modules\Demeter...ository\ColorRepository`, `Asylamba\Modules\Gaia\Repository\SectorRepository`, `Asylamba\Modules\Gaia\Repository\SystemRepository`, `Asylamba\Modules\Prometh...chnologyQueueRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
37
38			foreach ($queues as $queue) {
39			$this->realtimeActionScheduler->schedule('athena.orbital_base_manager', 'uTechnologyQueue', $queue, $queue->getEndedAt());
40			}
41			}
42
43			/**
44			* @param int $id
45			* @return TechnologyQueue
46			*/
47			public function get($id)
48			{
49			return $this->entityManager->getRepository(TechnologyQueue::class)->get($id);
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `get()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Ares\Re...ory\CommanderRepository`, `Asylamba\Modules\Ares\Re...ry\LiveReportRepository`, `Asylamba\Modules\Ares\Repository\ReportRepository`, `Asylamba\Modules\Athena\...BuildingQueueRepository`, `Asylamba\Modules\Athena\...mmercialRouteRepository`, `Asylamba\Modules\Athena\...rcialShippingRepository`, `Asylamba\Modules\Athena\...y\OrbitalBaseRepository`, `Asylamba\Modules\Athena\...ory\ShipQueueRepository`, `Asylamba\Modules\Athena\...y\TransactionRepository`, `Asylamba\Modules\Demeter...ository\ColorRepository`, `Asylamba\Modules\Demeter...ion\CandidateRepository`, `Asylamba\Modules\Demeter...tion\ElectionRepository`, `Asylamba\Modules\Demeter...m\FactionNewsRepository`, `Asylamba\Modules\Demeter...itory\Law\LawRepository`, `Asylamba\Modules\Gaia\Repository\PlaceRepository`, `Asylamba\Modules\Gaia\Repository\SectorRepository`, `Asylamba\Modules\Gaia\Repository\SystemRepository`, `Asylamba\Modules\Hermes\...\NotificationRepository`, `Asylamba\Modules\Prometh...chnologyQueueRepository`, `Asylamba\Modules\Zeus\Repository\PlayerRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
50			}
51
52			/**
53			* @param int $playerId
54			* @param int $technology
55			* @return TechnologyQueue
56			*/
57			public function getPlayerTechnologyQueue($playerId, $technology)
58			{
59			return $this->entityManager->getRepository(TechnologyQueue::class)->getPlayerTechnologyQueue($playerId, $technology);
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getPlayerTechnologyQueue()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Prometh...chnologyQueueRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
60			}
61
62			/**
63			* @param int $placeId
64			* @return array
65			*/
66			public function getPlaceQueues($placeId)
67			{
68			return $this->entityManager->getRepository(TechnologyQueue::class)->getPlaceQueues($placeId);
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getPlaceQueues()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Prometh...chnologyQueueRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
69			}
70
71			/**
72			* @param int $playerId
73			* @return array
74			*/
75			public function getPlayerQueues($playerId)
76			{
77			return $this->entityManager->getRepository(TechnologyQueue::class)->getPlayerQueues($playerId);
			0 ignored issues – show Bug introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Asylamba\Classes\Entity\AbstractRepository` as the method `getPlayerQueues()` does only exist in the following sub-classes of `Asylamba\Classes\Entity\AbstractRepository`: `Asylamba\Modules\Prometh...chnologyQueueRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
78			}
79
80			/**
81			* @param TechnologyQueue $technologyQueue
82			*/
83			public function add(TechnologyQueue $technologyQueue) {
84			$this->entityManager->persist($technologyQueue);
85			$this->entityManager->flush($technologyQueue);
86
87			$this->realtimeActionScheduler->schedule('athena.orbital_base_manager', 'uTechnologyQueue', $technologyQueue, $technologyQueue->getEndedAt());
			0 ignored issues – show Documentation introduced 2017-06-26 15:02 UTC by Report Bug Copy Issue Report `$technologyQueue` is of type `object<Asylamba\Modules\...\Model\TechnologyQueue>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
88			}
89			}

rtfmcorp / asylamba-game

GitHub Access Token became invalid

Push — master ( 11c0a1...856a6b )

TechnologyQueueManager::save() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like