FightManager::setEnvironmentBonus() - Code Metrics - rtfmcorp/asylamba-game - Measure and Improve Code Quality continuously with Scrutinizer

FightManager::setEnvironmentBonus() F
last analyzed 2017-08-11 17:07 UTC

↳ Parent: FightManager

Complexity

Conditions	21
Paths	1536

Size

Total Lines	67
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	21
eloc	37
nc	1536
nop	2
dl	0
loc	67
rs	2.7383
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

/**
 * Fight Controller
 *
 * @author Noé Zufferey
 * @copyright Expansion - le jeu
 *
 * @package Arès
 * @update 14.02.14
*/
namespace Asylamba\Modules\Ares\Manager;

use Asylamba\Classes\Library\DataAnalysis;
use Asylamba\Classes\Library\Utils;
use Asylamba\Modules\Ares\Model\LiveReport;
use Asylamba\Modules\Athena\Resource\ShipResource;

class FightManager {
	/** @var CommanderManager **/
	protected $commanderManager;
	
	/**
	 * @param \Asylamba\Modules\Ares\Manager\CommanderManager $commanderManager
	 */
	public function __construct(CommanderManager $commanderManager)
	{
		$this->commanderManager = $commanderManager;
		self::$currentLine = 3;
	}
	
	private $isAFight = FALSE;

	# ATTRIBUT STATIC DE LIGNE COURANTE
	
	private static $currentLine = 0;
	
	private static $AFighterBonus = array(1, 1, 1, 1);
	private static $ACorvetteBonus = array(1, 1, 1, 1);
	private static $AFrigateBonus = array(1, 1, 1, 1);
	private static $ADestroyerBonus = array(1, 1, 1, 1);
	
	private static $DFighterBonus = array(1, 1, 1, 1);
	private static $DCorvetteBonus = array(1, 1, 1, 1);
	private static $DFrigateBonus = array(1, 1, 1, 1);
	private static $DDestroyerBonus = array(1, 1, 1, 1);
	
	public function setFightControl($isAFight = false)
	{
		$this->isAFight = $isAFight;
	}
	
	# GETTER
	
	public static function getCurrentLine() {
		return self::$currentLine;
	}
	
	public static function getAFighterBonus($i) {
		return self::$AFighterBonus[$i];
	}
	public static function getACorvetteBonus($i) {
		return self::$ACorvetteBonus[$i];
	}
	public static function getAFrigateBonus($i) {
		return self::$AFrigateBonus[$i];
	}
	public static function getADestroyerBonus($i) {
		return self::$ADestroyerBonus[$i];
	}
	
	public static function getDFighterBonus($i) {
		return self::$DFighterBonus[$i];
	}
	public static function getDCorvetteBonus($i) {
		return self::$DCorvetteBonus[$i];
	}
	public static function getDFrigateBonus($i) {
		return self::$DFrigateBonus[$i];
	}
	public static function getDDestroyerBonus($i) {
		return self::$DDestroyerBonus[$i];
	}
	
	
	
	// SETTER
	
	public function setPlayerBonus($ABonus, $DBonus) {
		if (isset($ABonus['global'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFighterBonus[$i] += $ABonus['global'][$i];
				self::$ACorvetteBonus[$i] += $ABonus['global'][$i];
				self::$AFrigateBonus[$i] += $ABonus['global'][$i];
				self::$ADestroyerBonus[$i] += $ABonus['global'][$i];
			}
		}
		
		if (isset($ABonus['fighter'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFighterBonus[$i] += $ABonus['fighter'][$i];
			}
		}
		
		if (isset($ABonus['corvette'])) {
			for($i = 0; $i < 4; $i++) {

				self::$ACorvetteBonus[$i] += $ABonus['corvette'][$i];
			}
		}
		
		if (isset($ABonus['frigate'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFrigateBonus[$i] += $ABonus['frigate'][$i];
			}
		}
		
		if (isset($ABonus['destroyer'])) {
			for($i = 0; $i < 4; $i++) {

				self::$ADestroyerBonus[$i] += $ABonus['destroyer'][$i];
			}
		}
		
		if (isset($DBonus['global'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFighterBonus[$i] += $DBonus['global'][$i];
				self::$DCorvetteBonus[$i] += $DBonus['global'][$i];
				self::$DFrigateBonus[$i] += $DBonus['global'][$i];
				self::$DDestroyerBonus[$i] += $DBonus['global'][$i];
			}
		}
		
		if (isset($DBonus['fighter'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFighterBonus[$i] += $DBonus['fighter'][$i];
			}
		}
		
		if (isset($DBonus['corvette'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DCorvetteBonus[$i] += $DBonus['corvette'][$i];
			}
		}
		
		if (isset($DBonus['frigate'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFrigateBonus[$i] += $DBonus['frigate'][$i];
			}
		}
		
		if (isset($DBonus['destroyer'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DDestroyerBonus[$i] += $DBonus['destroyer'][$i];
			}
		}
			
	}
	
	public function setEnvironmentBonus($ABonus, $DBonus) {
		if (isset($ABonus['global'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFighterBonus[$i] += $ABonus['global'][$i];
				self::$ACorvetteBonus[$i] += $ABonus['global'][$i];
				self::$AFrigateBonus[$i] += $ABonus['global'][$i];
				self::$ADestroyerBonus[$i] += $ABonus['global'][$i];
			}
		}
		
		if (isset($ABonus['fighter'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFighterBonus[$i] += $ABonus['fighter'][$i];
			}
		}
		
		if (isset($ABonus['corvette'])) {
			for($i = 0; $i < 4; $i++) {

				self::$ACorvetteBonus[$i] += $ABonus['corvette'][$i];
			}
		}
		
		if (isset($ABonus['frigate'])) {
			for($i = 0; $i < 4; $i++) {

				self::$AFrigateBonus[$i] += $ABonus['frigate'][$i];
			}
		}
		
		if (isset($ABonus['destroyer'])) {
			for($i = 0; $i < 4; $i++) {

				self::$ADestroyerBonus[$i] += $ABonus['destroyer'][$i];
			}
		}
		
		if (isset($DBonus['global'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFighterBonus[$i] += $DBonus['global'][$i];
				self::$DCorvetteBonus[$i] += $DBonus['global'][$i];
				self::$DFrigateBonus[$i] += $DBonus['global'][$i];
				self::$DDestroyerBonus[$i] += $DBonus['global'][$i];
			}
		}
		
		if (isset($DBonus['fighter'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFighterBonus[$i] += $DBonus['fighter'][$i];
			}
		}
		
		if (isset($DBonus['corvette'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DCorvetteBonus[$i] += $DBonus['corvette'][$i];
			}
		}
		
		if (isset($DBonus['frigate'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DFrigateBonus[$i] += $DBonus['frigate'][$i];
			}
		}
		
		if (isset($DBonus['destroyer'])) {
			for($i = 0; $i < 4; $i++) {

				self::$DDestroyerBonus[$i] += $DBonus['destroyer'][$i];
			}
		}
	}
	
	/**
	 * DEMARE LE COMBAT ENTRE DEUX COMMANDANT
	 *		COMPTE L'ARMEE D
	 *		si 0 vaisseaux
	 *			A gagne
	 *		SINON COMBAT
	 *		COMPTE L'ARMEE A
	 *		si 0 vaisseaux
	 *			D gagne
	 *		SINON COMBAT
	*/

	public function startFight($commanderA, $playerA, $commanderD, $playerD = NULL) {
		$commanderA->setIsAttacker(TRUE);
		$commanderD->setIsAttacker(FALSE);
		
		$commanderA->setPevInBegin();
		$commanderD->setPevInBegin();

		LiveReport::$rPlayerAttacker = $commanderA->rPlayer;
		LiveReport::$rPlayerDefender = $commanderD->rPlayer;

		LiveReport::$avatarA = $commanderA->avatar;
		LiveReport::$avatarD = $commanderD->avatar;
		LiveReport::$nameA = $commanderA->name;
		LiveReport::$nameD = $commanderD->name;
		LiveReport::$levelA = $commanderA->level;
		LiveReport::$levelD = $commanderD->level;
		LiveReport::$experienceA = $commanderA->experience;
		LiveReport::$experienceD = $commanderD->experience;
		LiveReport::$palmaresA = $commanderA->palmares;
		LiveReport::$palmaresD = $commanderD->palmares;

		$shipsA = $commanderA->getNbrShipByType();
		$shipsD = $commanderD->getNbrShipByType();
		$weight = 0;

		for ($i = 0; $i < count($shipsA); $i++) { 
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
			$weight += DataAnalysis::resourceToStdUnit(ShipResource::getInfo($i, 'resourcePrice') * $shipsA[$i]);
			$weight += DataAnalysis::resourceToStdUnit(ShipResource::getInfo($i, 'resourcePrice') * $shipsD[$i]);
		}

		LiveReport::$importance = $weight;

		$i = 0;
		foreach ($commanderA->armyInBegin AS $s) {

			LiveReport::$squadrons[] = array(0, $i, 0, 0, $commanderA->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
			$i++;
		}
		$i = 0;
		foreach ($commanderD->armyInBegin AS $s) {

			LiveReport::$squadrons[] = array(0, $i, 0, 0, $commanderD->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
			$i++;
		}
	
		while(1) {

			if (LiveReport::$round == 1000) {
				break;
			}
			$nbrShipsD = 0;
			$nbrShipsA = 0;
			
			foreach ($commanderA->getArmy() as $squadronA) {
				$nbrShipsA += $squadronA->getNbrShips();
			}
			if ($nbrShipsA == 0) {
				$this->commanderManager->resultOfFight($commanderD, TRUE, $commanderA);
				$this->commanderManager->resultOfFight($commanderA, FALSE, $commanderD);
				$commanderA->setStatement(3);
				$commanderD->setDDeath(Utils::now());
				LiveReport::$rPlayerWinner = $commanderD->rPlayer;

				if ($commanderD->rPlayer != ID_GAIA) {
					$playerD->increaseVictory(1);
					$playerA->increaseDefeat(1);
				} else{

					$playerA->increaseDefeat(1);
				}

				break;
			} else {
				$commanderA = $this->commanderManager->engage($commanderD, $commanderA);
				LiveReport::$halfround++;
			}
			
			foreach ($commanderD->getArmy() as $squadronD) {
				$nbrShipsD += $squadronD->getNbrShips();
			}
			if($nbrShipsD == 0) {

				$this->commanderManager->resultOfFight($commanderA, TRUE, $commanderD);
				$this->commanderManager->resultOfFight($commanderD, FALSE, $commanderA);
				$commanderD->setStatement(3);
				$commanderD->setDDeath(Utils::now());
				LiveReport::$rPlayerWinner = $commanderA->rPlayer;

				if ($commanderD->rPlayer != ID_GAIA) {
					$playerA->increaseVictory(1);
					$playerD->increaseDefeat(1);
				} else {
					$playerA->increaseVictory(1);
				}

				break;
			} else {
				$commanderD = $this->commanderManager->engage($commanderA, $commanderD);
				LiveReport::$halfround++;
			}
			
			LiveReport::$round++;
			self::$currentLine++;
		}

		$i = 0;
		foreach ($commanderA->armyAtEnd AS $s) {

			LiveReport::$squadrons[] = array(0, $i, 0, -1, $commanderA->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
			$i++;
		}
		$i = 0;
		foreach ($commanderD->armyAtEnd AS $s) {

			LiveReport::$squadrons[] = array(0, $i, 0, -1, $commanderD->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
			$i++;
		}
		return array($commanderA, $commanderD);
	}
}

1			<?php
2
3			/**
4			* Fight Controller
5			*
6			* @author Noé Zufferey
7			* @copyright Expansion - le jeu
8			*
9			* @package Arès
10			* @update 14.02.14
11			*/
12			namespace Asylamba\Modules\Ares\Manager;
13
14			use Asylamba\Classes\Library\DataAnalysis;
15			use Asylamba\Classes\Library\Utils;
16			use Asylamba\Modules\Ares\Model\LiveReport;
17			use Asylamba\Modules\Athena\Resource\ShipResource;
18
19			class FightManager {
20			/ @var CommanderManager /
21			protected $commanderManager;
22
23			/**
24			* @param \Asylamba\Modules\Ares\Manager\CommanderManager $commanderManager
25			*/
26			public function __construct(CommanderManager $commanderManager)
27			{
28			$this->commanderManager = $commanderManager;
29			self::$currentLine = 3;
30			}
31
32			private $isAFight = FALSE;
33
34			# ATTRIBUT STATIC DE LIGNE COURANTE
35
36			private static $currentLine = 0;
37
38			private static $AFighterBonus = array(1, 1, 1, 1);
39			private static $ACorvetteBonus = array(1, 1, 1, 1);
40			private static $AFrigateBonus = array(1, 1, 1, 1);
41			private static $ADestroyerBonus = array(1, 1, 1, 1);
42
43			private static $DFighterBonus = array(1, 1, 1, 1);
44			private static $DCorvetteBonus = array(1, 1, 1, 1);
45			private static $DFrigateBonus = array(1, 1, 1, 1);
46			private static $DDestroyerBonus = array(1, 1, 1, 1);
47
48			public function setFightControl($isAFight = false)
49			{
50			$this->isAFight = $isAFight;
51			}
52
53			# GETTER
54
55			public static function getCurrentLine() {
56			return self::$currentLine;
57			}
58
59			public static function getAFighterBonus($i) {
60			return self::$AFighterBonus[$i];
61			}
62			public static function getACorvetteBonus($i) {
63			return self::$ACorvetteBonus[$i];
64			}
65			public static function getAFrigateBonus($i) {
66			return self::$AFrigateBonus[$i];
67			}
68			public static function getADestroyerBonus($i) {
69			return self::$ADestroyerBonus[$i];
70			}
71
72			public static function getDFighterBonus($i) {
73			return self::$DFighterBonus[$i];
74			}
75			public static function getDCorvetteBonus($i) {
76			return self::$DCorvetteBonus[$i];
77			}
78			public static function getDFrigateBonus($i) {
79			return self::$DFrigateBonus[$i];
80			}
81			public static function getDDestroyerBonus($i) {
82			return self::$DDestroyerBonus[$i];
83			}
84
85
86
87			// SETTER
88
89			public function setPlayerBonus($ABonus, $DBonus) {
90			if (isset($ABonus['global'])) {
91			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
92			self::$AFighterBonus[$i] += $ABonus['global'][$i];
93			self::$ACorvetteBonus[$i] += $ABonus['global'][$i];
94			self::$AFrigateBonus[$i] += $ABonus['global'][$i];
95			self::$ADestroyerBonus[$i] += $ABonus['global'][$i];
96			}
97			}
98
99			if (isset($ABonus['fighter'])) {
100			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
101			self::$AFighterBonus[$i] += $ABonus['fighter'][$i];
102			}
103			}
104
105			if (isset($ABonus['corvette'])) {
106			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
107			self::$ACorvetteBonus[$i] += $ABonus['corvette'][$i];
108			}
109			}
110
111			if (isset($ABonus['frigate'])) {
112			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
113			self::$AFrigateBonus[$i] += $ABonus['frigate'][$i];
114			}
115			}
116
117			if (isset($ABonus['destroyer'])) {
118			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
119			self::$ADestroyerBonus[$i] += $ABonus['destroyer'][$i];
120			}
121			}
122
123			if (isset($DBonus['global'])) {
124			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
125			self::$DFighterBonus[$i] += $DBonus['global'][$i];
126			self::$DCorvetteBonus[$i] += $DBonus['global'][$i];
127			self::$DFrigateBonus[$i] += $DBonus['global'][$i];
128			self::$DDestroyerBonus[$i] += $DBonus['global'][$i];
129			}
130			}
131
132			if (isset($DBonus['fighter'])) {
133			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
134			self::$DFighterBonus[$i] += $DBonus['fighter'][$i];
135			}
136			}
137
138			if (isset($DBonus['corvette'])) {
139			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
140			self::$DCorvetteBonus[$i] += $DBonus['corvette'][$i];
141			}
142			}
143
144			if (isset($DBonus['frigate'])) {
145			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
146			self::$DFrigateBonus[$i] += $DBonus['frigate'][$i];
147			}
148			}
149
150			if (isset($DBonus['destroyer'])) {
151			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
152			self::$DDestroyerBonus[$i] += $DBonus['destroyer'][$i];
153			}
154			}
155
156			}
157
158			public function setEnvironmentBonus($ABonus, $DBonus) {
159			if (isset($ABonus['global'])) {
160			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
161			self::$AFighterBonus[$i] += $ABonus['global'][$i];
162			self::$ACorvetteBonus[$i] += $ABonus['global'][$i];
163			self::$AFrigateBonus[$i] += $ABonus['global'][$i];
164			self::$ADestroyerBonus[$i] += $ABonus['global'][$i];
165			}
166			}
167
168			if (isset($ABonus['fighter'])) {
169			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
170			self::$AFighterBonus[$i] += $ABonus['fighter'][$i];
171			}
172			}
173
174			if (isset($ABonus['corvette'])) {
175			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
176			self::$ACorvetteBonus[$i] += $ABonus['corvette'][$i];
177			}
178			}
179
180			if (isset($ABonus['frigate'])) {
181			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
182			self::$AFrigateBonus[$i] += $ABonus['frigate'][$i];
183			}
184			}
185
186			if (isset($ABonus['destroyer'])) {
187			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
188			self::$ADestroyerBonus[$i] += $ABonus['destroyer'][$i];
189			}
190			}
191
192			if (isset($DBonus['global'])) {
193			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
194			self::$DFighterBonus[$i] += $DBonus['global'][$i];
195			self::$DCorvetteBonus[$i] += $DBonus['global'][$i];
196			self::$DFrigateBonus[$i] += $DBonus['global'][$i];
197			self::$DDestroyerBonus[$i] += $DBonus['global'][$i];
198			}
199			}
200
201			if (isset($DBonus['fighter'])) {
202			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
203			self::$DFighterBonus[$i] += $DBonus['fighter'][$i];
204			}
205			}
206
207			if (isset($DBonus['corvette'])) {
208			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
209			self::$DCorvetteBonus[$i] += $DBonus['corvette'][$i];
210			}
211			}
212
213			if (isset($DBonus['frigate'])) {
214			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
215			self::$DFrigateBonus[$i] += $DBonus['frigate'][$i];
216			}
217			}
218
219			if (isset($DBonus['destroyer'])) {
220			for($i = 0; $i < 4; $i++) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
221			self::$DDestroyerBonus[$i] += $DBonus['destroyer'][$i];
222			}
223			}
224			}
225
226			/**
227			* DEMARE LE COMBAT ENTRE DEUX COMMANDANT
228			* COMPTE L'ARMEE D
229			* si 0 vaisseaux
230			* A gagne
231			* SINON COMBAT
232			* COMPTE L'ARMEE A
233			* si 0 vaisseaux
234			* D gagne
235			* SINON COMBAT
236			*/
237
238			public function startFight($commanderA, $playerA, $commanderD, $playerD = NULL) {
239			$commanderA->setIsAttacker(TRUE);
240			$commanderD->setIsAttacker(FALSE);
241
242			$commanderA->setPevInBegin();
243			$commanderD->setPevInBegin();
244
245			LiveReport::$rPlayerAttacker = $commanderA->rPlayer;
246			LiveReport::$rPlayerDefender = $commanderD->rPlayer;
247
248			LiveReport::$avatarA = $commanderA->avatar;
249			LiveReport::$avatarD = $commanderD->avatar;
250			LiveReport::$nameA = $commanderA->name;
251			LiveReport::$nameD = $commanderD->name;
252			LiveReport::$levelA = $commanderA->level;
253			LiveReport::$levelD = $commanderD->level;
254			LiveReport::$experienceA = $commanderA->experience;
255			LiveReport::$experienceD = $commanderD->experience;
256			LiveReport::$palmaresA = $commanderA->palmares;
257			LiveReport::$palmaresD = $commanderD->palmares;
258
259			$shipsA = $commanderA->getNbrShipByType();
260			$shipsD = $commanderD->getNbrShipByType();
261			$weight = 0;
262
263			for ($i = 0; $i < count($shipsA); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
264			$weight += DataAnalysis::resourceToStdUnit(ShipResource::getInfo($i, 'resourcePrice') * $shipsA[$i]);
265			$weight += DataAnalysis::resourceToStdUnit(ShipResource::getInfo($i, 'resourcePrice') * $shipsD[$i]);
266			}
267
268			LiveReport::$importance = $weight;
269
270			$i = 0;
271			foreach ($commanderA->armyInBegin AS $s) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report AS keyword must be lowercase; expected "as" but found "AS" Loading history... Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `as`, but found `AS`. Loading history...
272			LiveReport::$squadrons[] = array(0, $i, 0, 0, $commanderA->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
273			$i++;
274			}
275			$i = 0;
276			foreach ($commanderD->armyInBegin AS $s) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report AS keyword must be lowercase; expected "as" but found "AS" Loading history... Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `as`, but found `AS`. Loading history...
277			LiveReport::$squadrons[] = array(0, $i, 0, 0, $commanderD->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
278			$i++;
279			}
280
281			while(1) {
			0 ignored issues – show Coding Style introduced 2017-05-25 00:14 UTC by Report Bug Copy Issue Report Expected 1 space after WHILE keyword; 0 found Loading history...
282			if (LiveReport::$round == 1000) {
283			break;
284			}
285			$nbrShipsD = 0;
286			$nbrShipsA = 0;
287
288			foreach ($commanderA->getArmy() as $squadronA) {
289			$nbrShipsA += $squadronA->getNbrShips();
290			}
291			if ($nbrShipsA == 0) {
292			$this->commanderManager->resultOfFight($commanderD, TRUE, $commanderA);
293			$this->commanderManager->resultOfFight($commanderA, FALSE, $commanderD);
294			$commanderA->setStatement(3);
295			$commanderD->setDDeath(Utils::now());
296			LiveReport::$rPlayerWinner = $commanderD->rPlayer;
297
298			if ($commanderD->rPlayer != ID_GAIA) {
299			$playerD->increaseVictory(1);
300			$playerA->increaseDefeat(1);
301			} else{
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after ELSE keyword; 0 found Loading history...
302			$playerA->increaseDefeat(1);
303			}
304
305			break;
306			} else {
307			$commanderA = $this->commanderManager->engage($commanderD, $commanderA);
308			LiveReport::$halfround++;
309			}
310
311			foreach ($commanderD->getArmy() as $squadronD) {
312			$nbrShipsD += $squadronD->getNbrShips();
313			}
314			if($nbrShipsD == 0) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
315			$this->commanderManager->resultOfFight($commanderA, TRUE, $commanderD);
316			$this->commanderManager->resultOfFight($commanderD, FALSE, $commanderA);
317			$commanderD->setStatement(3);
318			$commanderD->setDDeath(Utils::now());
319			LiveReport::$rPlayerWinner = $commanderA->rPlayer;
320
321			if ($commanderD->rPlayer != ID_GAIA) {
322			$playerA->increaseVictory(1);
323			$playerD->increaseDefeat(1);
324			} else {
325			$playerA->increaseVictory(1);
326			}
327
328			break;
329			} else {
330			$commanderD = $this->commanderManager->engage($commanderA, $commanderD);
331			LiveReport::$halfround++;
332			}
333
334			LiveReport::$round++;
335			self::$currentLine++;
336			}
337
338			$i = 0;
339			foreach ($commanderA->armyAtEnd AS $s) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report AS keyword must be lowercase; expected "as" but found "AS" Loading history... Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `as`, but found `AS`. Loading history...
340			LiveReport::$squadrons[] = array(0, $i, 0, -1, $commanderA->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
341			$i++;
342			}
343			$i = 0;
344			foreach ($commanderD->armyAtEnd AS $s) {
			0 ignored issues – show Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report AS keyword must be lowercase; expected "as" but found "AS" Loading history... Coding Style introduced 2016-11-01 21:25 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `as`, but found `AS`. Loading history...
345			LiveReport::$squadrons[] = array(0, $i, 0, -1, $commanderD->id, $s[0], $s[1], $s[2], $s[3], $s[4], $s[5], $s[6], $s[7], $s[8], $s[9], $s[10], $s[11]);
346			$i++;
347			}
348			return array($commanderA, $commanderD);
349			}
350			}

rtfmcorp / asylamba-game

GitHub Access Token became invalid

FightManager::setEnvironmentBonus() F last analyzed 2017-08-11 17:07 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

FightManager::setEnvironmentBonus() F
last analyzed 2017-08-11 17:07 UTC