Issues in WebApplication.php (master) - Issues in master - rtens/domin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (90)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/delivery/web/WebApplication.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace rtens\domin\delivery\web;

use rtens\domin\ActionRegistry;
use rtens\domin\delivery\FieldRegistry;
use rtens\domin\delivery\RendererRegistry;
use rtens\domin\delivery\web\fields\ActionField;
use rtens\domin\delivery\web\fields\ArrayField;
use rtens\domin\delivery\web\fields\BooleanField;
use rtens\domin\delivery\web\fields\ColorField;
use rtens\domin\delivery\web\fields\DateIntervalField;
use rtens\domin\delivery\web\fields\DateTimeField;
use rtens\domin\delivery\web\fields\EnumerationField;
use rtens\domin\delivery\web\fields\FileField;
use rtens\domin\delivery\web\fields\HtmlField;
use rtens\domin\delivery\web\fields\IdentifierField;
use rtens\domin\delivery\web\fields\ImageField;
use rtens\domin\delivery\web\fields\MultiField;
use rtens\domin\delivery\web\fields\NullableField;
use rtens\domin\delivery\web\fields\NumberField;
use rtens\domin\delivery\web\fields\ObjectField;
use rtens\domin\delivery\web\fields\RangeField;
use rtens\domin\delivery\web\fields\StringField;
use rtens\domin\delivery\web\fields\TextField;
use rtens\domin\delivery\web\home\ActionListRenderer;
use rtens\domin\delivery\web\home\ListActions;
use rtens\domin\delivery\web\menu\Menu;
use rtens\domin\delivery\web\renderers\BooleanRenderer;
use rtens\domin\delivery\web\renderers\charting\ChartRenderer;
use rtens\domin\delivery\web\renderers\charting\ScatterChartRenderer;
use rtens\domin\delivery\web\renderers\ColorRenderer;
use rtens\domin\delivery\web\renderers\dashboard\ActionPanelRenderer;
use rtens\domin\delivery\web\renderers\dashboard\DashboardItemRenderer;
use rtens\domin\delivery\web\renderers\DateIntervalRenderer;
use rtens\domin\delivery\web\renderers\DateTimeRenderer;
use rtens\domin\delivery\web\renderers\DelayedOutputRenderer;
use rtens\domin\delivery\web\renderers\ElementRenderer;
use rtens\domin\delivery\web\renderers\FileRenderer;
use rtens\domin\delivery\web\renderers\HtmlRenderer;
use rtens\domin\delivery\web\renderers\IdentifierRenderer;
use rtens\domin\delivery\web\renderers\ImageRenderer;
use rtens\domin\delivery\web\renderers\link\LinkPrinter;
use rtens\domin\delivery\web\renderers\link\LinkRegistry;
use rtens\domin\delivery\web\renderers\ListRenderer;
use rtens\domin\delivery\web\renderers\MapRenderer;
use rtens\domin\delivery\web\renderers\ObjectRenderer;
use rtens\domin\delivery\web\renderers\PrimitiveRenderer;
use rtens\domin\delivery\web\renderers\tables\DataTableRenderer;
use rtens\domin\delivery\web\renderers\tables\TableRenderer;
use rtens\domin\delivery\web\renderers\TextRenderer;
use rtens\domin\execution\access\AccessControl;
use rtens\domin\parameters\IdentifiersProvider;
use rtens\domin\reflection\CommentParser;
use rtens\domin\reflection\types\TypeFactory;
use watoki\factory\Factory;

class WebApplication {

    const INDEX_ACTION = 'index';

    /** @var string */
    public $name = 'domin';

    /** @var Factory */
    public $factory;

    /** @var ActionRegistry */
    public $actions;

    /** @var RendererRegistry */
    public $renderers;

    /** @var LinkRegistry */
    public $links;

    /** @var TypeFactory */
    public $types;

    /** @var FieldRegistry */
    public $fields;

    /** @var IdentifiersProvider */
    public $identifiers;

    /** @var Menu */
    public $menu;

    /** @var MobileDetector */
    public $detector;

    /** @var CommentParser */
    public $parser;

    /** @var AccessControl */
    public $access;

    /** @var ActionGroups */
    public $groups;

    /** @var null|ExecutionToken */
    public $token;

    /** @var string */
    public $defaultAction = self::INDEX_ACTION;

    /**
     * @param Factory $factory <-
     * @param ActionRegistry $actions <-
     * @param FieldRegistry $fields <-
     * @param RendererRegistry $renderers <-
     * @param LinkRegistry $links <-
     * @param IdentifiersProvider $identifiers <-
     * @param TypeFactory $types <-
     * @param MobileDetector $detect <-
     * @param WebCommentParser $parser <-
     * @param AccessControl $access <-
     */
    public function __construct(Factory $factory, ActionRegistry $actions, FieldRegistry $fields,
                                RendererRegistry $renderers, LinkRegistry $links, IdentifiersProvider $identifiers,
                                TypeFactory $types, MobileDetector $detect, WebCommentParser $parser,
                                AccessControl $access) {
        $factory->setSingleton($this);

        $this->factory = $factory;
        $this->actions = $actions;
        $this->renderers = $renderers;
        $this->links = $links;
        $this->types = $types;
        $this->fields = $fields;
        $this->identifiers = $identifiers;
        $this->detector = $detect;
        $this->parser = $parser;
        $this->access = $access;
        $this->menu = new Menu($actions);

        $this->groups = new ActionGroups($actions);
    }

    /**
     * @param callable $callback Receives the WebApplication instance
     * @param null|Factory $factory
     * @return Factory
     */
    public static function init(callable $callback, Factory $factory = null) {
        /** @var self $instance */
        $factory = $factory ?: new Factory();
        $instance = $factory->getInstance(self::class);

        $instance->registerDefaultAction();

        $callback($factory->setSingleton($instance));

        $instance->prepare();

        return $factory;
    }

    /**
     * @param string $name
     */
    public function setNameAndBrand($name) {
        $this->name = $name;
        $this->menu->setBrand($name);
    }

    private function registerDefaultAction() {

        $this->actions->add(self::INDEX_ACTION , new ListActions($this->actions, $this->groups, $this->access, $this->parser));
    }

    public function prepare() {
        $this->registerRenderers();
        $this->registerFields();
    }

    private function registerRenderers() {
        $links = new LinkPrinter($this->links, $this->actions, $this->parser, $this->token);


        $this->renderers->add(new ElementRenderer());
        $this->renderers->add(new BooleanRenderer());
        $this->renderers->add(new ColorRenderer());
        $this->renderers->add(new PrimitiveRenderer());
        $this->renderers->add(new DateTimeRenderer());
        $this->renderers->add(new DateIntervalRenderer());
        $this->renderers->add(new TextRenderer());
        $this->renderers->add(new HtmlRenderer());
        $this->renderers->add(new IdentifierRenderer($links));
        $this->renderers->add(new FileRenderer());
        $this->renderers->add(new ImageRenderer());
        $this->renderers->add(new ScatterChartRenderer());
        $this->renderers->add(new ChartRenderer());
        $this->renderers->add(new DelayedOutputRenderer());
        $this->renderers->add(new DashboardItemRenderer($this->renderers));
        $this->renderers->add(new ActionListRenderer($this->parser));
        $this->renderers->add(new ActionPanelRenderer($this->renderers, $this->actions, $this->fields));
        $this->renderers->add(new DataTableRenderer($this->renderers));
        $this->renderers->add(new TableRenderer($this->renderers, $links));
        $this->renderers->add(new ListRenderer($this->renderers, $links));
        $this->renderers->add(new MapRenderer($this->renderers, $links));
        $this->renderers->add(new ObjectRenderer($this->renderers, $this->types, $links));
    }

    private function registerFields() {
        $this->fields->add(new StringField());
        $this->fields->add(new NumberField());
        $this->fields->add(new RangeField($this->detector));
        $this->fields->add(new BooleanField());
        $this->fields->add(new ColorField());
        $this->fields->add(new FileField());
        $this->fields->add(new ImageField());
        $this->fields->add(new TextField());
        $this->fields->add(new HtmlField());
        $this->fields->add(new DateTimeField());
        $this->fields->add(new DateIntervalField());
        $this->fields->add(new ArrayField($this->fields, $this->detector));
        $this->fields->add(new NullableField($this->fields));
        $this->fields->add(new ActionField($this->fields, $this->actions));
        $this->fields->add(new ObjectField($this->types, $this->fields));
        $this->fields->add(new MultiField($this->fields));
        $this->fields->add(new IdentifierField($this->fields, $this->identifiers));
        $this->fields->add(new EnumerationField($this->fields));
    }
}

1			<?php
2			namespace rtens\domin\delivery\web;
3
4			use rtens\domin\ActionRegistry;
5			use rtens\domin\delivery\FieldRegistry;
6			use rtens\domin\delivery\RendererRegistry;
7			use rtens\domin\delivery\web\fields\ActionField;
8			use rtens\domin\delivery\web\fields\ArrayField;
9			use rtens\domin\delivery\web\fields\BooleanField;
10			use rtens\domin\delivery\web\fields\ColorField;
11			use rtens\domin\delivery\web\fields\DateIntervalField;
12			use rtens\domin\delivery\web\fields\DateTimeField;
13			use rtens\domin\delivery\web\fields\EnumerationField;
14			use rtens\domin\delivery\web\fields\FileField;
15			use rtens\domin\delivery\web\fields\HtmlField;
16			use rtens\domin\delivery\web\fields\IdentifierField;
17			use rtens\domin\delivery\web\fields\ImageField;
18			use rtens\domin\delivery\web\fields\MultiField;
19			use rtens\domin\delivery\web\fields\NullableField;
20			use rtens\domin\delivery\web\fields\NumberField;
21			use rtens\domin\delivery\web\fields\ObjectField;
22			use rtens\domin\delivery\web\fields\RangeField;
23			use rtens\domin\delivery\web\fields\StringField;
24			use rtens\domin\delivery\web\fields\TextField;
25			use rtens\domin\delivery\web\home\ActionListRenderer;
26			use rtens\domin\delivery\web\home\ListActions;
27			use rtens\domin\delivery\web\menu\Menu;
28			use rtens\domin\delivery\web\renderers\BooleanRenderer;
29			use rtens\domin\delivery\web\renderers\charting\ChartRenderer;
30			use rtens\domin\delivery\web\renderers\charting\ScatterChartRenderer;
31			use rtens\domin\delivery\web\renderers\ColorRenderer;
32			use rtens\domin\delivery\web\renderers\dashboard\ActionPanelRenderer;
33			use rtens\domin\delivery\web\renderers\dashboard\DashboardItemRenderer;
34			use rtens\domin\delivery\web\renderers\DateIntervalRenderer;
35			use rtens\domin\delivery\web\renderers\DateTimeRenderer;
36			use rtens\domin\delivery\web\renderers\DelayedOutputRenderer;
37			use rtens\domin\delivery\web\renderers\ElementRenderer;
38			use rtens\domin\delivery\web\renderers\FileRenderer;
39			use rtens\domin\delivery\web\renderers\HtmlRenderer;
40			use rtens\domin\delivery\web\renderers\IdentifierRenderer;
41			use rtens\domin\delivery\web\renderers\ImageRenderer;
42			use rtens\domin\delivery\web\renderers\link\LinkPrinter;
43			use rtens\domin\delivery\web\renderers\link\LinkRegistry;
44			use rtens\domin\delivery\web\renderers\ListRenderer;
45			use rtens\domin\delivery\web\renderers\MapRenderer;
46			use rtens\domin\delivery\web\renderers\ObjectRenderer;
47			use rtens\domin\delivery\web\renderers\PrimitiveRenderer;
48			use rtens\domin\delivery\web\renderers\tables\DataTableRenderer;
49			use rtens\domin\delivery\web\renderers\tables\TableRenderer;
50			use rtens\domin\delivery\web\renderers\TextRenderer;
51			use rtens\domin\execution\access\AccessControl;
52			use rtens\domin\parameters\IdentifiersProvider;
53			use rtens\domin\reflection\CommentParser;
54			use rtens\domin\reflection\types\TypeFactory;
55			use watoki\factory\Factory;
56
57			class WebApplication {
58
59			const INDEX_ACTION = 'index';
60
61			/** @var string */
62			public $name = 'domin';
63
64			/** @var Factory */
65			public $factory;
66
67			/** @var ActionRegistry */
68			public $actions;
69
70			/** @var RendererRegistry */
71			public $renderers;
72
73			/** @var LinkRegistry */
74			public $links;
75
76			/** @var TypeFactory */
77			public $types;
78
79			/** @var FieldRegistry */
80			public $fields;
81
82			/** @var IdentifiersProvider */
83			public $identifiers;
84
85			/** @var Menu */
86			public $menu;
87
88			/** @var MobileDetector */
89			public $detector;
90
91			/** @var CommentParser */
92			public $parser;
93
94			/** @var AccessControl */
95			public $access;
96
97			/** @var ActionGroups */
98			public $groups;
99
100			/** @var null\|ExecutionToken */
101			public $token;
102
103			/** @var string */
104			public $defaultAction = self::INDEX_ACTION;
105
106			/**
107			* @param Factory $factory <-
108			* @param ActionRegistry $actions <-
109			* @param FieldRegistry $fields <-
110			* @param RendererRegistry $renderers <-
111			* @param LinkRegistry $links <-
112			* @param IdentifiersProvider $identifiers <-
113			* @param TypeFactory $types <-
114			* @param MobileDetector $detect <-
115			* @param WebCommentParser $parser <-
116			* @param AccessControl $access <-
117			*/
118			public function __construct(Factory $factory, ActionRegistry $actions, FieldRegistry $fields,
119			RendererRegistry $renderers, LinkRegistry $links, IdentifiersProvider $identifiers,
120			TypeFactory $types, MobileDetector $detect, WebCommentParser $parser,
121			AccessControl $access) {
122			$factory->setSingleton($this);
123
124			$this->factory = $factory;
125			$this->actions = $actions;
126			$this->renderers = $renderers;
127			$this->links = $links;
128			$this->types = $types;
129			$this->fields = $fields;
130			$this->identifiers = $identifiers;
131			$this->detector = $detect;
132			$this->parser = $parser;
133			$this->access = $access;
134			$this->menu = new Menu($actions);
			0 ignored issues – show Unused Code introduced 2015-11-20 23:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Menu::__construct()` has too many arguments starting with `$actions`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
135			$this->groups = new ActionGroups($actions);
136			}
137
138			/**
139			* @param callable $callback Receives the WebApplication instance
140			* @param null\|Factory $factory
141			* @return Factory
142			*/
143			public static function init(callable $callback, Factory $factory = null) {
144			/** @var self $instance */
145			$factory = $factory ?: new Factory();
146			$instance = $factory->getInstance(self::class);
147
148			$instance->registerDefaultAction();
149
150			$callback($factory->setSingleton($instance));
151
152			$instance->prepare();
153
154			return $factory;
155			}
156
157			/**
158			* @param string $name
159			*/
160			public function setNameAndBrand($name) {
161			$this->name = $name;
162			$this->menu->setBrand($name);
163			}
164
165			private function registerDefaultAction() {
			0 ignored issues – show Unused Code introduced 2016-02-29 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method is not used, and could be removed. Loading history...
166			$this->actions->add(self::INDEX_ACTION , new ListActions($this->actions, $this->groups, $this->access, $this->parser));
167			}
168
169			public function prepare() {
170			$this->registerRenderers();
171			$this->registerFields();
172			}
173
174			private function registerRenderers() {
175			$links = new LinkPrinter($this->links, $this->actions, $this->parser, $this->token);
			0 ignored issues – show Compatibility introduced 2016-05-17 05:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->parser` of type `object<rtens\domin\reflection\CommentParser>` is not a sub-type of `object<rtens\domin\delivery\web\WebCommentParser>`. It seems like you assume a child class of the class `rtens\domin\reflection\CommentParser` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
176
177			$this->renderers->add(new ElementRenderer());
178			$this->renderers->add(new BooleanRenderer());
179			$this->renderers->add(new ColorRenderer());
180			$this->renderers->add(new PrimitiveRenderer());
181			$this->renderers->add(new DateTimeRenderer());
182			$this->renderers->add(new DateIntervalRenderer());
183			$this->renderers->add(new TextRenderer());
184			$this->renderers->add(new HtmlRenderer());
185			$this->renderers->add(new IdentifierRenderer($links));
186			$this->renderers->add(new FileRenderer());
187			$this->renderers->add(new ImageRenderer());
188			$this->renderers->add(new ScatterChartRenderer());
189			$this->renderers->add(new ChartRenderer());
190			$this->renderers->add(new DelayedOutputRenderer());
191			$this->renderers->add(new DashboardItemRenderer($this->renderers));
192			$this->renderers->add(new ActionListRenderer($this->parser));
193			$this->renderers->add(new ActionPanelRenderer($this->renderers, $this->actions, $this->fields));
194			$this->renderers->add(new DataTableRenderer($this->renderers));
195			$this->renderers->add(new TableRenderer($this->renderers, $links));
196			$this->renderers->add(new ListRenderer($this->renderers, $links));
197			$this->renderers->add(new MapRenderer($this->renderers, $links));
198			$this->renderers->add(new ObjectRenderer($this->renderers, $this->types, $links));
199			}
200
201			private function registerFields() {
202			$this->fields->add(new StringField());
203			$this->fields->add(new NumberField());
204			$this->fields->add(new RangeField($this->detector));
205			$this->fields->add(new BooleanField());
206			$this->fields->add(new ColorField());
207			$this->fields->add(new FileField());
208			$this->fields->add(new ImageField());
209			$this->fields->add(new TextField());
210			$this->fields->add(new HtmlField());
211			$this->fields->add(new DateTimeField());
212			$this->fields->add(new DateIntervalField());
213			$this->fields->add(new ArrayField($this->fields, $this->detector));
214			$this->fields->add(new NullableField($this->fields));
215			$this->fields->add(new ActionField($this->fields, $this->actions));
216			$this->fields->add(new ObjectField($this->types, $this->fields));
217			$this->fields->add(new MultiField($this->fields));
218			$this->fields->add(new IdentifierField($this->fields, $this->identifiers));
219			$this->fields->add(new EnumerationField($this->fields));
220			}
221			}

rtens / domin

Issues (90)

Security Analysis no request data

src/delivery/web/WebApplication.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like