DelayedOutput::surroundWith() - Code Metrics - Inspection of "Added support for delayed output" - rtens/domin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 15cb6d...86e5be )

by Nikolas

created 2015-12-03 08:48 UTC

DelayedOutput::surroundWith() A

↳ Parent: DelayedOutput

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
rs	9.4286
cc	1
eloc	6
nc	1
nop	2

<?php namespace rtens\domin\delivery;

class DelayedOutput {

    /** @var callable */
    private $runner;

    /** @var callable */
    private $printer;

    /**
     * @param callable $runner Will be called with the object itself, returns void
     */
    public function __construct(callable $runner) {
        $this->runner = $runner;
        $this->printer = function ($string) {
            echo $string;
        };
    }

    public function write($message) {
        call_user_func($this->printer, $message);
    }

    public function writeLine($message) {
        $this->write($message . "\n");
    }

    function __toString() {

        call_user_func($this->runner, $this);
        return '';
    }

    public function surroundWith($before, $after) {
        $oldRunner = $this->runner;
        $this->runner = function (DelayedOutput $output) use ($oldRunner, $before, $after) {
            $this->write($before);
            call_user_func($oldRunner, $output);
            $this->write($after);
        };
    }

    /**
     * @param callable $printer
     */
    public function setPrinter(callable $printer) {
        $this->printer = $printer;
    }
}

1			<?php namespace rtens\domin\delivery;
2
3			class DelayedOutput {
4
5			/** @var callable */
6			private $runner;
7
8			/** @var callable */
9			private $printer;
10
11			/**
12			* @param callable $runner Will be called with the object itself, returns void
13			*/
14			public function __construct(callable $runner) {
15			$this->runner = $runner;
16			$this->printer = function ($string) {
17			echo $string;
18			};
19			}
20
21			public function write($message) {
22			call_user_func($this->printer, $message);
23			}
24
25			public function writeLine($message) {
26			$this->write($message . "\n");
27			}
28
29			function __toString() {
			0 ignored issues – show Best Practice introduced 2015-12-03 08:51 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
30			call_user_func($this->runner, $this);
31			return '';
32			}
33
34			public function surroundWith($before, $after) {
35			$oldRunner = $this->runner;
36			$this->runner = function (DelayedOutput $output) use ($oldRunner, $before, $after) {
37			$this->write($before);
38			call_user_func($oldRunner, $output);
39			$this->write($after);
40			};
41			}
42
43			/**
44			* @param callable $printer
45			*/
46			public function setPrinter(callable $printer) {
47			$this->printer = $printer;
48			}
49			}

rtens / domin

Push — master ( 15cb6d...86e5be )

DelayedOutput::surroundWith() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like