rtens\domin\delivery\web\BreadCrumbsTrail

Complexity

Total Complexity

15

Size/Duplication

Total Lines	93
Duplicated Lines	15.05 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	hasCrumbs()	0	3	1
A	getCrumbs()	0	3	1
A	getLastCrumb()	0	6	2
A	updateCrumbs()	0	15	3
A	reset()	0	3	1
A	makeTarget()	14	14	3
A	readRawParameters()	0	10	3

<?php
namespace rtens\domin\delivery\web;

use rtens\domin\Action;
use rtens\domin\delivery\ParameterReader;

class BreadCrumbsTrail {

    /** @var BreadCrumb[] */
    private $crumbs;

    /** @var ParameterReader */
    private $reader;

    /**
     * @param ParameterReader $reader
     * @param BreadCrumb[] $crumbs
     */
    public function __construct(ParameterReader $reader, array $crumbs) {
        $this->crumbs = $crumbs;
        $this->reader = $reader;
    }

    /**
     * @return bool
     */
    public function hasCrumbs() {
        return !empty($this->crumbs);
    }

    /**
     * @return array|BreadCrumb[]
     */
    public function getCrumbs() {
        return $this->crumbs;
    }

    /**
     * @return BreadCrumb
     * @throws \Exception If there are no crumbs
     */
    public function getLastCrumb() {
        if (!$this->hasCrumbs()) {
            throw new \Exception("There are no crumbs");
        }
        return $this->crumbs[count($this->crumbs) - 1];
    }

    /**
     * @param Action $action
     * @param string $actionId
     * @return array|BreadCrumb[]
     */
    public function updateCrumbs(Action $action, $actionId) {
        $current = new BreadCrumb($action->caption(), $this->makeTarget($actionId, $action));

        $newCrumbs = [];
        foreach ($this->crumbs as $crumb) {
            if ($crumb == $current) {
                break;
            }
            $newCrumbs[] = $crumb;
        }
        $newCrumbs[] = $current;

        $this->crumbs = $newCrumbs;
        return $newCrumbs;
    }

    public function reset() {
        $this->crumbs = [];
    }

    private function makeTarget($actionId, Action $action) {

This method seems to be duplicated in your project.

        $target = $actionId;

        $parameters = $this->readRawParameters($action);
        if ($parameters) {

The expression $parameters of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $keyValues = [];
            foreach ($parameters as $key => $value) {
                $keyValues[] = urlencode($key) . '=' . urlencode($value);
            }
            $target .= '?' . implode('&', $keyValues);
        }

        return $target;
    }

    private function readRawParameters(Action $action) {
        $values = [];

        foreach ($action->parameters() as $parameter) {
            if ($this->reader->has($parameter)) {
                $values[$parameter->getName()] = $this->reader->read($parameter);
            }
        }
        return $values;
    }
}