rtens\domin\delivery\web\ActionForm

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	13.73 %

Coupling/Cohesion

Components	0
Dependencies	8

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getModel()	0	3	1
A	getHeadElements()	0	3	1
A	getActionField()	7	7	2
A	readParameters()	0	12	3

<?php
namespace rtens\domin\delivery\web;

use rtens\domin\Action;
use rtens\domin\Parameter;
use watoki\curir\delivery\WebRequest;
use watoki\reflect\type\ClassType;

class ActionForm {

    /** @var array */
    private $model;

    /** @var array|Element[] */
    private $headElements = [];

    public function __construct(WebRequest $request, WebApplication $app, Action $action, $actionId) {
        $actionParameter = new Parameter($actionId, new ClassType(get_class($action)));
        $actionField = $this->getActionField($actionParameter, $app);

        $this->model = $actionField->render($actionParameter, $this->readParameters($request, $app, $action));

It seems like $actionField->render($actionParameter, $this->readParameters($request, $app, $action)) of type string is incompatible with the declared type array of property $model.

        $this->headElements = $actionField->headElements($actionParameter);
    }

    public function getModel() {
        return $this->model;
    }

    public function getHeadElements() {
        return $this->headElements;
    }

    /**
     * @param Parameter $actionParameter
     * @param WebApplication $app
     * @return WebField
     * @throws \Exception
     */
    private function getActionField(Parameter $actionParameter, WebApplication $app) {

This method seems to be duplicated in your project.

        $actionField = $app->fields->getField($actionParameter);
        if ($actionField instanceof WebField) {
            return $actionField;
        }
        throw new \Exception(get_class($actionField) . " must implement WebField");
    }

    private function readParameters(WebRequest $request, WebApplication $app, Action $action) {
        $reader = new RequestParameterReader($request);
        $values = [];

        foreach ($action->parameters() as $parameter) {
            if ($reader->has($parameter)) {
                $field = $app->fields->getField($parameter);
                $values[$parameter->getName()] = $field->inflate($parameter, $reader->read($parameter));
            }
        }
        return $values;
    }
}