rtens\domin\execution\RedirectResult

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	34.38 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getUrl()	11	11	3

<?php
namespace rtens\domin\execution;

class RedirectResult implements ExecutionResult {

    /** @var string */
    private $target;

    /** @var array|\string[] */
    private $parameters;

    /**
     * @param string $target
     * @param string[] $parameters
     */
    public function __construct($target, array $parameters = []) {
        $this->target = $target;
        $this->parameters = $parameters;
    }

    /**
     * @return string
     */
    public function getUrl() {

This method seems to be duplicated in your project.

        $url = $this->target;
        if ($this->parameters) {

The expression $this->parameters of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $keyValues = [];
            foreach ($this->parameters as $key => $value) {
                $keyValues[] = urlencode($key) . '=' . urlencode($value);
            }
            $url .= '?' . implode('&', $keyValues);
        }
        return $url;
    }
}