Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | class CurirBreadCrumbsTrail extends BreadCrumbsTrail { |
||
12 | |||
13 | const COOKIE_KEY = 'domin_trail'; |
||
14 | |||
15 | /** @var CookieStore */ |
||
16 | private $cookies; |
||
17 | |||
18 | public function __construct(ParameterReader $reader, CookieStore $cookies) { |
||
22 | |||
23 | public function updateCrumbs(Action $action, $actionId) { |
||
26 | |||
27 | /** |
||
28 | * @param CookieStore $cookies |
||
29 | * @return BreadCrumb[] |
||
30 | */ |
||
31 | private function readCrumbs(CookieStore $cookies) { |
||
39 | |||
40 | /** |
||
41 | * @param BreadCrumb[] $crumbs |
||
42 | * @return BreadCrumb[] |
||
43 | */ |
||
44 | View Code Duplication | private function saveCrumbs($crumbs) { |
|
53 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.