ActionListResource::assembleActions() - Code Metrics - Inspection of "Made domin delivery system independent and extract..." - rtens/domin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

by Nikolas

created 2016-01-26 13:01 UTC

ActionListResource::assembleActions() A

↳ Parent: ActionListResource

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	8
nc	2
nop	0

<?php
namespace rtens\domin\delivery\web\resources;

use rtens\domin\delivery\web\BreadCrumbsTrail;
use rtens\domin\delivery\web\HeadElements;
use rtens\domin\delivery\web\WebApplication;

class ActionListResource {

    /** @var WebApplication  */
    private $app;

    /** @var BreadCrumbsTrail */
    private $crumbs;

    public function __construct(WebApplication $app, BreadCrumbsTrail $crumbs) {
        $this->app = $app;
        $this->crumbs = $crumbs;
    }

    /**
     * @return string
     */
    public function handleGet() {
        $this->app->prepare();
        $this->crumbs->reset();

        global $model;
function myFunction($a, $b) {
    // Do something
}
        $model = [
            'name' => $this->app->name,
            'menu' => $this->app->menu->render(),
            'action' => $this->assembleActions(),
            'headElements' => [
                (string)HeadElements::jquery(),
                (string)HeadElements::bootstrap(),
                (string)HeadElements::bootstrapJs(),
            ]
        ];

        ob_start();
        include __DIR__ . '/ActionListTemplate.html.php';
        return ob_get_clean();
    }

    private function assembleActions() {
        $actions = [];
        foreach ($this->app->actions->getAllActions() as $id => $action) {
            $actions[] = [
                'caption' => $action->caption(),
                'description' => $this->app->parser->shorten($action->description()),
                'link' => ['href' => $id]
            ];
        }
        return $actions;
    }
}

Pull Request — master (#29)

ActionListResource::assembleActions() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			namespace rtens\domin\delivery\web\resources;
3
4			use rtens\domin\delivery\web\BreadCrumbsTrail;
5			use rtens\domin\delivery\web\HeadElements;
6			use rtens\domin\delivery\web\WebApplication;
7
8			class ActionListResource {
9
10			/** @var WebApplication */
11			private $app;
12
13			/** @var BreadCrumbsTrail */
14			private $crumbs;
15
16			public function __construct(WebApplication $app, BreadCrumbsTrail $crumbs) {
17			$this->app = $app;
18			$this->crumbs = $crumbs;
19			}
20
21			/**
22			* @return string
23			*/
24			public function handleGet() {
25			$this->app->prepare();
26			$this->crumbs->reset();
27
28			global $model;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 13:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
29			$model = [
30			'name' => $this->app->name,
31			'menu' => $this->app->menu->render(),
32			'action' => $this->assembleActions(),
33			'headElements' => [
34			(string)HeadElements::jquery(),
35			(string)HeadElements::bootstrap(),
36			(string)HeadElements::bootstrapJs(),
37			]
38			];
39
40			ob_start();
41			include __DIR__ . '/ActionListTemplate.html.php';
42			return ob_get_clean();
43			}
44
45			private function assembleActions() {
46			$actions = [];
47			foreach ($this->app->actions->getAllActions() as $id => $action) {
48			$actions[] = [
49			'caption' => $action->caption(),
50			'description' => $this->app->parser->shorten($action->description()),
51			'link' => ['href' => $id]
52			];
53			}
54			return $actions;
55			}
56			}

rtens / domin

Pull Request — master (#29)

ActionListResource::assembleActions() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like