LinkPrinter::makeUrl() - Code Metrics - Inspection of "Made domin delivery system independent and extract..." - rtens/domin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

by Nikolas

created 2016-01-26 13:01 UTC

LinkPrinter::makeUrl() A

↳ Parent: LinkPrinter

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	13
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	13
loc	13
rs	9.4285
cc	3
eloc	8
nc	2
nop	2

<?php
namespace rtens\domin\delivery\web\renderers\link;

use rtens\domin\ActionRegistry;
use rtens\domin\delivery\web\Element;
use rtens\domin\delivery\web\resources\ExecutionResource;
use rtens\domin\delivery\web\WebCommentParser;

class LinkPrinter {

    /** @var LinkRegistry */
    private $links;

    /** @var ActionRegistry */
    private $actions;

    /** @var WebCommentParser */
    private $parser;

    public function __construct(LinkRegistry $links, ActionRegistry $actions, WebCommentParser $parser) {
        $this->links = $links;
        $this->actions = $actions;
        $this->parser = $parser;
    }

    /**
     * @param mixed $object
     * @return array
     */
    public function createLinkElements($object) {
        return $this->createLinks($object, 'btn btn-xs btn-primary');
    }

    /**
     * @param mixed $object
     * @param string|null $caption
     * @return array|\rtens\domin\delivery\web\Element[]
     */
    public function createDropDown($object, $caption = null) {
        $links = $this->createLinks($object);
        if (empty($links)) {
            return [];
        }

        if (!$caption) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if (is_object($object)) {
                $caption = (new \ReflectionClass($object))->getShortName();
            } else {
                $caption = 'Actions';
            }
        }

        return [
            new Element('div', ['class' => 'dropdown'], [
                new Element('button', [
                    'class' => 'btn btn-xs btn-primary dropdown-toggle',
                    'type' => 'button',
                    'data-toggle' => 'dropdown',
                    'aria-haspopup' => 'true',
                    'aria-expanded' => 'false'
                ], [
                    $caption,
                    new Element('span', ['class' => 'caret'])
                ]),
                new Element('ul', ['class' => 'dropdown-menu'], array_map(function (Element $element) {
                    return new Element('li', [], [$element]);
                }, $links))
            ])
        ];
    }

    private function createLinks($object, $classes = '') {
        return array_map(function (Link $link) use ($object, $classes) {
            $action = $this->actions->getAction($link->actionId());

            $parameters = $link->parameters($object);
            if ($link->force()) {
                $parameters[ExecutionResource::FORCE_ARG] = true;
            }

            $attributes = ['class' => $classes, 'href' => $this->makeUrl($link->actionId(), $parameters)];
            if ($link->confirm() !== null) {
                $attributes['onclick'] = "return confirm('{$link->confirm()}');";
            }
            $description = $action->description();
            if (!is_null($description)) {
                $attributes['title'] = str_replace('"', "'", strip_tags($this->parser->shorten($description)));
            }
            return new Element('a', $attributes, [
                $action->caption()
            ]);
        }, $this->links->getLinks($object));
    }

    private function makeUrl($actionId, array $parameters) {

        $url = $actionId;

        if ($parameters) {

            $keyValues = [];
            foreach ($parameters as $key => $value) {
                $keyValues[] = urlencode($key) . '=' . urlencode($value);
            }
            $url .= '?' . implode('&', $keyValues);
        }

        return $url;
    }
}

1		<?php
2		namespace rtens\domin\delivery\web\renderers\link;
3
4		use rtens\domin\ActionRegistry;
5		use rtens\domin\delivery\web\Element;
6		use rtens\domin\delivery\web\resources\ExecutionResource;
7		use rtens\domin\delivery\web\WebCommentParser;
8
9		class LinkPrinter {
10
11		/** @var LinkRegistry */
12		private $links;
13
14		/** @var ActionRegistry */
15		private $actions;
16
17		/** @var WebCommentParser */
18		private $parser;
19
20		public function __construct(LinkRegistry $links, ActionRegistry $actions, WebCommentParser $parser) {
21		$this->links = $links;
22		$this->actions = $actions;
23		$this->parser = $parser;
24		}
25
26		/**
27		* @param mixed $object
28		* @return array
29		*/
30		public function createLinkElements($object) {
31		return $this->createLinks($object, 'btn btn-xs btn-primary');
32		}
33
34		/**
35		* @param mixed $object
36		* @param string\|null $caption
37		* @return array\|\rtens\domin\delivery\web\Element[]
38		*/
39		public function createDropDown($object, $caption = null) {
40		$links = $this->createLinks($object);
41		if (empty($links)) {
42		return [];
43		}
44
45		if (!$caption) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-20 23:12 UTC by Report Bug Copy Issue Report The expression `$caption` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
46		if (is_object($object)) {
47		$caption = (new \ReflectionClass($object))->getShortName();
48		} else {
49		$caption = 'Actions';
50		}
51		}
52
53		return [
54		new Element('div', ['class' => 'dropdown'], [
55		new Element('button', [
56		'class' => 'btn btn-xs btn-primary dropdown-toggle',
57		'type' => 'button',
58		'data-toggle' => 'dropdown',
59		'aria-haspopup' => 'true',
60		'aria-expanded' => 'false'
61		], [
62		$caption,
63		new Element('span', ['class' => 'caret'])
64		]),
65		new Element('ul', ['class' => 'dropdown-menu'], array_map(function (Element $element) {
66		return new Element('li', [], [$element]);
67		}, $links))
68		])
69		];
70		}
71
72		private function createLinks($object, $classes = '') {
73		return array_map(function (Link $link) use ($object, $classes) {
74		$action = $this->actions->getAction($link->actionId());
75
76		$parameters = $link->parameters($object);
77		if ($link->force()) {
78		$parameters[ExecutionResource::FORCE_ARG] = true;
79		}
80
81		$attributes = ['class' => $classes, 'href' => $this->makeUrl($link->actionId(), $parameters)];
82		if ($link->confirm() !== null) {
83		$attributes['onclick'] = "return confirm('{$link->confirm()}');";
84		}
85		$description = $action->description();
86		if (!is_null($description)) {
87		$attributes['title'] = str_replace('"', "'", strip_tags($this->parser->shorten($description)));
88		}
89		return new Element('a', $attributes, [
90		$action->caption()
91		]);
92		}, $this->links->getLinks($object));
93		}
94
95	View Code Duplication	private function makeUrl($actionId, array $parameters) {
		0 ignored issues – show Duplication introduced 2016-01-26 13:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		$url = $actionId;
97
98		if ($parameters) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-26 13:15 UTC by Report Bug Copy Issue Report The expression `$parameters` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
99		$keyValues = [];
100		foreach ($parameters as $key => $value) {
101		$keyValues[] = urlencode($key) . '=' . urlencode($value);
102		}
103		$url .= '?' . implode('&', $keyValues);
104		}
105
106		return $url;
107		}
108		}

rtens / domin

Pull Request — master (#29)

LinkPrinter::makeUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like