Code Duplication - rtens/domin - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 13-14 lines in 2 locations

src/delivery/web/BreadCrumbsTrail.php 1 location


        $this->crumbs = [];
    }

    private function makeTarget($actionId, Action $action) {
        $target = $actionId;

        $parameters = $this->readRawParameters($action);
        if ($parameters) {
            $keyValues = [];
            foreach ($parameters as $key => $value) {
                $keyValues[] = urlencode($key) . '=' . urlencode($value);
            }
            $target .= '?' . implode('&', $keyValues);
        }

        return $target;
    }

    private function readRawParameters(Action $action) {
        $values = [];

src/delivery/web/renderers/link/LinkPrinter.php 1 location


        }, $this->links->getLinks($object));
    }

    private function makeUrl($actionId, array $parameters) {
        $url = $actionId;

        if ($parameters) {
            $keyValues = [];
            foreach ($parameters as $key => $value) {
                $keyValues[] = urlencode($key) . '=' . urlencode($value);
            }
            $url .= '?' . implode('&', $keyValues);
        }

        return $url;
    }
}

		@@ 74-87 (lines=14) @@
71		$this->crumbs = [];
72		}
73
74		private function makeTarget($actionId, Action $action) {
75		$target = $actionId;
76
77		$parameters = $this->readRawParameters($action);
78		if ($parameters) {
79		$keyValues = [];
80		foreach ($parameters as $key => $value) {
81		$keyValues[] = urlencode($key) . '=' . urlencode($value);
82		}
83		$target .= '?' . implode('&', $keyValues);
84		}
85
86		return $target;
87		}
88
89		private function readRawParameters(Action $action) {
90		$values = [];

		@@ 95-107 (lines=13) @@
92		}, $this->links->getLinks($object));
93		}
94
95		private function makeUrl($actionId, array $parameters) {
96		$url = $actionId;
97
98		if ($parameters) {
99		$keyValues = [];
100		foreach ($parameters as $key => $value) {
101		$keyValues[] = urlencode($key) . '=' . urlencode($value);
102		}
103		$url .= '?' . implode('&', $keyValues);
104		}
105
106		return $url;
107		}
108		}

rtens / domin

Code Duplication Length = 13-14 lines in 2 locations

src/delivery/web/BreadCrumbsTrail.php 1 location

src/delivery/web/renderers/link/LinkPrinter.php 1 location