rtens\domin\delivery\web\renderers\charting\charts\DataSetChart

Complexity

Total Complexity

10

Size/Duplication

Total Lines	73
Duplicated Lines	10.96 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	data()	8	17	3
A	getLabels()	0	3	1
A	getDataSets()	0	3	1
A	addDataSet()	0	4	1
A	makeLabels()	0	11	3

<?php
namespace rtens\domin\delivery\web\renderers\charting\charts;

use rtens\domin\delivery\web\renderers\charting\Chart;
use rtens\domin\delivery\web\renderers\charting\data\DataSet;

abstract class DataSetChart extends Chart {

    /** @var null|string[] */
    private $labels;

    /** @var DataSet[] */
    private $dataSets = [];

    /**
     * LineChart constructor.
     * @param null|string[] $labels
     * @param DataSet[] $dataSets
     */
    public function __construct(array $labels = null, array $dataSets = []) {
        parent::__construct();
        $this->labels = $labels;
        $this->dataSets = $dataSets;
    }

    public function data() {
        $dataSets = $this->getDataSets();
        if (!$dataSets) {

The expression $dataSets of type rtens\domin\delivery\web\renderers\charting\data\DataSet[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }
        return [
            "labels" => $this->makeLabels(),
            "datasets" => array_map(function (DataSet $set) {

This code seems to be duplicated across your project.

                return array_merge(
                    [
                        "label" => $set->getLabel(),
                        "data" => $set->getValues()
                    ],
                    $this->makePalette($set->getColor() ?: $this->provideColor()));
            }, $dataSets)
        ];
    }

    /**
     * @return null|string[]
     */
    public function getLabels() {
        return $this->labels;
    }

    /**
     * @return DataSet[]
     */
    public function getDataSets() {
        return $this->dataSets;
    }

    /**
     * @param DataSet $set
     * @return $this
     */
    public function addDataSet(DataSet $set) {
        $this->dataSets[] = $set;
        return $this;
    }

    private function makeLabels() {
        if ($this->labels) {
            return $this->labels;
        }
        $count = 0;
        foreach ($this->dataSets as $set) {
            $count = max($count, count($set->getValues()));
        }

        return range(1, $count);
    }

}