Alxarafe\Database\YamlSchema::loadXmlFile()

Complexity

Conditions	8
Paths	7

Size

Total Lines	33
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private static function loadXmlFile(string $tablename): \SimpleXMLElement
    {
        $filename = self::getXmlPath($tablename);
        if (empty($filename)) {
            die($tablename . ' XML not found');

Using exit here is not recommended.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SimpleXMLElement. Consider adding a return statement or allowing null as return value.

        }

        if (!file_exists($filename)) {
            die('Archivo ' . $filename . ' no encontrado.');

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SimpleXMLElement. Consider adding a return statement or allowing null as return value.

Using exit here is not recommended.

        }

        $xml = simplexml_load_string(file_get_contents($filename, FILE_USE_INCLUDE_PATH));

Alxarafe\Database\FILE_USE_INCLUDE_PATH of type integer is incompatible with the type boolean expected by parameter $use_include_path of file_get_contents().

        if (!$xml) {

$xml is of type SimpleXMLElement, thus it always evaluated to true.

            die('Error al leer el archivo ' . $filename);

Using exit here is not recommended.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SimpleXMLElement. Consider adding a return statement or allowing null as return value.

        }

        if (!isset($xml->incluye) || $xml->incluye->count() === 0) {
            return $xml;
        }

        // Si hay un apartado "incluye", hay que incluir las rutas
        foreach ($xml->incluye->children() as $item) {
            $includeFilename = './' . trim(reset($item));

It seems like $item can also be of type null; however, parameter $array of reset() does only seem to accept array|object, maybe add an additional type check?

            $xmlParent = simplexml_load_string(file_get_contents($includeFilename, FILE_USE_INCLUDE_PATH));
            if (!$xmlParent) {
                die('Error al leer el archivo ' . $includeFilename);

Using exit here is not recommended.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SimpleXMLElement. Consider adding a return statement or allowing null as return value.

            }

            $xml = self::mergeXml($xmlParent, $xml);
        }

        return $xml;
    }