Singleton::__construct() - Code Metrics - Inspection of "Singletons are protected from incorrect instantiat..." - rsanjoseo/alxarafe - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Push — main ( 269cf1...da3911 )

by Rafael

created 2021-08-21 09:09 UTC

Singleton::__construct() A

↳ Parent: Singleton

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	7
rs	10

<?php

namespace Alxarafe\Core\Base;

use Alxarafe\Core\Utils\ClassUtils;

abstract class Singleton
{
    /**
     * Hold the classes on instance.
     *
     * @var array
     */
    private static array $instances = [];

    public function __construct(string $index = 'main')
    {
        $className = self::getClassName();
        if (isset(self::$instances[$className][$index])) {
            die("Please use '$className:getInstance()' instead of 'new' to instantiate a Singleton.");

        }
        self::$instances[$className][$index] = $this;
    }

    /**
     * Returns the class name.
     *
     * @return string
     */
    protected static function getClassName(): string
    {
        $class = static::class;
        return ClassUtils::getShortName($class, $class);
    }

    /**
     * The object is created from within the class itself only if the class
     * has no instance.
     *
     * We opted to use an array to make several singletons according to the
     * index passed to getInstance
     *
     * @param string $index
     *
     * @return mixed
     */
    public static function getInstance(string $index = 'main')
    {
        $className = self::getClassName();
        if (!isset(self::$instances[$className][$index])) {
            new static($index);
        }
        return self::$instances[$className][$index];
    }

}

1			<?php
2
3			namespace Alxarafe\Core\Base;
4
5			use Alxarafe\Core\Utils\ClassUtils;
6
7			abstract class Singleton
8			{
9			/**
10			* Hold the classes on instance.
11			*
12			* @var array
13			*/
14			private static array $instances = [];
15
16			public function __construct(string $index = 'main')
17			{
18			$className = self::getClassName();
19			if (isset(self::$instances[$className][$index])) {
20			die("Please use '$className:getInstance()' instead of 'new' to instantiate a Singleton.");
			0 ignored issues – show Best Practice introduced 2021-08-21 09:16 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
21			}
22			self::$instances[$className][$index] = $this;
23			}
24
25			/**
26			* Returns the class name.
27			*
28			* @return string
29			*/
30			protected static function getClassName(): string
31			{
32			$class = static::class;
33			return ClassUtils::getShortName($class, $class);
34			}
35
36			/**
37			* The object is created from within the class itself only if the class
38			* has no instance.
39			*
40			* We opted to use an array to make several singletons according to the
41			* index passed to getInstance
42			*
43			* @param string $index
44			*
45			* @return mixed
46			*/
47			public static function getInstance(string $index = 'main')
48			{
49			$className = self::getClassName();
50			if (!isset(self::$instances[$className][$index])) {
51			new static($index);
52			}
53			return self::$instances[$className][$index];
54			}
55
56			}

rsanjoseo / alxarafe

Push — main ( 269cf1...da3911 )

Singleton::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like