Controller::url() - Code Metrics - Inspection of "A BasicController controller is created without ac..." - rsanjoseo/alxarafe - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( 8e55b2...88c391 )

by Rafael

created 2021-09-18 10:16 UTC

Controller::url() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	3
rs	10

<?php
/**
 * Alxarafe. Development of PHP applications in a flash!
 * Copyright (C) 2018 Alxarafe <[email protected]>
 */

namespace Alxarafe\Core\Base;

use Alxarafe\Database\Engine;
use Alxarafe\Database\SqlHelper;
use DebugBar\DebugBarException;

/**
 * Class Controller
 *
 * The controller is who responds to the various events.
 *
 * @package Alxarafe\Core\Base
 */
abstract class Controller extends BasicController
{
    /**
     * The database engine.
     *
     * @var Engine
     */
    public static Engine $engine;

    /**
     * The database SQL Helper.
     *
     * @var SqlHelper
     */
    public static SqlHelper $sqlHelper;

    /**
     * It contains an instance of the view class, or null if it is
     * not assigned, or does not have an associated view.
     *
     * @var View
     */
    public View $view;

    public function __construct()
    {
        parent::__construct();

        $this->hasMenu = true;
    }

    /**
     * Initialization of variables required for all controllers
     *
     * @return bool
     * @throws DebugBarException
     */
    public function preLoad(): bool
    {
        if (!parent::preLoad() || !$this->configExists) {
            die('No existe el archivo de configuración!'); // No tendría que haber llegado aquí, pero sin configuración, no se puede utilizar base de datos.
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        }

        if (!$this->config->connectToDatabaseAndAuth()) {
            return false;
        }

        self::$engine = $this->config->getEngine();
        self::$sqlHelper = $this->config->getSqlHelper();

        $this->action = filter_input(INPUT_POST, 'action', FILTER_DEFAULT);

        // TODO: This will have to be assigned in a yaml file, when activating and deactivating modules.
        $this->translator->addDirs([
            constant('BASE_FOLDER') . '/Modules/Main',
        ]);

        return true;
    }

}


1			<?php
2			/**
3			* Alxarafe. Development of PHP applications in a flash!
4			* Copyright (C) 2018 Alxarafe <[email protected]>
5			*/
6
7			namespace Alxarafe\Core\Base;
8
9			use Alxarafe\Database\Engine;
10			use Alxarafe\Database\SqlHelper;
11			use DebugBar\DebugBarException;
12
13			/**
14			* Class Controller
15			*
16			* The controller is who responds to the various events.
17			*
18			* @package Alxarafe\Core\Base
19			*/
20			abstract class Controller extends BasicController
21			{
22			/**
23			* The database engine.
24			*
25			* @var Engine
26			*/
27			public static Engine $engine;
28
29			/**
30			* The database SQL Helper.
31			*
32			* @var SqlHelper
33			*/
34			public static SqlHelper $sqlHelper;
35
36			/**
37			* It contains an instance of the view class, or null if it is
38			* not assigned, or does not have an associated view.
39			*
40			* @var View
41			*/
42			public View $view;
43
44			public function __construct()
45			{
46			parent::__construct();
47
48			$this->hasMenu = true;
49			}
50
51			/**
52			* Initialization of variables required for all controllers
53			*
54			* @return bool
55			* @throws DebugBarException
56			*/
57			public function preLoad(): bool
58			{
59			if (!parent::preLoad() \|\| !$this->configExists) {
60			die('No existe el archivo de configuración!'); // No tendría que haber llegado aquí, pero sin configuración, no se puede utilizar base de datos.
			0 ignored issues – show Best Practice introduced 2021-09-18 10:26 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug Best Practice introduced 2021-09-18 10:26 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
61			}
62
63			if (!$this->config->connectToDatabaseAndAuth()) {
64			return false;
65			}
66
67			self::$engine = $this->config->getEngine();
68			self::$sqlHelper = $this->config->getSqlHelper();
69
70			$this->action = filter_input(INPUT_POST, 'action', FILTER_DEFAULT);
71
72			// TODO: This will have to be assigned in a yaml file, when activating and deactivating modules.
73			$this->translator->addDirs([
74			constant('BASE_FOLDER') . '/Modules/Main',
75			]);
76
77			return true;
78			}
79
80			}
81

rsanjoseo / alxarafe

Push — main ( 8e55b2...88c391 )

Controller::url() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like