ArbitrarySingle::withAttribute() - Code Metrics - Inspection of "Fix name of ArbitraryEmpty element class" - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( fcec52...178474 )

by Royall

created 2016-11-25 01:58 UTC

ArbitrarySingle::withAttribute() A

↳ Parent: ArbitraryEmpty

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	6
nc	2
nop	2

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Tag\EmptyTag;

/**
 * Class Arbitrary
 * Any type of tag without a matching close tag.
 */
final class ArbitraryEmpty extends AbstractElement
{
    private $name;

    public function __construct(string $name, AttributeSet $attributes = null)
    {
        $this->name = $name;
        $this->attributes = $attributes ?? new AttributeSet();
        $this->tag = new EmptyTag($name, $attributes);
    }

    public function withAttribute(string $name, string $value = null): ArbitraryEmpty
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new ArbitraryEmpty($this->name, $this->attributes->add($attribute));
    }
}


1			<?php
2
3			namespace RoyallTheFourth\HtmlDocument\Element;
4
5			use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6			use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7			use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8			use RoyallTheFourth\HtmlDocument\Tag\EmptyTag;
9
10			/**
11			* Class Arbitrary
12			* Any type of tag without a matching close tag.
13			*/
14			final class ArbitraryEmpty extends AbstractElement
15			{
16			private $name;
17
18			public function __construct(string $name, AttributeSet $attributes = null)
19			{
20			$this->name = $name;
21			$this->attributes = $attributes ?? new AttributeSet();
22			$this->tag = new EmptyTag($name, $attributes);
23			}
24
25			public function withAttribute(string $name, string $value = null): ArbitraryEmpty
26			{
27			if ($value) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
28			$attribute = new StandardAttribute($name, $value);
29			} else {
30			$attribute = new BooleanAttribute($name);
31			}
32
33			return new ArbitraryEmpty($this->name, $this->attributes->add($attribute));
34			}
35			}
36

royallthefourth / html-document

Push — master ( fcec52...178474 )

ArbitrarySingle::withAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like