Style::withAttribute() - Code Metrics - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Style::withAttribute() A
last analyzed 2017-04-08 20:23 UTC

↳ Parent: Style

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	6
nc	2
nop	2

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Set\ElementSet;
use RoyallTheFourth\HtmlDocument\Tag\Standard;

/**
 * Class Style
 * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style
 */
final class Style extends AbstractElement implements ParentElementInterface

{
    public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
    {
        $this->attributes = $attributes ?? new AttributeSet();
        $this->children = $children ?? new ElementSet();
        $this->tag = new Standard('style', $attributes, $children);
    }

    public function withAttribute(string $name, string $value = null): Style
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Style($this->attributes->add($attribute), $this->children);
    }

    public function withChild(ElementInterface $element): Style
    {
        return new Style($this->attributes, $this->children->add($element));
    }

    public function withType(string $mime = 'text/css'): Style
    {
        return $this->withAttribute('type', $mime);
    }

    /**
     * @param string $query
     * @return Style
     * @see https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries
     */
    public function withMedia(string $query = 'all'): Style
    {
        return $this->withAttribute('media', $query);
    }
}


1		<?php
2
3		namespace RoyallTheFourth\HtmlDocument\Element;
4
5		use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6		use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7		use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8		use RoyallTheFourth\HtmlDocument\Set\ElementSet;
9		use RoyallTheFourth\HtmlDocument\Tag\Standard;
10
11		/**
12		* Class Style
13		* @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style
14		*/
15	View Code Duplication	final class Style extends AbstractElement implements ParentElementInterface
		0 ignored issues – show Duplication introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
18		{
19		$this->attributes = $attributes ?? new AttributeSet();
20		$this->children = $children ?? new ElementSet();
21		$this->tag = new Standard('style', $attributes, $children);
22		}
23
24		public function withAttribute(string $name, string $value = null): Style
25		{
26		if ($value) {
		0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
27		$attribute = new StandardAttribute($name, $value);
28		} else {
29		$attribute = new BooleanAttribute($name);
30		}
31
32		return new Style($this->attributes->add($attribute), $this->children);
33		}
34
35		public function withChild(ElementInterface $element): Style
36		{
37		return new Style($this->attributes, $this->children->add($element));
38		}
39
40		public function withType(string $mime = 'text/css'): Style
41		{
42		return $this->withAttribute('type', $mime);
43		}
44
45		/**
46		* @param string $query
47		* @return Style
48		* @see https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries
49		*/
50		public function withMedia(string $query = 'all'): Style
51		{
52		return $this->withAttribute('media', $query);
53		}
54		}
55

royallthefourth / html-document

Style::withAttribute() A last analyzed 2017-04-08 20:23 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Style::withAttribute() A
last analyzed 2017-04-08 20:23 UTC